From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
"ohad@wizery.com" <ohad@wizery.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>
Cc: "guennadi.liakhovetski@linux.intel.com"
<guennadi.liakhovetski@linux.intel.com>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/8] rpmsg: Make RPMSG name service modular
Date: Tue, 20 Oct 2020 09:17:31 +0200 [thread overview]
Message-ID: <f20359a0-6112-4373-7d6e-c60f3065822f@st.com> (raw)
In-Reply-To: <20201019203438.501174-1-mathieu.poirier@linaro.org>
Hi Mathieu,
On 10/19/20 10:34 PM, Mathieu Poirier wrote:
> This set starts by making the RPMSG protocol transport agnostic by
> moving the headers it uses to generic types and using those in the
> current implementation. From there it re-uses the work that Arnaud
> published[1] to make the name service modular.
>
> The main difference with this revision is the usage of a variable
> (rpmsg_device::little_endian) rather than an operation to determine
> the byte representation of the transport layer. It is also
> addressing a problem that would have prevented git bisect to work
> properly in rpmsg_ns_cb() where the rpdev was used.
>
> In short patches 1 to 3 and patch 7 have to be reviewed again. They
> changed enough that I did not add RB tags to them. Patches 4 to 6
> have not changed from the previous revision.
>
> Tested on stm32mp157 with the RPMSG client sample application. Applies
> cleanly on v5.9.
No more comments from my side, thank you very much for your work on this topic!
Regards,
Arnaud
>
> Thanks,
> Mathieu
>
> [1]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=338335
>
> -------
> New for V3:
> - Using rpmsg_device::little_endian variable rather than an operation
> - Fix an implementation problem that would have prevented git bisect to work
>
>
> Arnaud Pouliquen (4):
> rpmsg: virtio: Rename rpmsg_create_channel
> rpmsg: core: Add channel creation internal API
> rpmsg: virtio: Add rpmsg channel device ops
> rpmsg: Turn name service into a stand alone driver
>
> Mathieu Poirier (4):
> rpmsg: Introduce __rpmsg{16|32|64} types
> rpmsg: virtio: Move from virtio to rpmsg byte conversion
> rpmsg: Move structure rpmsg_ns_msg to header file
> rpmsg: Make rpmsg_{register|unregister}_device() public
>
> drivers/rpmsg/Kconfig | 8 ++
> drivers/rpmsg/Makefile | 1 +
> drivers/rpmsg/rpmsg_core.c | 44 ++++++++
> drivers/rpmsg/rpmsg_internal.h | 14 ++-
> drivers/rpmsg/rpmsg_ns.c | 108 ++++++++++++++++++
> drivers/rpmsg/virtio_rpmsg_bus.c | 185 +++++++++++--------------------
> include/linux/rpmsg.h | 63 ++++++++++-
> include/linux/rpmsg_byteorder.h | 67 +++++++++++
> include/linux/rpmsg_ns.h | 59 ++++++++++
> include/uapi/linux/rpmsg_types.h | 11 ++
> 10 files changed, 433 insertions(+), 127 deletions(-)
> create mode 100644 drivers/rpmsg/rpmsg_ns.c
> create mode 100644 include/linux/rpmsg_byteorder.h
> create mode 100644 include/linux/rpmsg_ns.h
> create mode 100644 include/uapi/linux/rpmsg_types.h
>
prev parent reply other threads:[~2020-10-20 7:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 20:34 Mathieu Poirier
2020-10-19 20:34 ` [PATCH v3 1/8] rpmsg: Introduce __rpmsg{16|32|64} types Mathieu Poirier
2020-10-20 7:04 ` Arnaud POULIQUEN
2020-10-19 20:34 ` [PATCH v3 2/8] rpmsg: virtio: Move from virtio to rpmsg byte conversion Mathieu Poirier
2020-10-20 7:05 ` Arnaud POULIQUEN
2020-10-19 20:34 ` [PATCH v3 3/8] rpmsg: Move structure rpmsg_ns_msg to header file Mathieu Poirier
2020-10-20 7:07 ` Arnaud POULIQUEN
2020-10-19 20:34 ` [PATCH v3 4/8] rpmsg: virtio: Rename rpmsg_create_channel Mathieu Poirier
2020-10-19 20:34 ` [PATCH v3 5/8] rpmsg: core: Add channel creation internal API Mathieu Poirier
2020-10-19 20:34 ` [PATCH v3 6/8] rpmsg: virtio: Add rpmsg channel device ops Mathieu Poirier
2020-10-19 20:34 ` [PATCH v3 7/8] rpmsg: Make rpmsg_{register|unregister}_device() public Mathieu Poirier
2020-10-19 20:34 ` [PATCH v3 8/8] rpmsg: Turn name service into a stand alone driver Mathieu Poirier
2020-10-20 7:17 ` Arnaud POULIQUEN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f20359a0-6112-4373-7d6e-c60f3065822f@st.com \
--to=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®