From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CDFFC3A5A7 for ; Mon, 2 Sep 2019 13:02:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44B4621882 for ; Mon, 2 Sep 2019 13:02:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730031AbfIBNC3 (ORCPT ); Mon, 2 Sep 2019 09:02:29 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:49166 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729770AbfIBNC3 (ORCPT ); Mon, 2 Sep 2019 09:02:29 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id ADB4628CB08 Message-ID: Subject: Re: [PATCH RFC 00/12] media: hantro: H264 fixes and improvements From: Ezequiel Garcia To: Jonas Karlman Cc: Mauro Carvalho Chehab , Hans Verkuil , Boris Brezillon , Philipp Zabel , Paul Kocialkowski , "linux-media@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-kernel@vger.kernel.org" Date: Mon, 02 Sep 2019 10:02:14 -0300 In-Reply-To: References: Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonas, Thanks for the series, I'll be reviewing this shortly. On Sun, 2019-09-01 at 12:42 +0000, Jonas Karlman wrote: > This series contains fixes and improvements for the hantro H264 decoder. > > Patch 1-6 fixes issues and limitations observed when preparing support > for field encoded content. > > Patch 7 introduce new DPB entry flags that is used to signal how a reference > frame is referenced. This information is needed to correctly build a > reference list for field encoded content. > > Patch 8 adds bits to handle field encoded content, this is a rough patch > and should be reworked with proper code style and formatting. > Please get back with feedback on how to improve this. > > The following samples from [1] are now playable with patch 1-8 > - H264_1080i-25-interlace_Kaesescheibchen.mkv > - H264_10_1080i_50_AC3-Astra19.2_ProSieben_HD.ts > - big_buck_bunny_1080p_H264_AAC_25fps_7200K.mp4 > - h264_tivo_sample.ts > > The rest of the patches refactors G1 H264 code to more closely match > the code generated by my rockchip-vpu-regtool at [2] and then adds > support for H264 decoding on RK3399/RK3328 using the VPU2 block. > This code is early work and needs proper code style and formatting, > I just wanted to share the early work and get some initial feedback. > > This series has been tested using ffmpeg v4l2 request hwaccel at [3] [4] > What boards have you tested this on? Thanks, Ezequiel