From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED6E23BB694 for ; Thu, 21 May 2026 11:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779361862; cv=none; b=hnFBWioG4hnaCMV46DE11CRmoUOQgUcTg2QqV9U9lTv9Re+CpExWMCyCaQMdx78h0z3o2y5jH1aTbSScN4+orUHCa2aVNNKJUEXeM2z+9jCaTmlfb1cNM91A8OZYmVulXqOdoat18gAad4BqkSm4tTXNNul+r1o3DzHsKRyx9yI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779361862; c=relaxed/simple; bh=UCasNbHDZZYX31WUouMR5aVqtAjsbHcMINcZBQUV5Ss=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m5G0tOEyKQOTc1yGOoXd1tbBDq7/8pisxnCZS75bE6AftHJd8L7PmkY/DVis9tTi6UJWCZFsLqaPbd3V9kCl4aYF+tY0cywUi3zcYeoLjXZ6nxesoKSbZscbR6K5twLQpHuFVPIpL+JBnjM2QygsAbULFG3e0/6uz7xjsvaruN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jtxZsu3F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZPmc5wZL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jtxZsu3F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZPmc5wZL" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L9AMUg3555993 for ; Thu, 21 May 2026 11:11:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SpkIdCGDZCRqXLE6O2n4Iu9e0V/TmezNwYEg8eCCoag=; b=jtxZsu3F2Tk1mTxi oMNw97eaE/vrDH8NcCDU50t4Pb8G0YoP3x8zrZMo0V0dtCKXoSr3hONTSZGdpX7m V5vzF8EiaXLGyxKQ9R35miShkCgaXNtPughd47ipi/0QDTA9cwoQ9dIG48glYznc /9jEUpdkNEfOEaxj8lrZH8xAcXWracv6NEjEGg1Z6QStAB6GBe/8HHvd5V/LMFv+ 4/q+UxyBQw/oYTpaQ7TRj/5BXumF15BUFyGOvm2xeNrN5CXphe7r1J9iigERqz28 CgIEH7UQQF/OYoEIC0Jv8XLoPyCaQBklPSQCyrv6XfJP1O26oksPYvjRdAnvPOz3 wx+bfQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9fb6m6r3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 11:11:00 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-366344513a3so12794164a91.3 for ; Thu, 21 May 2026 04:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779361859; x=1779966659; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SpkIdCGDZCRqXLE6O2n4Iu9e0V/TmezNwYEg8eCCoag=; b=ZPmc5wZL35nR5AjBTFVIWUtdDTTYOkVDswziPbFFr7eIFMQtXJB6lEnpqrsmB+Dmbo ReJHnxaUNm0NG+nyNnpD3htSWWtsxRPekB+b3+F28GRDEKO+ZWEWHOfsY9Y8FbtqGfSI slCJYNquPFapHM2XUo7eIYCU/03wxshlUyZkHmfUmAEpliE+5xdW6KiWl/ia0pj9R1Kr kzcFLmfiuFh750jB2JL3xTvFKQhQbvdlqGHEpvHnU+DJDOGiF5K9InoaY2dm4N1WB1U5 0sj/RK/xvnnN09fDhO2syX12p17s972DYNV+wIazhuQaBKo3mBgXs5Us9jCvVjoUyAA0 yL2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779361859; x=1779966659; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SpkIdCGDZCRqXLE6O2n4Iu9e0V/TmezNwYEg8eCCoag=; b=q1Z7VEKViyr+39Vdw0di6rRihNcmTmigwMGOEpvgQgRBnYL4waDWauGFrcwTs9QDuy 5hmI+/EHUYf6Pp5F2VTS3a4eAO5jc5HGooZ1xENcQ/KZuTm18nET3mdbG9cTWQ1azqRm ottfTb70NyyFeY876cGwNnGpNJN5P196mvedqiuHB1icmUs0rKQDQJt84UQJkjnhROVh LRoBCp/s+4D66L7cwvxe4CxzAdvKnpqHBGBYnh71Pg6JkYMTGmV9i+kn3Ps1AVWx2eb9 QLbKB2t7GdH8iZPl6EAsrfbkV1LbwE/7jbTYIBjLJkcY1khOTOck1TtDrEitVqifBe8M uR8g== X-Forwarded-Encrypted: i=1; AFNElJ91htr9EYV6HF3k10yMO+kWfzhOTzU37kvd2GCldwkU9xqSQI8NOBhzmPii30yMdfoKc+XRrazCLIZi1pc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+SkZZCa51rb1qCFgXH6ifVmEghOf9TTc+8b/pn7JZLa+Ithe7 rVdx5KR1s+XERE6L+sSSY47SS3FJgJJoh5ErTyuQbGKzSolQjVWAmu+mOEg+QDDH8qpvPK1faTz MsQxGphyoUm5+ZYGWAdWds8IGKomX793UHrI65cWQfFINzLCpfSc2MWjj7gvw81msaoOTZdjYw2 w= X-Gm-Gg: Acq92OESyoIunwxSKk3vIp1XLxy/3q9wDlTCDLizExTPSL9HB47thXMk8nmMMtdob30 cWzxzx2KvGZDo6LYuigA22WEyh5mCHTzfNR4l0Zsj8Bgm23TFVACu6/BPSqmsXHS6vaSpjUwBW8 AVo+T3MdwK3lYbSWQXAqe2PR5Oxo/evvxZLmQkCSV9Q2reFx0j9LqkVA6Ap77NqhRUJpNwwf/qm Gt4UDWrsWO22cRM2GL0OnhRJaTajK7W9gRVgJksWnfo752rNPVRb11safr43VY483sGxo6+w8c2 s+Wx60mkK4PpEQtsuyRx2AfkVPUXmIM1Ps4XpsgTvZpnbufnaYsXheQgAXii29DUiviN2feO8WQ IE+D2K68nm+yYm9n6WEjzRTXiSVlimJBXe+s4V6Z5fn9kNNxj X-Received: by 2002:a17:90b:4d90:b0:368:ac47:6e65 with SMTP id 98e67ed59e1d1-36a4518223fmr2405387a91.11.1779361859498; Thu, 21 May 2026 04:10:59 -0700 (PDT) X-Received: by 2002:a17:90b:4d90:b0:368:ac47:6e65 with SMTP id 98e67ed59e1d1-36a4518223fmr2405357a91.11.1779361859072; Thu, 21 May 2026 04:10:59 -0700 (PDT) Received: from [10.219.57.29] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a5b3490desm385315a91.13.2026.05.21.04.10.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 04:10:58 -0700 (PDT) Message-ID: Date: Thu, 21 May 2026 16:40:54 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom,shikra-pas: Document Shikra PAS remoteprocs To: Krzysztof Kozlowski Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bibek Kumar Patro References: <20260520-shikra-rproc-v2-0-583a2e413a3a@oss.qualcomm.com> <20260520-shikra-rproc-v2-1-583a2e413a3a@oss.qualcomm.com> <20260521-hopeful-eccentric-pig-7fbcde@quoll> Content-Language: en-US From: Komal Bajaj In-Reply-To: <20260521-hopeful-eccentric-pig-7fbcde@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=do/rzVg4 c=1 sm=1 tr=0 ts=6a0ee844 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=83-R8UJ7J38mYFGXg2wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: plvEKSo5_yJgVxnYxYJqNPzwNxXrOv0m X-Proofpoint-GUID: plvEKSo5_yJgVxnYxYJqNPzwNxXrOv0m X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDExMSBTYWx0ZWRfX/gEgYq6ldiV0 AKdKZAqm0yQnDQtcEUO2wXQXDtLmc3voOmfEiyowcryTEj2oMHjDJgmMXVw2GHQ75sLFW3ILIOk j6QwartzXlhXk+uDSCbuQNAF2Lzu9MyWY4TxXZrZtXnDU2roTjS7fXjuvZH/6MX+JGypjVUh7sC CEUAhfYf06EMLKo88Bl0fhIVPF5tVcC1zcl1q1vgWjs1mLo7A7Bp8qixrMqtA0xTUzAb7/5ULiL FkC+Jd6dL+wLcc7rSd1HhrXfRJH16+TKtqpxaeYJDHB2pb28bFXbFkqWmuJyJ8kNMEmsGfJ0EF/ 8npa87kNlNSmI6IVcItwNKRqMPHmOE/hL58glqPePBuQKOUI2iKOmZZIezo64c9qxmVjHCimhFt mKQGFYxJCGzSicec0nbU+/8CPn3YhHVGAKlJcJztM8JI8SwPUtxHrxakHtoCbPKF2gJxz/kh/Uh Eh42smvuR40p0QrHCqg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210111 On 5/21/2026 1:30 PM, Krzysztof Kozlowski wrote: > On Wed, May 20, 2026 at 08:08:05PM +0530, Komal Bajaj wrote: >> + glink-edge: >> + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# >> + description: >> + Qualcomm G-Link subnode which represents communication edge, channels >> + and devices related to the remoteproc core. >> + unevaluatedProperties: false >> + >> + qcom,smem-states: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: States used by the AP to signal the Hexagon core >> + items: >> + - description: Stop the remote processor > You again got the warning here. It must be solved, don't send the same. > > See thread: > https://lore.kernel.org/all/20260421195836.1547469-1-robh@kernel.org/ I ran make dt_binding_check and didn’t see this warning, likely because my dt-schema was not up to date. I’ll fix this in the next version. > > >> + >> + qcom,smem-state-names: >> + description: The names of the state bits used for SMP2P output >> + items: >> + - const: stop >> + >> +required: >> + - compatible >> + - reg >> + - memory-region >> + >> +allOf: >> + - $ref: /schemas/remoteproc/qcom,pas-common.yaml# >> + >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,shikra-cdsp-pas >> + - qcom,shikra-mpss-pas >> + then: >> + properties: >> + interrupts: >> + minItems: 6 >> + interrupt-names: >> + minItems: 6 >> + memory-region: >> + maxItems: 1 >> + firmware-name: >> + maxItems: 1 >> + power-domains: >> + items: >> + - description: CX power domain >> + power-domain-names: >> + items: >> + - const: cx >> + >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,shikra-lpaicp-pas >> + then: >> + properties: >> + interrupts: >> + maxItems: 5 >> + interrupt-names: >> + maxItems: 5 >> + memory-region: >> + minItems: 2 >> + firmware-name: >> + minItems: 2 > power-domains: false > power-domain-names: false Ack, will add in next series. > >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + #include >> + #include >> + #include >> + #include >> + #include >> + >> + remoteproc@b300000 { >> + compatible = "qcom,shikra-cdsp-pas"; >> + reg = <0x0b300000 0x100000>; >> + >> + interrupts-extended = <&intc GIC_SPI 265 IRQ_TYPE_EDGE_RISING>, >> + <&cdsp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, >> + <&cdsp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, >> + <&cdsp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, >> + <&cdsp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>, >> + <&cdsp_smp2p_in 7 IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "wdog", "fatal", "ready", >> + "handover", "stop-ack", "shutdown-ack"; >> + >> + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>; >> + clock-names = "xo"; >> + >> + interconnects = <&mem_noc MASTER_AMPSS_M0 RPM_ALWAYS_TAG >> + &mc_virt SLAVE_EBI_CH0 RPM_ALWAYS_TAG>; >> + >> + power-domains = <&rpmpd RPMHPD_CX>; >> + power-domain-names = "cx"; >> + >> + memory-region = <&cdsp_mem>; >> + >> + qcom,smem-states = <&cdsp_smp2p_out 0>; >> + qcom,smem-state-names = "stop"; > Missing firmware-name ACK, will add in next series. Thanks Komal > >> + >> + glink-edge { >> + interrupts = ; >> + mboxes = <&apcs_glb 4>; >> + qcom,remote-pid = <5>; >> + label = "cdsp"; >> + }; >> + }; >> >> -- >> 2.34.1 >>