From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC56B190462 for ; Sat, 24 Jan 2026 08:18:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769242733; cv=none; b=NXTvRSAkqdNS4uhKQ8Xa4ZDqYCxxH+910qt8B6clDH6w5W7qjMO3qtq+7+uiWIJdA4BdUkEOnsHl1JIy8ewNdyxQ822mpm9o9dXEKPgwYO4mKCRNx5oZc8cQ2/mQNTvAwkk+cg2QUiFx4D2ZTw1gNCPTnP5QbYtoIdxiVmS7SvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769242733; c=relaxed/simple; bh=OVAeomsh6Mj11icHu9KqyNRZ2jyJuFcGOWKABatdc74=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=rq6GkiS4apYzNPYcBcEBKfets8KjLWJBxDIr7N/Wuz8rmpBwy7ZhK8hL7+YIVpzbIt8Ztz9SQhis4fc/bXssW8D/S86UF079xfRvjiX9gYCocxCyEoTOrMGoplYXnQb3wtftiXHgWs0s0CRgvk9esI2On2zeWkcOhaldt5qqjrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cJCNC3wM; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cJCNC3wM" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a7786d7895so19506795ad.1 for ; Sat, 24 Jan 2026 00:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769242731; x=1769847531; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=rMKou0lTGiCd2raLCB3aWAc1kprvOo5pfAG7zCR/gfQ=; b=cJCNC3wMIdSCUP3A+WXQel43PbHp4gdbtNfDzydUmwOTnxSSvBbbrh3DHalVMio/qe 4xQbrep03hIWESh8L4DkhJRDOET+aAjL5YNBDHPdEBqbqkEs61ZDIG8GSuGAi3Lq6roH 5jeJSKg5AnZql8mp5vgTS97V8Q2fHUvLMxZgSIEwbuj9awcwoyzbCK2c6Ul7uJ5ZU7jM bhAG1XhoPhICRqEc9XBMfPkwImlNdqvDzX51y6jKYCLkScLdbz9ciRBI+GAXuz3twbWh 1VkobbCVkfsTqdTSZl/2rV8rfrvyr+CLliVzWAPpb4kUXx98sXUdXReMm8m6fevTwn9P U9WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769242731; x=1769847531; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rMKou0lTGiCd2raLCB3aWAc1kprvOo5pfAG7zCR/gfQ=; b=ZLPp6LZ+ZA9ogOZuTs/1pjiOMxWJrufo4CAdICRIbFVANEG8xGOjEhtYBkiY589BrX bfFFUIe0o0Kk3B3XifHV6H9+k+0cD67kOLWii4neVrRm7XJHpnrR++pZ7zQfqs7TYaJh 4UZ++bSZ1wxpUMmZZHYNPfIQ83XglV6np5GB0EYrQgEomv0ofjhs059vjMwY0uh7cQfJ jpjgxqLryj38J+HX3hIGhZv7OFC+cEBZb7zPPuHyNA2HXW2LaUmQHXyfSe8mPgZ/O1jB NWFVT2BtiQA216fZJvQkj9sYhr+zqiP0672Hd+bin31cYXCZH5c1014fsf+HNmUZ/oU0 PrPA== X-Forwarded-Encrypted: i=1; AJvYcCUf0DUjBmnPV+Ibl98dT1oc7niM1FaxHWVDsS1hApuYGLZOOhR7JDOVGuT1gJoeP9Hda0q5GGGSwDW9K9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwBs3ZYq037oM2Q4UkH1OTBDAmhkAlIqtFlAIlaFEjUYh1u47E0 eJu8MRTaFliGlEoSrh+oH5O7QtB1HqKGAj8o0wC2BNdP6xHWEFG0LS2w89s4EDCyydA= X-Gm-Gg: AZuq6aICX9m2MNrBWLJq+Xg6QRDd6n2WDBZKZ44NBFC92b+5QTy0mw7ECxVLQ+yVIuy dHLTOLyjNuUj9Z0yeMYz3/8QPp2Kad87I58Zwuoiu4lWkIzdem+5MPTINwIhvvn/l7imv0Z4Qgv ztKPlxhQICPRavfKZdA6oQKS+6zykcmgQKe37PG63BtonkXdFj9kooL6lbVrBlcJ5qQIiq/gwqi 31BQ4OWMKQUEREAipJZRe/d3cWdu95xXarG5Rnf/4zFNIEQiPcNsxCThHTSuADEhF1qRjoEqNXr OehMAqir+twPoPvdS344h9ANXvJOoDTflz6tbfaNLaH+amx70shCLtGYJz9kTGyBBJIIdj2HEz+ Cm/xLq6cG2HPlY+LO4VdLs2TitoSwUJYNT/KY40SvOZoHLboocUSEdbFFhlgizddgjnxXpzaXub bPadjw8vj8AYlLA9WFS1FeajK2jTPxdQ4mY8+Zun/ZPYtkLKgscNjcYkURRysCrQ== X-Received: by 2002:a17:902:f652:b0:2a7:a22c:90f7 with SMTP id d9443c01a7336-2a7fe756185mr49731635ad.51.1769242731079; Sat, 24 Jan 2026 00:18:51 -0800 (PST) Received: from ?IPV6:240e:390:a84:ae11:f96c:3476:2936:720f? ([240e:390:a84:ae11:f96c:3476:2936:720f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802fdd715sm38380625ad.102.2026.01.24.00.18.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Jan 2026 00:18:50 -0800 (PST) Message-ID: Date: Sat, 24 Jan 2026 16:18:47 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ext4: remove unused i_fc_wait To: Li Chen , Theodore Ts'o , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260120121941.144192-1-me@linux.beauty> Content-Language: en-US From: Zhang Yi In-Reply-To: <20260120121941.144192-1-me@linux.beauty> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/20/2026 8:19 PM, Li Chen wrote: > i_fc_wait is only initialized in ext4_fc_init_inode() and never used for > waiting or wakeups. Drop it. > > Signed-off-by: Li Chen Thank you for the cleanup, it looks good to me. Reviewed-by: Zhang Yi > --- > fs/ext4/ext4.h | 4 ---- > fs/ext4/fast_commit.c | 2 +- > 2 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h > index 56112f201cac..dc3a5a926eff 100644 > --- a/fs/ext4/ext4.h > +++ b/fs/ext4/ext4.h > @@ -28,7 +28,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -1091,9 +1090,6 @@ struct ext4_inode_info { > > spinlock_t i_raw_lock; /* protects updates to the raw inode */ > > - /* Fast commit wait queue for this inode */ > - wait_queue_head_t i_fc_wait; > - > /* > * Protect concurrent accesses on i_fc_lblk_start, i_fc_lblk_len > * and inode's EXT4_FC_STATE_COMMITTING state bit. > diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c > index fa66b08de999..86789989b3f4 100644 > --- a/fs/ext4/fast_commit.c > +++ b/fs/ext4/fast_commit.c > @@ -13,6 +13,7 @@ > #include "mballoc.h" > > #include > +#include > /* > * Ext4 Fast Commits > * ----------------- > @@ -215,7 +216,6 @@ void ext4_fc_init_inode(struct inode *inode) > ext4_clear_inode_state(inode, EXT4_STATE_FC_COMMITTING); > INIT_LIST_HEAD(&ei->i_fc_list); > INIT_LIST_HEAD(&ei->i_fc_dilist); > - init_waitqueue_head(&ei->i_fc_wait); > } > > static bool ext4_fc_disabled(struct super_block *sb)