From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938673AbcJXJGD (ORCPT ); Mon, 24 Oct 2016 05:06:03 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33442 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934778AbcJXJGA (ORCPT ); Mon, 24 Oct 2016 05:06:00 -0400 Subject: Re: [PATCH -resend] Input: i8042, lower log level when controller_init fails To: dmitry.torokhov@gmail.com References: <20161003085652.15810-1-jslaby@suse.cz> Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org From: Jiri Slaby Message-ID: Date: Mon, 24 Oct 2016 11:05:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161003085652.15810-1-jslaby@suse.cz> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Any updates on this? On 10/03/2016, 10:56 AM, Jiri Slaby wrote: > There are a lot of machines without i8042 controller nowadays. > Sometimes i8042_controller_check returns 0 because i8042_flush does > nothing (read from the port returns 0 and the while loop does not > execute). > > In that case, the probe method is called and fails with this error > output to console: > i8042: Can't read CTR while initializing i8042 > i8042: probe of i8042 failed with error -5 > > Lower the former error message to be KERN_INFO and make the function > in that case return -ENODEV instead of -EIO. This will suppress the > latter. > > There is also an IBM support page about these messages: > https://www-947.ibm.com/support/entry/portal/docdisplay?lndocid=migr-5082417 > > Signed-off-by: Jiri Slaby > --- > drivers/input/serio/i8042.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c > index 405252a884dd..15c87b98d70b 100644 > --- a/drivers/input/serio/i8042.c > +++ b/drivers/input/serio/i8042.c > @@ -950,8 +950,8 @@ static int i8042_controller_init(void) > udelay(50); > > if (i8042_command(&ctr[n++ % 2], I8042_CMD_CTL_RCTR)) { > - pr_err("Can't read CTR while initializing i8042\n"); > - return -EIO; > + pr_info("Can't read CTR while initializing i8042. Either i8042 controller is not present or it does not respond.\n"); > + return -ENODEV; > } > > } while (n < 2 || ctr[0] != ctr[1]); > -- js suse labs