From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932493AbdJXJqa (ORCPT ); Tue, 24 Oct 2017 05:46:30 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:8982 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932173AbdJXJq0 (ORCPT ); Tue, 24 Oct 2017 05:46:26 -0400 Subject: Re: [PATCH 1/2] f2fs: add missing quota_initialize in f2fs_set_acl To: Jaegeuk Kim , , , References: <20171023221409.59148-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Tue, 24 Oct 2017 17:46:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171023221409.59148-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A010204.59EF0BED.0007,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 72d5ee8c3020f1b2f7d014661870821c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/10/24 6:14, Jaegeuk Kim wrote: > This patch adds to call quota_intialize in f2fs_set_acl. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/acl.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c > index 436b3a1464d9..f6471f9d707e 100644 > --- a/fs/f2fs/acl.c > +++ b/fs/f2fs/acl.c > @@ -209,6 +209,10 @@ static int __f2fs_set_acl(struct inode *inode, int type, > int error; > umode_t mode = inode->i_mode; > > + error = dquot_initialize(inode); > + if (error) > + return error; Could you move this to f2fs_setxattr, and also add missing dquot_initialize in unlink and rename like ext4? Thanks, > + > switch (type) { > case ACL_TYPE_ACCESS: > name_index = F2FS_XATTR_INDEX_POSIX_ACL_ACCESS; >