From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A747941D10F for ; Mon, 27 Jul 2026 15:59:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785167952; cv=none; b=TJauWXuNCWIlf2uFc1ApPG19AqlMhpZ69W3mLl/q04syi45XWJUsNUN6U5h8xAnUc7K4moS4d+A6Ezq/lbpVrvvGUYDFTPlOz0GwTZ+ZR6sZVNAUXqrCL7Us3iPzWQW+lSKsalgs/SSsMDB1qz9Ywy38y5sr7SVs5iF1+1agl08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785167952; c=relaxed/simple; bh=RPvzmBUvGUDgoK8qi8BU9CzoCvJCoYIwfvAGLDgTQwY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N5+dpSuTkq4YsUyYCV/v60OeCI1gjdDtoww2Wd2+y5c45yCVGE1I95oRMDMopA+Gl+rydeV6A240MMX6RZkT4feG3iLL9QlBmtp8OvxzJ7FzF2R2ViFemF31OmuqisCe3aGjfuagWQgmqVyGtmEpzqEKRAdRLpNBoA59eWePfEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=Y/amVQbb; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="Y/amVQbb" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-527e352a167so20847221cf.1 for ; Mon, 27 Jul 2026 08:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1785167949; x=1785772749; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eI+pv0AMxILlggFrEFkkHRcxF3WFLsvXTsHBUr1TQj8=; b=Y/amVQbbNCfBvpHYl6W41jy5EdjHPzeJi4ZGcvPOO/A1IeVUTDO/I3VXabpZa9cvje QlI3AjYqFqzkbJwlbVMxqdpBxaNytlk09yjUXNhHQOWjj/gSAC3zARfGqbkfbRWQvLwV 9xZcRzK7PUNM8JB7egV1zKeobPziGi0IEiG+gv/M69zlz8XszhkGQM+n6fxagKmrtfy/ ULKXXXTPEprWvpQ65NtzGqxREe3BplkhnlxOtJAdN79NOrO3O1chE6SJUKvAtuUBJxU8 9+etck6V1UZilQoFC0WM94OIxKPxnFVbX0Zo5BMyffiVKBVH5obHm44JgMVyCcB94ubr nGiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785167949; x=1785772749; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eI+pv0AMxILlggFrEFkkHRcxF3WFLsvXTsHBUr1TQj8=; b=eENRqrcZLBFAlXgKRMFNJZb7Ex+6n0g57wIOisWo0N6rGfi6BJA/xUZECl0gxQLJ6S +PubpZp9E/VZlNfElyVUMQ27HrE8Vnoaa+SLnDvdiFo0ORR+YCCy3GFuQd2PJ6Sdh7iU qYwQPrQ7772SLSBP8BwYVcIQnH4BqijXeFY0i16yf3OB4ypBygQtqjb11ioOo1KFh8w7 PU/oMtl44+CZNAI2iyv0KYNYiD2bpzoIXh1A0VYc+3TO/iOEQ0kb3wZH+hVIt7vLPV0r 6P8PsQaq0PB5Sr//cVHkjLerMDv6f1YkFQmMz2MU8S1YHl+LrdZYGN0RN3IhhdEd+PwX rdzA== X-Forwarded-Encrypted: i=1; AHgh+RrCpKUQTTxeARVuT9qRTzD+zFgXySwRv/wMVVAYClkpQfY2ZqnwAEsn1lIVi0GBWl6+DpYhd6JiYbaVgOI=@vger.kernel.org X-Gm-Message-State: AOJu0YzDHlLjNORE5aixNhWEKajU1zZyjyX66t7/Rx25rR8DKH+0bkNo Xo35QSDC/UfFweWpxQUmYWGXb1PZMmELi04o8/yRmsCJGYV9+ipWw4IRRw5KZMMLKBc= X-Gm-Gg: AR+sD11LVoLzOijv65dxFzpxhtDsUwhxY83RdGGBS2GQV3zc17CFPf3BaZkmuMp3nVi 6pzh9afMQaLIEQ+pOGg+FVNSTTJtUwP0JgQpHxRVWoOfG8Z1c+x8i/KpI8cBR3Oi3VMCPUn/Cwh Ms0FmDd47H+OP5UUdWx+7BOEgrpxM/SAiBB+UZXubNHEU1B8M+oyYqqMbuK70I62nJroSp82Tke O/fDIYXJw3rlADRMtIfyfZW7HaxNQE5oCeWrvdjuprOSpltv2mkUuD1owN8u3qr2prpRgVf6pCu CpzK2VVNKyXWLPRzyBLg0KsH79McxtIz5uG1Ws/qTEGhB6F/VPF6PtXfj5g+6lz5iv2Vzl6fwLE y+AYziKs6CMqr1aki0VXAp/MOPbCts2/HP3sHKTFCifsdTxKJpllgtVvWiLWPpkYWa2438bvGdS 7RwA== X-Received: by 2002:a05:622a:559a:b0:528:3ae6:14b1 with SMTP id d75a77b69052e-529d1c4c98fmr673601cf.43.1785167949589; Mon, 27 Jul 2026 08:59:09 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-529a262fa9dsm56944561cf.0.2026.07.27.08.59.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jul 2026 08:59:09 -0700 (PDT) Message-ID: Date: Mon, 27 Jul 2026 10:59:08 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] PCI/pwrctrl: tc9563: Power off only the external ports in tc9563_pwrctrl_disable_port() To: manivannan.sadhasivam@oss.qualcomm.com, Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Chaitanya Chundru , Bartosz Golaszewski , Bjorn Andersson Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260725-tc9563-fix-v1-0-ec4286e31331@oss.qualcomm.com> <20260725-tc9563-fix-v1-3-ec4286e31331@oss.qualcomm.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20260725-tc9563-fix-v1-3-ec4286e31331@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/25/26 3:59 AM, Manivannan Sadhasivam via B4 Relay wrote: > From: Manivannan Sadhasivam > > TC9563 supports powering off only the external facing ports like DSP1 and > DSP2. It is not recommended to power off USP and DSP3 as they have fixed > ports/endpoint connected. > > Hence, fix tc9563_pwrctrl_disable_port() to power off only DSP1 and DSP2. > > Fixes: 4c9c7be47310 ("PCI: pwrctrl: Add power control driver for TC9563") > Signed-off-by: Manivannan Sadhasivam This is very nice and makes that function a little less confusing... Reviewed-by: Alex Elder > --- > drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > index 482e82e433dd..ca19bf60d290 100644 > --- a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > +++ b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > @@ -241,12 +241,18 @@ static int tc9563_pwrctrl_disable_port(struct tc9563_pwrctrl *tc9563, > if (!cfg->disable_port) > return 0; > > - if (port == TC9563_DSP1) { > + switch (port) { > + case TC9563_DSP1: > seq = dsp1_pwroff_seq; > len = ARRAY_SIZE(dsp1_pwroff_seq); > - } else { > + break; > + case TC9563_DSP2: > seq = dsp2_pwroff_seq; > len = ARRAY_SIZE(dsp2_pwroff_seq); > + break; > + default: > + /* Only external downstream ports DSP1/DSP2 can be powered off */ > + return 0; > } > > ret = tc9563_pwrctrl_i2c_bulk_write(tc9563->client, seq, len); >