From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Guenter Roeck <groeck@google.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Collabora Kernel ML <kernel@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Benson Leung <bleung@chromium.org>,
Dmitry Torokhov <dtor@chromium.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_lpc: Use platform_get_irq_optional() for optional IRQs
Date: Sat, 14 Dec 2019 12:53:11 +0100 [thread overview]
Message-ID: <f2139eca-6561-a353-576f-cf6c53e5441f@collabora.com> (raw)
In-Reply-To: <CABXOdTd8b+Lshh_Kf2fjeErrAyQcgZVgLNx3_cpW42Dh8YCN=Q@mail.gmail.com>
Hi,
On 29/11/19 16:56, Guenter Roeck wrote:
> On Fri, Nov 29, 2019 at 2:23 AM Enric Balletbo i Serra
> <enric.balletbo@collabora.com> wrote:
>>
>> As platform_get_irq() now prints an error when the interrupt does not
>> exist, use platform_get_irq_optional() to get the IRQ which is optional
>> to avoid below error message during probe:
>>
>> [ 5.113502] cros_ec_lpcs GOOG0004:00: IRQ index 0 not found
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
> Reviewed-by: Guenter Roeck <groeck@chromium.org>
>
Queued for 5.6.
>> ---
>>
>> drivers/platform/chrome/cros_ec_lpc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
>> index dccf479c6625..ffdea7c347f2 100644
>> --- a/drivers/platform/chrome/cros_ec_lpc.c
>> +++ b/drivers/platform/chrome/cros_ec_lpc.c
>> @@ -396,7 +396,7 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
>> * Some boards do not have an IRQ allotted for cros_ec_lpc,
>> * which makes ENXIO an expected (and safe) scenario.
>> */
>> - irq = platform_get_irq(pdev, 0);
>> + irq = platform_get_irq_optional(pdev, 0);
>> if (irq > 0)
>> ec_dev->irq = irq;
>> else if (irq != -ENXIO) {
>> --
>> 2.20.1
>>
>
prev parent reply other threads:[~2019-12-14 11:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 10:22 Enric Balletbo i Serra
2019-11-29 15:56 ` Guenter Roeck
2019-12-14 11:53 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2139eca-6561-a353-576f-cf6c53e5441f@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=dtor@chromium.org \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®