From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA0D6C433EF for ; Tue, 29 Mar 2022 14:34:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237937AbiC2Ofx (ORCPT ); Tue, 29 Mar 2022 10:35:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238016AbiC2Oef (ORCPT ); Tue, 29 Mar 2022 10:34:35 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7BF1B1EAEA for ; Tue, 29 Mar 2022 07:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648564371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=17L5Bd/rDDofYieluRLge+dXOsZZApI0UCMAz+pSmTw=; b=FBNXKpWsdWSR5ZRoyplyOeh4xcoyqVlYn3yRaXsZq5f852a4JntU/mpzsXdzB0spQsrcJ7 +ht4FXWpp3FUQVH+f12DA1LJb80eHpq3kKG/B2QwRALtduyD4TfKXC5Qxgjdk4eB+DZ8nd 4RW5u5+YOYzsGgNIwroouG1ZBqN4j30= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-230-VLDTil8mPQO9rbrPH-_BlA-1; Tue, 29 Mar 2022 10:32:47 -0400 X-MC-Unique: VLDTil8mPQO9rbrPH-_BlA-1 Received: by mail-ej1-f72.google.com with SMTP id hg13-20020a1709072ccd00b006dfa484ec23so8321140ejc.8 for ; Tue, 29 Mar 2022 07:32:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=17L5Bd/rDDofYieluRLge+dXOsZZApI0UCMAz+pSmTw=; b=5hvEm2ZdaOo9dfbOsZ4n08qAJSZ8HHhroYY6+c77avu6dxXgoQrMBWBzX2eVp52Tx8 DA/D0ULSR+Ak5WMzl+fIZn2By1eCCgpfQeaQRwQTa6ls/ceFX7mmJwhWo71iplyh7h7p pk+ozcZSFTD1klssUh769XsxrMTDhR5kIAH9bNi1qzT+cA+LuD2kYm62ukap/7swgJS7 9hgdUKiDzeH9Au43SMe3IdIwy1sxqdbzWzAL/uKnYafNNaEhvDf5On4LsFIyFeH1vKV3 oLnUIBMIuWZwUsW/SZ7IP+3Ny1xcttWFlJouKVf42UMAUcZGw+lWiYkxwb/wQEEDbPEp H0zw== X-Gm-Message-State: AOAM532iVfOvWHYzYxYr6xFKFpjV6sqoAgij4LnGMnFv2Z8/NUZnC6PS CydzTj/SjtxIzm1858L4I2+E7oO644oZ7dbyfMhfMBOHp/fhT9Yuns7kHJe01+4V6WtRWeqErxy GW6XYGdqZX3eNZO9ponCVV+oB X-Received: by 2002:a17:906:314b:b0:6d6:da31:e545 with SMTP id e11-20020a170906314b00b006d6da31e545mr35919217eje.125.1648564366237; Tue, 29 Mar 2022 07:32:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqmFlzJiy10RwfiaOb7PhShtC3JPpZmRPKPNWnjU6XgSCS7W3KvBhdb1sU23nSprs49sRYTg== X-Received: by 2002:a17:906:314b:b0:6d6:da31:e545 with SMTP id e11-20020a170906314b00b006d6da31e545mr35919193eje.125.1648564366024; Tue, 29 Mar 2022 07:32:46 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id b8-20020a056402350800b00419407f0dd9sm8497927edd.0.2022.03.29.07.32.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Mar 2022 07:32:45 -0700 (PDT) Message-ID: Date: Tue, 29 Mar 2022 16:32:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4 4/4] input/i8042: Add TUXEDO devices to i8042 quirk tables Content-Language: en-US To: Werner Sembach , dmitry.torokhov@gmail.com, tiwai@suse.de, mpdesouza@suse.com, arnd@arndb.de, samuel@cavoj.net, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220329142718.30921-2-wse@tuxedocomputers.com> <20220329142718.30921-4-wse@tuxedocomputers.com> From: Hans de Goede In-Reply-To: <20220329142718.30921-4-wse@tuxedocomputers.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 3/29/22 16:27, Werner Sembach wrote: > A lot of modern Clevo barebones have touchpad and/or keyboard issues after > suspend fixable with nomux + reset + noloop + nopnp. Luckily, none of them > have an external PS/2 port so this can safely be set for all of them. > > I'm not entirely sure if every device listed really needs all four quirks, > but after testing and production use. No negative effects could be > observed when setting all four. > > The list is quite massive as neither the TUXEDO nor the Clevo dmi strings > have been very consistent historically. I tried to keep the list as short > as possible without risking on missing an affected device. > > This is revision 3. The Clevo N150CU barebone is still removed as it might > have problems with the fix and needs further investigations. The > SchenkerTechnologiesGmbH System-/Board-Vendor string variations are > added. This is now based in the quirk table refactor. This now also > includes the additional noaux flag for the NS7xMU. > > Signed-off-by: Werner Sembach Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/input/serio/i8042-x86ia64io.h | 125 ++++++++++++++++++++++++++ > 1 file changed, 125 insertions(+) > > diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h > index 5c0eb5594fb1..a59c6aba7c75 100644 > --- a/drivers/input/serio/i8042-x86ia64io.h > +++ b/drivers/input/serio/i8042-x86ia64io.h > @@ -1025,6 +1025,25 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = { > }, > .driver_data = (void *)(SERIO_QUIRK_NOMUX) > }, > + /* > + * A lot of modern Clevo barebones have touchpad and/or keyboard issues > + * after suspend fixable with nomux + reset + noloop + nopnp. Luckily, > + * none of them have an external PS/2 port so this can savely be set for > + * all of them. These two are based on a Clevo design, but have the > + * board_name changed. > + */ > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "TUXEDO"), > + DMI_MATCH(DMI_BOARD_NAME, "AURA1501"), > + }, > + }, > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "TUXEDO"), > + DMI_MATCH(DMI_BOARD_NAME, "EDUBOOK1502"), > + }, > + }, > { > /* Mivvy M310 */ > .matches = { > @@ -1054,6 +1073,112 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = { > }, > .driver_data = (void *)(SERIO_QUIRK_NOLOOP) > }, > + /* > + * A lot of modern Clevo barebones have touchpad and/or keyboard issues > + * after suspend fixable with nomux + reset + noloop + nopnp. Luckily, > + * none of them have an external PS/2 port so this can savely be set for > + * all of them. > + * Clevo barebones come with board_vendor and/or system_vendor set to > + * either the very generic string "Notebook" and/or a different value > + * for each individual reseller. The only somewhat universal way to > + * identify them is by board_name. > + */ > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_NAME, "LAPQC71A"), > + }, > + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | > + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) > + }, > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_NAME, "LAPQC71B"), > + }, > + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | > + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) > + }, > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_NAME, "N140CU"), > + }, > + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | > + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) > + }, > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_NAME, "N141CU"), > + }, > + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | > + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) > + }, > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_NAME, "NH5xAx"), > + }, > + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | > + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) > + }, > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), > + }, > + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | > + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) > + }, > + /* > + * At least one modern Clevo barebone has the touchpad connected both > + * via PS/2 and i2c interface. This causes a race condition between the > + * psmouse and i2c-hid driver. Since the full capability of the touchpad > + * is available via the i2c interface and the device has no external > + * PS/2 port, it is save to just ignore all ps2 mouses here to avoid > + * this issue. The know affected device is the > + * TUXEDO InfinityBook S17 Gen6 / Clevo NS70MU which comes with one of > + * the two different dmi strings below. NS50MU is not a typo! > + */ > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_NAME, "NS50MU"), > + }, > + .driver_data = (void *)(SERIO_QUIRK_NOAUX | SERIO_QUIRK_NOMUX | > + SERIO_QUIRK_RESET_ALWAYS | SERIO_QUIRK_NOLOOP | > + SERIO_QUIRK_NOPNP) > + }, > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_NAME, "NS50_70MU"), > + }, > + .driver_data = (void *)(SERIO_QUIRK_NOAUX | SERIO_QUIRK_NOMUX | > + SERIO_QUIRK_RESET_ALWAYS | SERIO_QUIRK_NOLOOP | > + SERIO_QUIRK_NOPNP) > + }, > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_NAME, "NJ50_70CU"), > + }, > + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | > + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) > + }, > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_NAME, "PB50_70DFx,DDx"), > + }, > + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | > + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) > + }, > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_NAME, "X170SM"), > + }, > + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | > + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) > + }, > + { > + .matches = { > + DMI_MATCH(DMI_BOARD_NAME, "X170KM-G"), > + }, > + .driver_data = (void *)(SERIO_QUIRK_NOMUX | SERIO_QUIRK_RESET_ALWAYS | > + SERIO_QUIRK_NOLOOP | SERIO_QUIRK_NOPNP) > + }, > { } > }; >