From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CB1EC433ED for ; Tue, 6 Apr 2021 09:29:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7379C613C6 for ; Tue, 6 Apr 2021 09:29:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235506AbhDFJ35 (ORCPT ); Tue, 6 Apr 2021 05:29:57 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:16347 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbhDFJ34 (ORCPT ); Tue, 6 Apr 2021 05:29:56 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FF2HY0s17z9wsQ; Tue, 6 Apr 2021 17:27:37 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.208) with Microsoft SMTP Server (TLS) id 14.3.498.0; Tue, 6 Apr 2021 17:29:46 +0800 Subject: Re: [PATCH v2] f2fs: fix the periodic wakeups of discard thread To: Sahitya Tummala , Jaegeuk Kim , CC: References: <20210316093406.GC8562@codeaurora.org> <1617700156-19719-1-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: Date: Tue, 6 Apr 2021 17:29:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1617700156-19719-1-git-send-email-stummala@codeaurora.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/4/6 17:09, Sahitya Tummala wrote: > Fix the unnecessary periodic wakeups of discard thread that happens under > below two conditions - > > 1. When f2fs is heavily utilized over 80%, the current discard policy > sets the max sleep timeout of discard thread as 50ms > (DEF_MIN_DISCARD_ISSUE_TIME). But this is set even when there are > no pending discard commands to be issued. > > 2. In the issue_discard_thread() path when there are no pending discard > commands, it fails to reset the wait_ms to max timeout value. > > Signed-off-by: Sahitya Tummala Reviewed-by: Chao Yu Thanks,