From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD1D7C388F9 for ; Wed, 11 Nov 2020 15:50:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7109D20709 for ; Wed, 11 Nov 2020 15:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727314AbgKKPus (ORCPT ); Wed, 11 Nov 2020 10:50:48 -0500 Received: from smtprelay0153.hostedemail.com ([216.40.44.153]:39698 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725995AbgKKPus (ORCPT ); Wed, 11 Nov 2020 10:50:48 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 97580100E7B49; Wed, 11 Nov 2020 15:50:46 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: back47_1a07090272fe X-Filterd-Recvd-Size: 2673 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA; Wed, 11 Nov 2020 15:50:45 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2] checkpatch: add fix option for MISSING_SIGN_OFF From: Joe Perches To: Aditya , Lukas Bulwahn Cc: linux-kernel-mentees@lists.linuxfoundation.org, Linux Kernel Mailing List Date: Wed, 11 Nov 2020 07:50:44 -0800 In-Reply-To: <2b640e8b-69dc-2ade-3b9f-fae14eed1b17@gmail.com> References: <20201111090143.9230-1-yashsri421@gmail.com> <2b640e8b-69dc-2ade-3b9f-fae14eed1b17@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-11-11 at 16:39 +0530, Aditya wrote: > On 11/11/20 4:00 pm, Lukas Bulwahn wrote: > > On Wed, Nov 11, 2020 at 10:01 AM Aditya Srivastava wrote: > > > > > > Currently checkpatch warns us if there is no 'Signed-off-by' line > > > for the patch. > > > > > > E.g., running checkpatch on commit 9ac060a708e0 ("leaking_addresses: > > > Completely remove --version flag") reports this error: > > > > > > ERROR: Missing Signed-off-by: line(s) > > > > > > Provide a fix by adding a Signed-off-by line corresponding to the author > > > of the patch before the patch separator line. Also avoid this error for > > > the commits where some typo is present in the sign off. [] > > I think it should still warn about a Missing Signed-off-by: even when > > we know there is a $non_standard_signature. So, checkpatch simply > > emits two warnings; that is okay in that case. > > > > It is just that our evaluation shows that the provided fix option > > should not be suggested when there is a $non_standard_signature > > because we actually would predict that there is typo in the intended > > Signed-off-by tag and the fix that checkpatch would suggest would not > > be adequate. > > > > Joe, what is your opinion? > > > > Aditya, it should not be too difficult to implement the rule that way, right? > > > > No, I'd probably just have to add the check with $fix, instead of with > $signoff I think it does not matter much which is chosen. The bad signed-off-by: line would still need to be corrected one way or another and the added signed-off-line is also possibly incorrect so it could need to be modified or deleted.