From: Le Qi <le.qi@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@oss.qualcomm.com,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: talos-evk: Add sound card support with DA7212 codec
Date: Wed, 8 Apr 2026 17:48:03 +0800 [thread overview]
Message-ID: <f2231896-d065-43ee-901a-7dc35299f264@oss.qualcomm.com> (raw)
In-Reply-To: <78ebca6b-d8e2-4db2-8a34-ebdb6f401a5c@oss.qualcomm.com>
On 4/8/2026 5:42 PM, Le Qi wrote:
> On 3/30/2026 9:53 PM, Bjorn Andersson wrote:
>> On Tue, Mar 24, 2026 at 02:04:05PM +0800, Le Qi wrote:
>>> Add the sound card node for QCS615 Talos EVK with DA7212 codec
>>> connected over the Primary MI2S interface. The configuration enables
>>> headphone playback and headset microphone capture, both of which have
>>> been tested to work.
>>>
>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>> Signed-off-by: Le Qi <le.qi@oss.qualcomm.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/talos-evk.dts | 65 ++++++++++++++++++++++++++
>>
>> There's no such file in the upstream tree. Please test on upstream and
>> resubmit once this is ready to be merged.
>>
>
> Hi Bjorn, this is merged. I will post new patch, thank you.
>
>> Regards,
>> Bjorn
>>
>>> 1 file changed, 65 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/talos-evk.dts b/arch/arm64/
>>> boot/dts/qcom/talos-evk.dts
>>> index af100e22beee..6352d614e288 100644
>>> --- a/arch/arm64/boot/dts/qcom/talos-evk.dts
>>> +++ b/arch/arm64/boot/dts/qcom/talos-evk.dts
>>> @@ -5,6 +5,7 @@
>>> /dts-v1/;
>>> #include "talos-evk-som.dtsi"
>>> +#include <dt-bindings/sound/qcom,q6afe.h>
>>> / {
>>> model = "Qualcomm QCS615 IQ 615 EVK";
>>> @@ -40,6 +41,46 @@ hdmi_con_out: endpoint {
>>> };
>>> };
>>> + sound {
>>> + compatible = "qcom,qcs615-sndcard";
>>> + model = "TALOS-EVK";
>>> +
>>> + pinctrl-0 = <&mi2s1_pins>, <&mi2s_mclk>;
>>> + pinctrl-names = "default";
>>> +
>>> + pri-mi2s-capture-dai-link {
>>> + link-name = "Primary MI2S Capture";
>>> +
>>> + codec {
>>> + sound-dai = <&codec_da7212>;
>>> + };
>>> +
>>> + cpu {
>>> + sound-dai = <&q6apmbedai PRIMARY_MI2S_TX>;
>>> + };
>>> +
>>> + platform {
>>> + sound-dai = <&q6apm>;
>>> + };
>>> + };
>>> +
>>> + pri-mi2s-playback-dai-link {
>>> + link-name = "Primary MI2S Playback";
>>> +
>>> + codec {
>>> + sound-dai = <&codec_da7212>;
>>> + };
>>> +
>>> + cpu {
>>> + sound-dai = <&q6apmbedai PRIMARY_MI2S_RX>;
>>> + };
>>> +
>>> + platform {
>>> + sound-dai = <&q6apm>;
>>> + };
>>> + };
>>> + };
>>> +
>>> vreg_v1p8_out: regulator-v1p8-out {
>>> compatible = "regulator-fixed";
>>> regulator-name = "vreg-v1p8-out";
>>> @@ -109,6 +150,19 @@ adv7535_out: endpoint {
>>> };
>>> };
>>> +&i2c5 {
>>> + status = "okay";
>>> +
>>> + codec_da7212: codec@1a {
>>> + compatible = "dlg,da7212";
>>> + reg = <0x1a>;
>>> + #sound-dai-cells = <0>;
>>> + VDDA-supply = <&vreg_v1p8_out>;
>>> + VDDIO-supply = <&vreg_v1p8_out>;
>>> + VDDMIC-supply = <&vreg_v3p3_out>;
>>> + };
>>> +};
>>> +
>>> &mdss_dsi0_out {
>>> remote-endpoint = <&adv7535_in>;
>>> data-lanes = <0 1 2 3>;
>>> @@ -124,6 +178,17 @@ &pon_resin {
>>> status = "okay";
>>> };
>>> +&q6apmbedai {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + dai@17 {
>>> + reg = <PRIMARY_MI2S_TX>;
>>> + clocks = <&q6prmcc LPASS_CLK_ID_MCLK_2
>>> LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
>>> + clock-names = "mclk";
>>> + };
>>> +};
>>> +
>>> &sdhc_2 {
>>> pinctrl-0 = <&sdc2_state_on>;
>>> pinctrl-1 = <&sdc2_state_off>;
>>> --
>>> 2.34.1
>>>
>
>
--
Thx and BRs,
Le Qi
next prev parent reply other threads:[~2026-04-08 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 6:04 [PATCH v4 0/2] arm64: dts: qcom: QCS615 Talos EVK audio support Le Qi
2026-03-24 6:04 ` [PATCH v4 1/2] arm64: dts: qcom: talos: Add GPR node, audio services, and MI2S1 TLMM pins Le Qi
2026-03-30 13:57 ` Bjorn Andersson
2026-04-08 9:48 ` Le Qi
2026-03-24 6:04 ` [PATCH v4 2/2] arm64: dts: qcom: talos-evk: Add sound card support with DA7212 codec Le Qi
2026-03-30 13:53 ` Bjorn Andersson
[not found] ` <78ebca6b-d8e2-4db2-8a34-ebdb6f401a5c@oss.qualcomm.com>
2026-04-08 9:48 ` Le Qi [this message]
2026-05-12 20:23 ` [PATCH v4 0/2] arm64: dts: qcom: QCS615 Talos EVK audio support Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2231896-d065-43ee-901a-7dc35299f264@oss.qualcomm.com \
--to=le.qi@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=kernel@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®