From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B028C6FD18 for ; Fri, 31 Mar 2023 09:35:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231309AbjCaJfI (ORCPT ); Fri, 31 Mar 2023 05:35:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232290AbjCaJeR (ORCPT ); Fri, 31 Mar 2023 05:34:17 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D99ECA1D for ; Fri, 31 Mar 2023 02:34:02 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id q16so28079473lfe.10 for ; Fri, 31 Mar 2023 02:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680255240; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ai/1YpnrQGMFVrnQJeZGVLCmWTY7Fz7OsSb9rllfA/A=; b=bXr2Xm5tyW+sglpq+sV+BJ/VlJIXrkWrlavLQftfI12wsd+i87DDKbAWpw4fLK6JJu TuQxBQoXbC1FkMaIY+osrvcF3Uo0DCrkn3YlroowTyOUQG/JSyf6j/Qz+I362/qyYvpb vW6KmvooSBlZETfBQhFqLfrwMnKhsD6CKuXTJSHMyLqfhVSWqUkipTrRX4+H1aIBby9R GQjkOO6fVn/Uj6ZYHIQ1W2VZ/5THM/Di45QsRBw5En6fFKaqB4iH78ULxJoSB9XUuBWD ZoCGLcg00OVTS5tUOQj+fKV4Bn5a+6UTbGLmfWBY8vvvv/UVBZm72g6kMFqLpvHwPGXK i2iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680255240; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ai/1YpnrQGMFVrnQJeZGVLCmWTY7Fz7OsSb9rllfA/A=; b=gZDVh6MgnC0QFHCJ6/sBjPzQV/5SRrwrnZkW1KixV4TkjEDO/iewrWigOEt3+i0HK/ eUv0hmqgA1ulKCG4Kgm+MOQpmGMtvHCOVCjGub41NqJyQ8xl9H9q+/CvzrPiiL9XKech re2EeXegNbKEqkwQQeUDKcf7mRVpag8YrLS3Y2Lw3Mi5wd1xon/ClAwaqXt0s1BPhZkK fDedYiPww8YfyomT7+LruN4a/nHjgJ6kpVhUCct2Pml1BgtSH9ETVTQkizJTxUivdwK4 o9e/bsuljlZR6yF8JORPyIjIt58A18qpoUcA/Japj6w+RBN6rqb/N/I7Zo2BbZiHWG9l NFog== X-Gm-Message-State: AAQBX9c0w1v4V+fewEkSq4BZOR8fAhxrLKjSqXJLSRu0fOEWMHJCp7bz Q3FqrbUphmHKmoZL96ggscCUZw== X-Google-Smtp-Source: AKy350Zw3AEl/l1nQ2UFiIHwCfWmha0LEvbnsktucmxS1dk8XV4DbUPsuRtguW7IZ5SHImNMhoNXQw== X-Received: by 2002:ac2:5318:0:b0:4e9:b64a:b87d with SMTP id c24-20020ac25318000000b004e9b64ab87dmr8522538lfh.9.1680255240307; Fri, 31 Mar 2023 02:34:00 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id l14-20020a2e99ce000000b0029f7d27b78bsm285041ljj.110.2023.03.31.02.33.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 02:33:59 -0700 (PDT) Message-ID: Date: Fri, 31 Mar 2023 11:33:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 Content-Language: en-US To: Francesco Dolcini Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, Rob Herring , Krzysztof Kozlowski , Peter Ujfalusi , devicetree@vger.kernel.org, Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org References: <20230330095941.428122-1-francesco@dolcini.it> <20230330095941.428122-3-francesco@dolcini.it> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/03/2023 11:30, Francesco Dolcini wrote: > On Fri, Mar 31, 2023 at 10:42:40AM +0200, Krzysztof Kozlowski wrote: >> On 30/03/2023 11:59, Francesco Dolcini wrote: >>> From: Francesco Dolcini >>> >>> Add TC9594, from the software point of view this is identical to >>> TC358768 with the main difference being automotive qualified. >>> >>> Signed-off-by: Francesco Dolcini >>> --- >>> .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> index d6dac186ac59..8f22093b61ae 100644 >>> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> @@ -4,19 +4,20 @@ >>> $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# >>> $schema: http://devicetree.org/meta-schemas/core.yaml# >>> >>> -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge >>> +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge >>> >>> maintainers: >>> - Peter Ujfalusi >>> >>> description: | >>> - The TC358768/TC358778 is bridge device which converts RGB to DSI. >>> + The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI. >>> >>> properties: >>> compatible: >>> enum: >>> - toshiba,tc358768 >>> - toshiba,tc358778 >>> + - toshiba,tc9594 >> >> If it is the same, why they are not compatible? > > I assume I am not understanding something very basic ... > > The register description and SW functionality of all these 3 parts is > identical. > > How should be the compatible described in the DT schema in this case? Look at any board compatibles for example. > > >> I got only three patches out of six, thus I cannot check by myself. > > Here the whole series: https://lore.kernel.org/all/20230330095941.428122-1-francesco@dolcini.it/ > > Do you want to me to send the whole series and not just the DT binding > next time? Happy to do it, if you prefer. So NAK on 4th patch. Don't grow device ID tables needlessly. Best regards, Krzysztof