From: Vlastimil Babka <vbabka@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>,
"Guilherme G. Piccoli" <gpiccoli@canonical.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
keescook@chromium.org, yzaikin@google.com, mcgrof@kernel.org,
kernel@gpiccoli.net
Subject: Re: [PATCH] kernel/watchdog.c: convert {soft/hard}lockup boot parameters to sysctl aliases
Date: Mon, 11 May 2020 12:31:29 +0200 [thread overview]
Message-ID: <f2273ab4-d2fc-cee5-61ed-8148d4a76709@suse.cz> (raw)
In-Reply-To: <20200507160618.43c2825e49dec1df8db30429@linux-foundation.org>
On 5/8/20 1:06 AM, Andrew Morton wrote:
> On Thu, 7 May 2020 18:46:24 -0300 "Guilherme G. Piccoli" <gpiccoli@canonical.com> wrote:
>
>> After a recent change introduced by Vlastimil's series [0], kernel is
>> able now to handle sysctl parameters on kernel command line; also, the
>> series introduced a simple infrastructure to convert legacy boot
>> parameters (that duplicate sysctls) into sysctl aliases.
>>
>> This patch converts the watchdog parameters softlockup_panic and
>> {hard,soft}lockup_all_cpu_backtrace to use the new alias infrastructure.
>> It fixes the documentation too, since the alias only accepts values 0
>> or 1, not the full range of integers. We also took the opportunity here
>> to improve the documentation of the previously converted hung_task_panic
>> (see the patch series [0]) and put the alias table in alphabetical order.
>
> We have a lot of sysctls. What is the motivation for converting these
> particular ones?
It's not converting sysctls, it's converting legacy boot parameters that have a
sysctl counterpart. There's not a lot of those, and new ones shouldn't be added
with the generic infrastructure in place. I would have converted them myself if
I found them :)
next prev parent reply other threads:[~2020-05-11 10:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 21:46 Guilherme G. Piccoli
2020-05-07 23:06 ` Andrew Morton
2020-05-08 2:17 ` Guilherme G. Piccoli
2020-05-11 10:31 ` Vlastimil Babka [this message]
2020-05-11 10:28 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2273ab4-d2fc-cee5-61ed-8148d4a76709@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=gpiccoli@canonical.com \
--cc=keescook@chromium.org \
--cc=kernel@gpiccoli.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®