From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Herve Codina <herve.codina@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3] net: wan: framer: Add version sysfs attribute for the Lantiq PEF2256 framer
Date: Thu, 25 Sep 2025 09:06:13 +0200 [thread overview]
Message-ID: <f229764d-7dc5-4dfb-84d5-1dacec7edb86@csgroup.eu> (raw)
In-Reply-To: <20250924164811.3952a2d7@kernel.org>
Le 25/09/2025 à 01:48, Jakub Kicinski a écrit :
> On Wed, 24 Sep 2025 17:06:47 +0200 Christophe Leroy wrote:
>> Lantiq PEF2256 framer has some little differences in behaviour
>> depending on its version.
>>
>> Add a sysfs attribute to allow user applications to know the
>> version.
>
> Outsider question perhaps but what is the version of?
> It sounds like a HW revision but point releases for ASICs are quite
> uncommon. So I suspect it's some SW/FW version?
The datasheet of the component just calls it 'version'.
Among all registers there is a register called 'version status register'
which contains a single field named 'Version Number of chip'. This field
is an 8 bits value and the documentation tells that value 0x00 is
version 1.2, value 0x10 is version 2.1, etc...
>
> We generally recommend using devlink dev info for reporting all sort
> of versions...
Ok, I'll look at devlink. Based on the above, what type of
DEVLINK_INFO_VERSION_GENERIC_XXXX would you use here ?
Thanks
Christophe
next prev parent reply other threads:[~2025-09-25 7:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 15:06 Christophe Leroy
2025-09-24 23:48 ` Jakub Kicinski
2025-09-25 7:06 ` Christophe Leroy [this message]
2025-09-26 20:35 ` Jakub Kicinski
2025-09-26 22:20 ` patchwork-bot+netdevbpf
2025-09-29 7:45 ` Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f229764d-7dc5-4dfb-84d5-1dacec7edb86@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herve.codina@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®