From: Davide Caratti <dcaratti@redhat.com>
To: Saravana Kannan <saravanak@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Vladimir Benes <vbenes@redhat.com>
Cc: kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] driver core: Skip unnecessary work when device doesn't have sync_state()
Date: Tue, 24 Mar 2020 21:03:28 +0100 [thread overview]
Message-ID: <f22b7cd6fb6256f56e908e021f4fe389f3a6ee07.camel@redhat.com> (raw)
In-Reply-To: <20200221080510.197337-4-saravanak@google.com>
On Fri, 2020-02-21 at 00:05 -0800, Saravana Kannan wrote:
> A bunch of busy work is done for devices that don't have sync_state()
> support. Stop doing the busy work.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
> drivers/base/core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
hello Greg,
this patch and patch 2/3 of the same series proved to fix systematic
crashes (NULL pointer dereference in device_links_flush_sync_list() while
loading mac80211_hwsim.ko, see [1]) on Fedora 31, that are triggered by
NetworkManager-ci [2]. May I ask to queue these two patches for the next
5.5 stable?
thank you in advance (and thanks to Vladimir for reporting)!
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1816765
[2] https://github.com/NetworkManager/NetworkManager-ci
--
davide
next prev parent reply other threads:[~2020-03-24 20:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 8:05 [PATCH v2 0/3] driver core: sync state fixups Saravana Kannan
2020-02-21 8:05 ` [PATCH v2 1/3] driver core: Call sync_state() even if supplier has no consumers Saravana Kannan
2020-02-21 9:25 ` Greg Kroah-Hartman
2020-02-21 9:48 ` Saravana Kannan
2020-02-21 10:32 ` Greg Kroah-Hartman
2020-02-21 16:00 ` Saravana Kannan
2020-02-21 8:05 ` [PATCH v2 2/3] driver core: Add dev_has_sync_state() Saravana Kannan
2020-02-21 8:05 ` [PATCH v2 3/3] driver core: Skip unnecessary work when device doesn't have sync_state() Saravana Kannan
2020-03-24 20:03 ` Davide Caratti [this message]
2020-03-24 20:14 ` Saravana Kannan
2020-03-25 7:44 ` Greg Kroah-Hartman
2020-03-25 9:11 ` Davide Caratti
2020-03-25 9:17 ` Greg Kroah-Hartman
2020-03-04 12:49 ` [PATCH v2 0/3] driver core: sync state fixups Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f22b7cd6fb6256f56e908e021f4fe389f3a6ee07.camel@redhat.com \
--to=dcaratti@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=vbenes@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome