From: "Zhang, Rui" <rui.zhang@intel.com>
To: "linux@roeck-us.net" <linux@roeck-us.net>,
"ashok_raj@linux.intel.com" <ashok_raj@linux.intel.com>
Cc: "Yu, Fenghua" <fenghua.yu@intel.com>,
"Raj, Ashok" <ashok.raj@intel.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>
Subject: Re: [PATCH 2/3] hwmon: (coretemp) Remove unnecessary dependency of array index
Date: Fri, 1 Dec 2023 17:31:32 +0000 [thread overview]
Message-ID: <f22c891c38f01af65f7f51176045a66e537ad176.camel@intel.com> (raw)
In-Reply-To: <b4723259-92a1-4c9a-8f4a-52b4b61940c5@roeck-us.net>
> > > mutex_lock(&tdata->update_lock);
> > > @@ -445,7 +441,6 @@ static int create_core_attrs(struct temp_data
> > > *tdata, struct device *dev,
> > > tdata->sd_attrs[i].dev_attr.attr.name = tdata-
> > > >attr_name[i];
> > > tdata->sd_attrs[i].dev_attr.attr.mode = 0444;
> > > tdata->sd_attrs[i].dev_attr.show = rd_ptr[i];
> > > - tdata->sd_attrs[i].index = attr_no;
> >
> > I was naively thinking if we could nuke that "index". I can see
> > that used
> > in couple macros, but seems like we can lose it?
> >
> > Completely untested.. and uncertain :-)
> >
>
> If you had suggested to replace
> struct sensor_device_attribute sd_attrs[TOTAL_ATTRS];
> with
> struct device_attribute sd_attrs[TOTAL_ATTRS];
> what you suggested may actually be possible and make sense.
Too late for me today.
Let me check if I can convert it to use device_attribute instead
tomorrow.
thanks,
rui
next prev parent reply other threads:[~2023-12-01 17:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 13:16 [PATCH 0/3] hwmon: (coretemp) Fix core count limitation Zhang Rui
2023-11-27 13:16 ` [PATCH 1/3] hwmon: (coretemp) Introduce enum for attr index Zhang Rui
2023-11-30 21:51 ` Ashok Raj
2023-12-01 4:14 ` Guenter Roeck
2023-12-01 4:47 ` Ashok Raj
2023-12-01 17:29 ` Zhang, Rui
2023-12-05 19:20 ` Ashok Raj
2023-11-27 13:16 ` [PATCH 2/3] hwmon: (coretemp) Remove unnecessary dependency of array index Zhang Rui
2023-12-01 1:27 ` Ashok Raj
2023-12-01 3:26 ` Guenter Roeck
2023-12-01 4:34 ` Ashok Raj
2023-12-01 17:31 ` Zhang, Rui [this message]
2023-11-27 13:16 ` [PATCH 3/3] hwmon: (coretemp) Fix core count limitation Zhang Rui
2023-12-01 2:08 ` Ashok Raj
2023-12-01 17:47 ` Zhang, Rui
2023-12-01 22:58 ` Ashok Raj
2023-12-02 7:22 ` Zhang, Rui
2023-12-01 3:06 ` Guenter Roeck
2023-12-01 17:41 ` Zhang, Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f22c891c38f01af65f7f51176045a66e537ad176.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=ashok.raj@intel.com \
--cc=ashok_raj@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®