Re: [PATCH 3/3] dt-bindings: spi: Add spiclk to clock-names property in pl022

[Robin Murphy <robin.murphy@arm.com>]

On 2022-02-28 12:43, Kuldeep Singh wrote:
> Fix below dtc warning by making necessary addition of "spiclk" in
> clock-names property.
> 
> arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dt.yaml: spi@190000:
> clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk']
>      From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml
> arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dt.yaml: spi@66190000:
> clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk']
>      From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml

As before, what makes the binding at fault rather than that DT? The 
PL022's actual input is named SSPCLK, not SPICLK, so why should a driver 
which wants to look up that clock by name expect to look for "spiclk"?

Robin.

> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> ---
>   Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> index 5f6926a58b15..fb3075a0c7fd 100644
> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> @@ -45,6 +45,7 @@ properties:
>             - enum:
>                 - sspclk
>                 - SSPCLK
> +              - spiclk
>             - const: apb_pclk
>   
>     pl022,autosuspend-delay: