mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
To: Changyul Lee <lcy8047@gmail.com>, Jeff Johnson <jjohnson@kernel.org>
Cc: Baochen Qiang <baochen.qiang@oss.qualcomm.com>,
	Sriram R <sriram.ramachandran@oss.qualcomm.com>,
	Vasanthakumar Thiagarajan
	<vasanthakumar.thiagarajan@oss.qualcomm.com>,
	Praneesh P <praneesh.p@oss.qualcomm.com>,
	Jiale Yao <yaojiale02@163.com>,
	linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH ath-next] wifi: ath12k: hold txmgmt_idr_lock while freeing pending mgmt frames
Date: Mon, 16 Nov 2026 15:04:15 +0530	[thread overview]
Message-ID: <f2347531-afa4-41fd-b0fc-4a150c728a0f@oss.qualcomm.com> (raw)
In-Reply-To: <20261116021037.538128-1-lcy8047@gmail.com>

On 11/16/2026 7:40 AM, Changyul Lee wrote:
> ath12k_mac_vif_txmgmt_cleanup() and ath12k_mac_tx_mgmt_pending_free()
> walk ar->txmgmt_idr without txmgmt_idr_lock. A WMI management TX
> completion can meanwhile remove an entry and pass its skb to mac80211,
> which frees it. ath12k_mac_vif_txmgmt_cleanup() then reads skb_cb->vif
> from the freed skb, and both walks can read an IDR node that was freed
> after an RCU grace period.
> 
> Hold txmgmt_idr_lock over both walks and make ath12k_mac_tx_mgmt_free()
> expect it to be held.
> 
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Suggested-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
> Signed-off-by: Changyul Lee <lcy8047@gmail.com>
> ---
> Found with a static analysis tool we are developing.
> Compile-tested only, with x86_64_defconfig plus ATH12K and W=1.
> 
>   drivers/net/wireless/ath/ath12k/mac.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
> index eee3f38375ae..bffb2edd0531 100644
> --- a/drivers/net/wireless/ath/ath12k/mac.c
> +++ b/drivers/net/wireless/ath/ath12k/mac.c
> @@ -9220,10 +9220,9 @@ static void ath12k_mac_tx_mgmt_free(struct ath12k *ar, int buf_id)
>   	struct sk_buff *msdu;
>   	struct ieee80211_tx_info *info;
>   
> -	spin_lock_bh(&ar->txmgmt_idr_lock);
> -	msdu = idr_remove(&ar->txmgmt_idr, buf_id);
> -	spin_unlock_bh(&ar->txmgmt_idr_lock);
> +	lockdep_assert_held(&ar->txmgmt_idr_lock);
>   
> +	msdu = idr_remove(&ar->txmgmt_idr, buf_id);
>   	if (!msdu)
>   		return;
>   
> @@ -9241,8 +9240,10 @@ void ath12k_mac_tx_mgmt_pending_free(struct ath12k *ar)
>   	struct sk_buff *msdu;
>   	int buf_id;
>   
> +	spin_lock_bh(&ar->txmgmt_idr_lock);
>   	idr_for_each_entry(&ar->txmgmt_idr, msdu, buf_id)
>   		ath12k_mac_tx_mgmt_free(ar, buf_id);
> +	spin_unlock_bh(&ar->txmgmt_idr_lock);
>   }
>   
>   static void ath12k_mac_vif_txmgmt_cleanup(struct ath12k *ar,
> @@ -9252,11 +9253,13 @@ static void ath12k_mac_vif_txmgmt_cleanup(struct ath12k *ar,
>   	struct sk_buff *skb;
>   	int buf_id;
>   
> +	spin_lock_bh(&ar->txmgmt_idr_lock);
>   	idr_for_each_entry(&ar->txmgmt_idr, skb, buf_id) {
>   		skb_cb = ATH12K_SKB_CB(skb);
>   		if (skb_cb->vif == vif)
>   			ath12k_mac_tx_mgmt_free(ar, buf_id);
>   	}
> +	spin_unlock_bh(&ar->txmgmt_idr_lock);
>   }
>   
>   static int ath12k_mac_mgmt_tx_wmi(struct ath12k *ar, struct ath12k_link_vif *arvif,
> 
> base-commit: 1be6c8d3027d4a421dc46b93a89a196c61945614


Reviewed-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>

      reply	other threads:[~2026-11-16  9:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  2:10 Changyul Lee
2026-11-16  9:34 ` Rameshkumar Sundaram [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2347531-afa4-41fd-b0fc-4a150c728a0f@oss.qualcomm.com \
    --to=rameshkumar.sundaram@oss.qualcomm.com \
    --cc=ath12k@lists.infradead.org \
    --cc=baochen.qiang@oss.qualcomm.com \
    --cc=jjohnson@kernel.org \
    --cc=lcy8047@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=praneesh.p@oss.qualcomm.com \
    --cc=sriram.ramachandran@oss.qualcomm.com \
    --cc=vasanthakumar.thiagarajan@oss.qualcomm.com \
    --cc=yaojiale02@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®