mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Youling Tang <tangyouling@loongson.cn>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Remove unused BOOT_MEM_INIT_RAM
Date: Mon, 14 Sep 2020 12:32:07 +0800	[thread overview]
Message-ID: <f2349dc3-8086-64ee-e2d7-7a69afac6623@flygoat.com> (raw)
In-Reply-To: <1599875955-9207-1-git-send-email-tangyouling@loongson.cn>



在 2020/9/12 9:59, Youling Tang 写道:
> Commit a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") left
> the BOOT_MEM_INIT_RAM unused, remove it.
>
> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
> ---
>   arch/mips/include/asm/bootinfo.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/bootinfo.h b/arch/mips/include/asm/bootinfo.h
> index 147c932..39196ae 100644
> --- a/arch/mips/include/asm/bootinfo.h
> +++ b/arch/mips/include/asm/bootinfo.h
> @@ -91,7 +91,6 @@ extern unsigned long mips_machtype;
>   #define BOOT_MEM_RAM		1
>   #define BOOT_MEM_ROM_DATA	2
>   #define BOOT_MEM_RESERVED	3
> -#define BOOT_MEM_INIT_RAM	4

If you're willing to remove that you'd better turn the memtype struct
into a enum.

Btw: It seems you've done a lot of minor clean-up works recently,
if you'd like to I think you can try to turn all the platforms into memblock
and remove all these gules between memblock and legacy code.

Thanks.

- Jiaxun

>   #define BOOT_MEM_NOMAP		5
>   
>   extern void add_memory_region(phys_addr_t start, phys_addr_t size, long type);

  reply	other threads:[~2020-09-14  4:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12  1:59 Youling Tang
2020-09-14  4:32 ` Jiaxun Yang [this message]
2020-09-14 10:39   ` Youling Tang
2020-09-14 11:08     ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2349dc3-8086-64ee-e2d7-7a69afac6623@flygoat.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=tangyouling@loongson.cn \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®