From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBoufiTZRIGaTwv319cBruajWowp4D/uFAy2mstdv8IzW8ib1Vfsd+8ZLE8oYyPOrV97bZRhX ARC-Seal: i=1; a=rsa-sha256; t=1516337082; cv=none; d=google.com; s=arc-20160816; b=KxfHzyt0oQfNQze1p+zDIvbkxkO5tEsNyB72IkJAuvxznm43XYwC51OFGX/H4OUYrH 4l6IDW51M7Si9vWoJ9bCvlij3x77/3ar/s68XFwYuABscUzvcflUJKaOE6W9f/uz/7Av 3KjZhu6bkash/f3Qwy1HYtIWsKKq4417Aw2NdEJqHdb0BkJX8cpOtvmMml8oeDEMABme d/dQxobt/pD2HPT/z8HojZofEfBV/7dj1syLR7NbNvZYawmQc4auOPI8X5dIyHwxvV84 npjHokQZ1EA1juZ7dM8D5T3Dbm2S16rQ/JW9KXI0WgCXYjRmpR4aiS9rSetlSFhnFQDd qeMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=lb2THe3LVmK9gFIEJWPIDPVNQMfiHIuNxDG3R6wh53Y=; b=HG+U5VkorQAAjJ8kB81pymrqHjuMKD7+KKZcJk0aRGEriebXJLPFrjiipKWh0ffj6p j6R8KhIhLXsvIfwHReGQjnOhP+hc3d8ThvNvSpFQN5ou5RYY0FnE56Rlt6A3NialKqpJ qViIMUYPiI40aH/7OJQLNHgkAH4fKPR9wtwoQZ0Th8s0jSQg++3tLrIU1W5XxpjWhfgY FiyTlHTo5yAfLZh0fwP4zNFbdWfN4P+caIsZvZzhuPXv5FJxdB2WrEkfWk1cTmYBRXlP 7aXUQmG7tOaQGe/mEO5GaUcPH7ZuMtVbfk55Q8Ert+yS0jFJOKV0qH9FMUzK4ptw3vrz 0rVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=YfkdpYgc; dkim=pass header.i=@codeaurora.org header.s=default header.b=X1BSDgIi; spf=pass (google.com: domain of okaya@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=okaya@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=YfkdpYgc; dkim=pass header.i=@codeaurora.org header.s=default header.b=X1BSDgIi; spf=pass (google.com: domain of okaya@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=okaya@codeaurora.org DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org ABC8B605A4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC To: poza@codeaurora.org Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Timur Tabi References: <1516185438-31556-1-git-send-email-poza@codeaurora.org> <1516185438-31556-4-git-send-email-poza@codeaurora.org> <733abfcb-5b31-7394-ab62-19a0888d71c2@codeaurora.org> <5cf7004e62a2979afb3c29e99d705c60@codeaurora.org> <35a9ce2b-156f-3235-c3b7-2c495fe9c52b@codeaurora.org> <64127dba1cebab196c88a160191ebee0@codeaurora.org> <0ab49441-548e-a5bc-d76b-bdc6fa7495dc@codeaurora.org> From: Sinan Kaya Message-ID: Date: Thu, 18 Jan 2018 23:44:38 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589835690475100377?= X-GMAIL-MSGID: =?utf-8?q?1589994672885215877?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 1/18/2018 11:23 PM, poza@codeaurora.org wrote: > On 2018-01-18 23:33, Sinan Kaya wrote: >> On 1/18/2018 1:00 PM, poza@codeaurora.org wrote: >>>> I think you would put into include/linux/pci.h only if there is an external >>>> use of constant outside of drivers/pci directory. Otherwise, you should keep >>>> the setting inside one of the header files in drivers/pci directory. >>>> >>>> I don't see any other subsystem caring about DPC_FATAL definition. >>> >>> ok so you are suggesting to move only DPC_FATAL ? so then AER can stay where it is. >> >> Now that both AER and DPC handling is getting unified, I think it makes sense to >> keep all error codes (AER+DPC) together in drivers/pci/pci.h rather than having >> them split in aer.h and dpc.h. >> >> Otherwise, how would we avoid having a new error type defined with the >> existing values. > > I agree, its is just that drivers/acpi/apet/ghes.c has to do > #include ../../pci/pci.h That's bad. I was just thinking about the DPC error code only. I didn't realize AER error codes are being referenced from ghes.c. > > but thats okay I think.  let me move error codes to drivers/pci/pci.h. It is better if error codes move to include/linux/pci.h and keep them together. > > Regards, > Oza. > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.