mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: Zide Chen <zide.chen@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	Eranian Stephane <eranian@google.com>,
	Babu Moger <babu.moger@amd.com>,
	"Tony luck" <tony.luck@intel.com>,
	Dapeng Mi <dapeng1.mi@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-perf-users@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] perf/x86/intel/uncore: Add per-scheduler IMC CAS count events
Date: Tue, 10 Feb 2026 08:52:51 -0800	[thread overview]
Message-ID: <f235df30-7b88-4ae7-88f8-399437e85461@intel.com> (raw)
In-Reply-To: <20260210005225.20311-1-zide.chen@intel.com>



On 2/9/26 4:52 PM, Zide Chen wrote:
> IMC on SPR and EMR does not support sub-channels.  In contrast, CPUs
> that use gnr_uncores[] (e.g. Granite Rapids and Sierra Forest)
> implement two command schedulers (SCH0/SCH1) per memory channel,
> providing logically independent command and data paths.
> 
> Do not reuse the spr_uncore_imc[] configuration for these CPUs.
> Instead, introduce a dedicated gnr_uncore_imc[] with per-scheduler
> events, so userspace can monitor SCH0 and SCH1 independently.
> 
> On these CPUs, replace cas_count_{read,write} with
> cas_count_{read,write}_sch{0,1}.  This may break existing userspace
> that relies on cas_count_{read,write}, prompting it to switch to the
> per-scheduler events, as the legacy event reports only partial
> traffic (SCH0).
> 
> Reported-by: Reinette Chatre <reinette.chatre@intel.com>
> Fixes: 632c4bf6d007 ("perf/x86/intel/uncore: Support Granite Rapids")
> Fixes: cb4a6ccf3583 ("perf/x86/intel/uncore: Support Sierra Forest and Grand Ridge")
> Cc: stable@vger.kernel.org
> Signed-off-by: Zide Chen <zide.chen@intel.com>
> ---

The resctrl selftests compare the read memory bandwidth reported by
iMC PMUs against resctrl's memory bandwidth monitoring (MBM) numbers. These
tests are failing on Granite Rapids and Sierra Forest because the tests use
the event/umask obtained from 
  /sys/bus/event_source/devices/uncore_imc_N/events/cas_count_read
that only measures about half the bandwidth reported by MBM.

When using this patch and adapting [1] the resctrl selftests to use the new
interface to learn about the additional events it is possible to get the
accurate iMC PMU memory bandwidth measurements that match values reported by MBM.

Thank you very much!

Tested-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette

[1] https://lore.kernel.org/lkml/cover.1770406608.git.reinette.chatre@intel.com/

  parent reply	other threads:[~2026-02-10 16:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  0:52 Zide Chen
2026-02-10  6:22 ` Mi, Dapeng
2026-02-10 16:52 ` Reinette Chatre [this message]
2026-02-23 10:30 ` [tip: perf/urgent] " tip-bot2 for Zide Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f235df30-7b88-4ae7-88f8-399437e85461@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=babu.moger@amd.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=eranian@google.com \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=zide.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®