From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
<linux-kernel@vger.kernel.org>
Cc: <linux-fbdev@vger.kernel.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] fb: adv7393: Use IS_ENABLED() instead of checking for built-in or module
Date: Wed, 10 Aug 2016 13:55:31 +0300 [thread overview]
Message-ID: <f2380927-a419-414f-c5ec-2aabed677238@ti.com> (raw)
In-Reply-To: <1468269877-9900-1-git-send-email-javier@osg.samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 1011 bytes --]
On 11/07/16 23:44, Javier Martinez Canillas wrote:
> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
> built-in or as a module, use that macro instead of open coding the same.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/video/fbdev/bfin_adv7393fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/bfin_adv7393fb.c b/drivers/video/fbdev/bfin_adv7393fb.c
> index 8fe41caac38e..9a01cd7ca73c 100644
> --- a/drivers/video/fbdev/bfin_adv7393fb.c
> +++ b/drivers/video/fbdev/bfin_adv7393fb.c
> @@ -795,7 +795,7 @@ static struct i2c_driver bfin_adv7393_fb_driver = {
>
> static int __init bfin_adv7393_fb_driver_init(void)
> {
> -#if defined(CONFIG_I2C_BLACKFIN_TWI) || defined(CONFIG_I2C_BLACKFIN_TWI_MODULE)
> +#if IS_ENABLED(CONFIG_I2C_BLACKFIN_TWI)
> request_module("i2c-bfin-twi");
> #else
> request_module("i2c-gpio");
>
Thanks, queued for v4.9.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-10 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 20:44 Javier Martinez Canillas
2016-08-10 10:55 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2380927-a419-414f-c5ec-2aabed677238@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=javier@osg.samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®