From: Ivan Orlov <ivan.orlov0322@gmail.com>
To: Christian Schoenebeck <linux_oss@crudebyte.com>,
ericvh@gmail.com, lucho@ionkov.net, asmadeus@codewreck.org
Cc: v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
himadrispandya@gmail.com,
syzbot+cb1d16facb3cc90de5fb@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] 9P FS: Fix wild-memory-access write in v9fs_get_acl
Date: Sat, 11 Mar 2023 16:08:24 +0400 [thread overview]
Message-ID: <f23b861f-25ea-785d-83b3-f66d924d663f@gmail.com> (raw)
In-Reply-To: <15987509.0H6QrEVh2d@silver>
On 3/11/23 15:17, Christian Schoenebeck wrote:
> I would have written it in different style:
>
> if (buffer_size)
> retval = -ERANGE;
> else if (attr_size > SSIZE_MAX)
> retval = -EOVERFLOW;
> else
> retval = attr_size; /* request to get the attr_size */
>
> But the behaviour change itself makes sense, so:
>
> Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com>
>
>> } else {
>> iov_iter_truncate(&to, attr_size);
>> retval = p9_client_read(attr_fid, 0, &to, &err);
>>
>
>
You are right, the condition can be simplified, thank you! I will
rewrite it, send as v3 and mention you in 'suggested-by'.
prev parent reply other threads:[~2023-03-11 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 6:34 Ivan Orlov
2023-03-11 6:46 ` Ivan Orlov
2023-03-11 8:25 ` [syzbot] [9p?] KASAN: wild-memory-access Write " syzbot
2023-03-11 9:19 ` [PATCH v2] 9P FS: Fix wild-memory-access write " Ivan Orlov
2023-03-11 11:17 ` Christian Schoenebeck
2023-03-11 12:08 ` Ivan Orlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f23b861f-25ea-785d-83b3-f66d924d663f@gmail.com \
--to=ivan.orlov0322@gmail.com \
--cc=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=himadrispandya@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+cb1d16facb3cc90de5fb@syzkaller.appspotmail.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®