From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1637C433F5 for ; Mon, 24 Jan 2022 13:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235477AbiAXNy7 (ORCPT ); Mon, 24 Jan 2022 08:54:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:41928 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbiAXNy6 (ORCPT ); Mon, 24 Jan 2022 08:54:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643032497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/3Zaur0RiXMvQoYarsskyjbAUyo7mdjsj0Z7CFVYRXE=; b=C2JWsL9Yxak8pUHWZY+6dotbgHvAq7+vpjNjZfCfCFxVkcC6Fjr/LyyGhApyTlAvcIrv2i BM537YpdI4V4qt8W92unGpZGvnxv44aNNewz/ZJ/WmBanJN2PkN089hhD5U4Wj/e31WpWv 83XW5S8/n50u8yLa3N0miiJ5Ev9e2S0= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-KlN5CxySPuuoGZlJeusd0w-1; Mon, 24 Jan 2022 08:54:54 -0500 X-MC-Unique: KlN5CxySPuuoGZlJeusd0w-1 Received: by mail-ed1-f71.google.com with SMTP id c11-20020a056402120b00b0040321cea9d4so13149226edw.23 for ; Mon, 24 Jan 2022 05:54:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/3Zaur0RiXMvQoYarsskyjbAUyo7mdjsj0Z7CFVYRXE=; b=7nuZPXgjXGK7/oPfi6Ine4DnuYzCummydvCbNk2gtivzmoIQ5LLKhi1QiTzvjy+3mz 7WDcbhSMYKkA2Wb2UUZ/BAJAIL+iGrQBh6fAxGco2xllDUHOON3e0vbUC1gUSeNYOUSR ha7ElBQHzKe/+i71Tcy5ke6OsTxu0AStqUpKNVyKUKU5sygV++HV3iKfW7vqZ1XIA5S6 /BEwTFRrTzYOgaeD7aHOpOMm5h4qqtvi59y1+VR4dTJP7rQHdOLkLNeeQLnEEbmpVAvu y5KT/322uzOMjLyf5wnBBBmfcW0tZuBzM8IrDxsWkTKFdJsoLXcqcSBihb8SpoPmUM/w zipw== X-Gm-Message-State: AOAM530CeN46Z4k/ZARzSKDJL4y6BTd756cYOE/chuZs3ZIgLEoM8RNd 3zpdk3L0Sjz4M1K9/TppLrokOFEPSsGDGjRR3wmoBeYtYCEOyedJUE3FnUKl0mL40D4NDEZ6ROD Dgy+zROooNrZLv37u6DEEJ65U X-Received: by 2002:a17:906:f986:: with SMTP id li6mr12367426ejb.175.1643032492884; Mon, 24 Jan 2022 05:54:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJymqDgBWmnVcfUVI2SVKWFtt9uJD92FqsAwiMmp9N8DafCXiA4FzKnkBFHMFNdZDWpCeC4fBw== X-Received: by 2002:a17:906:f986:: with SMTP id li6mr12367415ejb.175.1643032492674; Mon, 24 Jan 2022 05:54:52 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id a20sm6646957edb.12.2022.01.24.05.54.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jan 2022 05:54:52 -0800 (PST) Message-ID: Date: Mon, 24 Jan 2022 14:54:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] KVM: remove async parameter of hva_to_pfn_remapped() Content-Language: en-US To: Xianting Tian Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220124020456.156386-1-xianting.tian@linux.alibaba.com> From: Paolo Bonzini In-Reply-To: <20220124020456.156386-1-xianting.tian@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/24/22 03:04, Xianting Tian wrote: > The async parameter of hva_to_pfn_remapped() is not used, so remove it. > > Signed-off-by: Xianting Tian > --- > virt/kvm/kvm_main.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 9a20f2299..876315093 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2463,9 +2463,8 @@ static int kvm_try_get_pfn(kvm_pfn_t pfn) > } > > static int hva_to_pfn_remapped(struct vm_area_struct *vma, > - unsigned long addr, bool *async, > - bool write_fault, bool *writable, > - kvm_pfn_t *p_pfn) > + unsigned long addr, bool write_fault, > + bool *writable, kvm_pfn_t *p_pfn) > { > kvm_pfn_t pfn; > pte_t *ptep; > @@ -2575,7 +2574,7 @@ kvm_pfn_t hva_to_pfn(unsigned long addr, bool atomic, bool *async, > if (vma == NULL) > pfn = KVM_PFN_ERR_FAULT; > else if (vma->vm_flags & (VM_IO | VM_PFNMAP)) { > - r = hva_to_pfn_remapped(vma, addr, async, write_fault, writable, &pfn); > + r = hva_to_pfn_remapped(vma, addr, write_fault, writable, &pfn); > if (r == -EAGAIN) > goto retry; > if (r < 0) Queued, thanks. Paolo