From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Nick Crews <ncrews@chromium.org>,
linux-kernel@vger.kernel.org,
Daniel Campello <campello@chromium.org>
Subject: Re: [PATCH v2] platform/chrome: wilco_ec: Platform data shan't include kernel.h
Date: Tue, 11 Feb 2020 10:44:13 +0100 [thread overview]
Message-ID: <f23fb55a-dc91-45f4-bbb3-2a8968d4099a@collabora.com> (raw)
In-Reply-To: <20200205094828.77940-1-andriy.shevchenko@linux.intel.com>
On 5/2/20 10:48, Andy Shevchenko wrote:
> Replace with appropriate types.h.
>
> Also there is no need to include device.h, but mutex.h.
> For the pointers to unknown structures use forward declarations.
>
> In the *.c files we need to include all headers that provide APIs
> being used in the module.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
Queued for 5.7, thanks.
prev parent reply other threads:[~2020-02-11 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 9:48 Andy Shevchenko
2020-02-10 14:57 ` Andy Shevchenko
2020-02-10 15:03 ` Enric Balletbo i Serra
2020-02-11 9:44 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f23fb55a-dc91-45f4-bbb3-2a8968d4099a@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=campello@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncrews@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®