From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1F708635D for ; Wed, 10 Dec 2025 00:40:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765327256; cv=none; b=QSNPH6SYGfcXPbf/4kpjFqYxgyy4Y9SLsWZrAusbRsmJKdm7mpfWNWJ44W/FbSp7nL48XLbO6wMsk5VQBnbu2YgvHQo7opQKo1pfaXfTdzwJPGue2GbUVs5LgXKPDvQBg3gubRh9GyTTfk/gPXifXpYNUjIy15dtCRdXc1LWF/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765327256; c=relaxed/simple; bh=hRqNpASOAtV2R6ptGK9ZvEW4iCMGd+z3fowDImWMDWA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iaO75BKAheb31fOIcweEAbNL56r77wVnl3NXY/IEcK/QSrcc6FOqQwOsYKplPtkZjkGGb3/CUnSaiBSB1R+G8XkIC/236HLs9GBL1t+UDSihaEkEQP6+u+56RqgV1mfrg9+iUmdPBCYOD+MEHyj7EIn1gY7kWwwt9D5YfW8ZZ5U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mLNV0SbV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iKRpfrnK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mLNV0SbV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iKRpfrnK" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BA0OTKC1722402 for ; Wed, 10 Dec 2025 00:40:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BjnVilg3abOxU+W32kl7Zz9UhmN4RRtptZxZawb0RM8=; b=mLNV0SbV5szXUHb8 sFRKNF4gb+YP4QUcBvN8zLszGFiF6ddhPWkL1IyjQEiSwjMabC6hb8SNT0F44P3c RZIJ5DtAeuIDsvp/HnwQh0Ch5ckQRsg50whBea6Z6nmRTvxoP9xsqCuCHUfS8xOv J2v7wqlvOFUyDNlg7VLhrxN9Texr+WQyKpLFuxdfdaA9T4dGQwAcBq1R1wfXybC7 nX3HU0MuijUsdlEKnODoSd6i8utlHo0F6mwx4K8NwBQvNFNlsYW8HtfyqiCTqh1q UDCHvJUa+liJLcf7o/tnUsota5CgcIPt/vqj6jexyA+rSdio1bwFS8ZbdsngzWjy UkBSnQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4axqu596rx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Dec 2025 00:40:53 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7b82c1cbfc0so1892075b3a.2 for ; Tue, 09 Dec 2025 16:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765327249; x=1765932049; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BjnVilg3abOxU+W32kl7Zz9UhmN4RRtptZxZawb0RM8=; b=iKRpfrnKevwENNZ2puvrjn/uysF9+Mxd3eNGrBGI0CM45qPPFoMXZkvFQoWk65aour hgHnsTWt1UO4hMTpO9yH8jF+sRx9X4QT4Q4aqfEdxskMxr98QkpMMyOpa+TJixMzczuH PX0sZ2Jq4jVdj9IuXdXWm8621oIBV1/MM8FGl15yl3DRPQIMpCrKYTCxs7y1YvTJ3Vl9 bnr3MLotgnWciUE7ZrWwEc8YP1g3YTtNHy8Hhp0Uc6NXx5YGjxXH5bjJyEDHqQZ0DBzL kkN9rXICJSdQLlkc7J1zvqyXgtDQGyO+yDm/2on9QSf+9GztPeDaqZjL5kT06EnpY7j2 CX8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765327249; x=1765932049; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BjnVilg3abOxU+W32kl7Zz9UhmN4RRtptZxZawb0RM8=; b=Fvk4YuBDduULAlsmxYAW8stTHALtrd1QgZdP0vyWnsXNHZWmQc0KSr3/2aG10UDaOK pVuskoz6LAPoWYRfn8NTME8uLJaaFr762OS67QQezchJktXJg/oXwF23X/gZElTIY95N sGFrroZB6X/hTwm6WGK7WNPB+UqMWLaQzHLAPng7VfR402yZw3aY/NgMdH4k7uGS3kmF Y4RVlENyqEUcJLbeBr8Q+WfpdQWg3gTCMcAOO1ePeSgcRIo4a08p9Kae92MROYmATvii YE+dFQJMrNY/aNtUBR8skyaHCDqR4+jQY2GLzJFtBB2PPoIcsYc0h1yhm4OkhAj+1zXm xIgg== X-Forwarded-Encrypted: i=1; AJvYcCV36MnfcirxogWTXntLsXZ5CQph5bELImQM9wfdqad/2EJjqxCIr//1HXc9pcGDrtS0hocwood8oBYeAic=@vger.kernel.org X-Gm-Message-State: AOJu0YzmID9nzEcdZzJvw24HkMaxMLxfpGhHMFUF9yhGjI3BmPdrh2xK FGfnMWu5pNUDKZjH29JjwEjqgiFF6XP0dyB5ftXuriOGo2weC8QbRk+QzuVo+USRRBjhLNcS3U4 MeKY7F95YDCO05zxgT/939GanaNk4Zv+AoQ87FilPEgqAuiO84cVQ924UqoR+ic2XHxo= X-Gm-Gg: ASbGncssKpz/npx+aW1i62ui6fkRu7+3z5Vlahssni6Rga7RMCyXNNnz2YLnwWEog1n VHCZsDrp4ZbnniAoF0QfmEUtZrfJtbEXxKU0nnmeQjQ+YxPYIe+98XSaVjrBSNX4g14GbCVTKoG DWrOqnPTPmCh6Rq36Xb4wvMYa1KygnKl9giNRHJZMwmyFxY2URGwyyvV07Jl3VCzCfc2Hqb33mY p89KMW71oYdOx9qFUTqNLOP4UjQF3xtSVbppQrV/ALf2b+hm15OYVjwQFjnPmz/eJh2zacm0GP7 1JlRm6PcxOvFwtwKgRtsUoE5o1f1T70e4N4cKCScO6KSAeQyQAp0GPeKbUrsW1gm/IKOZcKHKgk 6ptJVyLXHAFMb/jxpffdmFQI0Ln63Yu2A/7pitFM+vZ63kjq/wj/Kskl37hWoz5J7vxN/Z3Qs X-Received: by 2002:a05:7022:3847:b0:119:e56a:4fff with SMTP id a92af1059eb24-11f296c903fmr233605c88.4.1765327249117; Tue, 09 Dec 2025 16:40:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IG3vRJ01ZpoagUST265v0ky1EHBQYobOKV+8HlnSsbYXPe/btZXA+y41v0dTaTn5L8mbxA7qg== X-Received: by 2002:a05:7022:3847:b0:119:e56a:4fff with SMTP id a92af1059eb24-11f296c903fmr233585c88.4.1765327248516; Tue, 09 Dec 2025 16:40:48 -0800 (PST) Received: from [10.110.63.171] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11f283d483dsm3848764c88.15.2025.12.09.16.40.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Dec 2025 16:40:48 -0800 (PST) Message-ID: Date: Tue, 9 Dec 2025 16:40:47 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 3/5] media: iris: Add support for AV1 format in iris decoder To: Wangao Wang , Mauro Carvalho Chehab , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel test robot , Bryan O'Donoghue References: <20251202-av1d_stateful_v3-v8-0-2f74a81773b4@oss.qualcomm.com> <20251202-av1d_stateful_v3-v8-3-2f74a81773b4@oss.qualcomm.com> Content-Language: en-US From: Deepa Guthyappa Madivalara In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: gstkNw2wFMagsK0gn6_-BueJdI1ZAvLq X-Authority-Analysis: v=2.4 cv=Y7/1cxeN c=1 sm=1 tr=0 ts=6938c195 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yLxqPbnFcNyJ_sgzbz0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: gstkNw2wFMagsK0gn6_-BueJdI1ZAvLq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEwMDAwNCBTYWx0ZWRfX98hZazlMOGRN pxDSaxtFtMrR3YD+NFSoBnKUVdDbLTZUwKXlgk6W4kSFYacFnnh0XEhUItWEUrx47jjmE4ISJoo FdWP+leuEh6dsYAzrUJy47xwkGldRrRjYFxWmlnviVgKbbPI9CSE8EcKBfDBw9YL9xldAYu8fQB /4G83XLEaki1xwdzFPYn74NWXprULrUzG6tUE3RMl98b5FLpWDKyRvwXHf78DC/dzLUK7qPjzDs x9sRO5rb54z9KsKglBmRGVXGjUg0tt8qlyz5AW27gtFxrXNN4lzbp99D/BS6M7AppuIKSemY//b M3jYarrUE7CcYaTBZtPE7fAqUU91GkygamH62fHBOVrmJ5zZQ3VdbpOhoNNvG2w43LgU8ZKX17l SLA64ycMYVrdHnj/YAt13Nq+cuoHKQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-09_05,2025-12-09_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 priorityscore=1501 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512100004 On 12/8/2025 2:51 AM, Wangao Wang wrote: > > > On 2025/12/3 7:03, Deepa Guthyappa Madivalara wrote: >> +static struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = { >>       { >>           .cap_id = PROFILE_H264, >>           .min = V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE, >> @@ -759,6 +778,8 @@ const struct iris_platform_data sm8550_data = { >>       .dma_mask = 0xe0000000 - 1, >>       .fwname = "qcom/vpu/vpu30_p4.mbn", >>       .pas_id = IRIS_PAS_ID, >> +    .inst_iris_fmts = platform_fmts_sm8550_dec, >> +    .inst_iris_fmts_size = ARRAY_SIZE(platform_fmts_sm8550_dec), >>       .inst_caps = &platform_inst_cap_sm8550, >>       .inst_fw_caps_dec = inst_fw_cap_sm8550_dec, >>       .inst_fw_caps_dec_size = ARRAY_SIZE(inst_fw_cap_sm8550_dec), >> @@ -851,6 +872,8 @@ const struct iris_platform_data sm8650_data = { >>       .dma_mask = 0xe0000000 - 1, >>       .fwname = "qcom/vpu/vpu33_p4.mbn", >>       .pas_id = IRIS_PAS_ID, >> +    .inst_iris_fmts = platform_fmts_sm8550_dec, >> +    .inst_iris_fmts_size = ARRAY_SIZE(platform_fmts_sm8550_dec), >>       .inst_caps = &platform_inst_cap_sm8550, >>       .inst_fw_caps_dec = inst_fw_cap_sm8550_dec, >>       .inst_fw_caps_dec_size = ARRAY_SIZE(inst_fw_cap_sm8550_dec), > > I noticed that you didn’t add inst_iris_fmts to the platform data for > qcs8300 and sm8750, which will prevent the decoders on these platforms > from running. Done. Thanks for the comment.