From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752847AbdJKPcz (ORCPT <rfc822;w@1wt.eu>);
        Wed, 11 Oct 2017 11:32:55 -0400
Received: from mga01.intel.com ([192.55.52.88]:38217 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751746AbdJKPcx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Oct 2017 11:32:53 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,361,1503385200"; 
   d="scan'208";a="137485137"
Subject: Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements
From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: Thomas Bogendoerfer <tbogendoerfer@suse.de>,
        Mike Marciniszyn <mike.marciniszyn@intel.com>,
        Doug Ledford <dledford@redhat.com>, Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20171011144134.c6bba480faee444cb9881710@suse.de>
 <1d7e8d05-9a6b-6dbf-d528-41ba64129348@intel.com>
Message-ID: <f24cdc10-1140-037c-b2e6-fd837fd54e4e@intel.com>
Date: Wed, 11 Oct 2017 11:32:50 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1d7e8d05-9a6b-6dbf-d528-41ba64129348@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/11/2017 11:31 AM, Dennis Dalessandro wrote:
> On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote:
>> Provide information about used firmware files via modinfo.
>>
>> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>> ---
>>   drivers/infiniband/hw/hfi1/firmware.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/infiniband/hw/hfi1/firmware.c 
>> b/drivers/infiniband/hw/hfi1/firmware.c
>> index dee3c674f33d..f56ace76b42c 100644
>> --- a/drivers/infiniband/hw/hfi1/firmware.c
>> +++ b/drivers/infiniband/hw/hfi1/firmware.c
>> @@ -70,6 +70,11 @@
>>   #define ALT_FW_PCIE_NAME "hfi1_pcie_d.fw"
>>   #define HOST_INTERFACE_VERSION 1
>> +MODULE_FIRMWARE(DEFAULT_FW_8051_NAME_ASIC);
>> +MODULE_FIRMWARE(DEFAULT_FW_FABRIC_NAME);
>> +MODULE_FIRMWARE(DEFAULT_FW_SBUS_NAME);
>> +MODULE_FIRMWARE(DEFAULT_FW_PCIE_NAME);
>> +
>>   static uint fw_8051_load = 1;
>>   static uint fw_fabric_serdes_load = 1;
>>   static uint fw_pcie_serdes_load = 1;
>>
> 
> I don't find this terribly useful, but if it's useful for you I'm sure 
> it is for others as well, so I have no problem with it.
> 
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

Although you may want to change the subject from IB,hfi1 to IB/hfi1.