From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EF21455185 for ; Fri, 11 Sep 2026 11:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789127860; cv=none; b=k/KMFatk910FNb5E354KbxJ9JAfXOwjWZhWzb+FQjVuDvGlf/9J7god9+U++gCAqGqQHmaRx/mdyX8alC2CbTozZu2RXay1EbTtde1iF7cPwf7Ne+j8nGnZJcw2QiAzkAUt41lXaK8P9ztCA6zwhBgdS/YfxqaG/xrYJQnSTHYY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789127860; c=relaxed/simple; bh=1lRC8ZGjaJk1CFMMkFB+zwt0ch81ggJd9O2XFlK/4VY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V3T6JyUhl1123WWWhhVSYVIwWzUYvDjbEoVoeRqzPjFQLHcnRRePqixi9nqaIH3SW73NNH6+MlBbd/hpcUPlh/suTX8jUTWGJVdLgBg0zeN/jAsMyIZ0wwCzD7gjvtSG9A2fzX0TF64TanTymD+kQbmvxmSWry00YYQd2S3GObA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=cUBzSOOU; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="cUBzSOOU" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-4843f205a5bso549105f8f.1 for ; Fri, 11 Sep 2026 04:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1789127856; x=1789732656; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wr7n2cO3L1gr9+vq7aPZsfQwfFiNJgEahYqoxuJotBY=; b=cUBzSOOUwzzqxDC+vpZBsvPZyne0rSo5Iv2fNaVmgBjouOyMtE6UfB8G9bsZefMktB dKs9pIMO+8B2F/GdHaOaMo+0h27j493jL7A9DkGlrh+J4/dzg7ykHEZC3tk9SY/s+s/I PU7xVdgEwQl+Eub1RVsJ6h7b40tYHFZ348G5S6M87Y7vJtLwcIIMWc0xJPEnLSZqE5iA pdnpef71I1Yn3dDf8LEQJ62R/6BKeuzVwbDmgxAlkDnt6eF0//hs6KPBH1FRNCgaNXRc pHzjD/fabk+Jsz7S5C+O491YMjAc9M6HMloUkXdPBUWgTiodBv+UX9UObFCTEW7lv2vt nkXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789127856; x=1789732656; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wr7n2cO3L1gr9+vq7aPZsfQwfFiNJgEahYqoxuJotBY=; b=JK0cwEG/r/bkmcG78q0Fyw8wuCiW7PR5KJFWR9+Hzym33e85wtka0vvzMdjwrUPsft hRdT6FMLwGJor9HmjG+57HsuEaibt6DSlAgT8XI3ejgeyNH/ofzBBKdeeJyhGUY21CRN smGUlT6waftT5Nz8auf9ID7oEkErajC4P081lnK79Bd4blLF+9wIgZ0vVOVgRQXmYhxJ QGrX+GlCPmZVfOGyNkLQCW+sJ75x/oAc1WSDWBYZGaxVBQxfv8BIU7VVLy47fzvqy6OJ TI56vJzfYrlRdMIPPv1qmtN8r1L335g3B9qNiCbA5ZgR90wSktTqhmPW9Ve0i6Yo0VB4 DwHA== X-Forwarded-Encrypted: i=1; AKwUvBw0h56uWTntQ+ESALYpwD3hBVWWOumaslAEEEnSFNUy+/JRU9zzdXfSkmPc/aw63KjahujOTp1CWuQ8ZDI=@vger.kernel.org X-Gm-Message-State: AFuF++kS+SeNs93bFbwdWfMb4k1DQdZPHb3pXmhHl7HL4wf83mJN7yyJ 9Eb6krg5qKXLOOhEEAQqA0Z+HPrZ9HLFqzh0bGEulf1FaOcB/wP6XG3i5DocS2QnP0I= X-Gm-Gg: AYBFou0rEtU6mk3HodB41UPsQ1sii+ws+WgsSmXnwrw/WDyrt0ejeb6/k+v+3Mi6xPi a8me1x5qOh6/pIa/N5C+rsKk89rcu42wFGo1j1rKLZkz7wFP4iF9kRLSxw5yY+oyxrrhx4RGl8T z8aMB1XyrNFMKJPJhPpc91J94rHjkeRrjlJBBYWmrLjKppJSddOB52aHXA9iDU7Omf+59n5N8sN /3z/BEbV/DlNR9KW20nbvJ6bXWr5Jz7yYkFwMs3syDsMAMlLf9pqmWWq9KeN+rKzcD/szqfjJfK 9iuTzxiIprBGIgYrknVYVt1G6BKgRJiPQGbkHCjCCOYQp40GLUU9X+TWwAaZ1BQ09N352QsVeW0 xRUY0oT9xdXvwKsNEtQdKv5PtvZ9QxMDHfRoAItl8AAi6+8A3C6eSu3+izUZJntZUemY5gpRssp yYsEPEd0c8dQaZtT4fbZC6CgIMXvf27HJq6k4u0m6oVjr+/BEPJXYQBjHmNZx5DuMolFXJwL8h1 v5sc1vHmhEg50zY9nOnf356jqieb96LTBjg X-Received: by 2002:a05:600d:8496:20b0:499:8aff:59b6 with SMTP id 5b1f17b1804b1-49e6199234amr30006585e9.14.1789127856324; Fri, 11 Sep 2026 04:57:36 -0700 (PDT) Received: from ?IPV6:2a07:de40:8100:0:89a9:fd0e:583d:4a53? ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d26c300e2sm164777985e9.8.2026.09.11.04.57.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Sep 2026 04:57:35 -0700 (PDT) Message-ID: Date: Fri, 11 Sep 2026 13:57:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/23] modpost: hash module source per-file, not per-byte To: "Lorenzo Stoakes (ARM)" Cc: Linus Torvalds , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Masahiro Yamada , Alexey Gladkov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Arnd Bergmann , Catalin Marinas , Will Deacon , Mark Rutland , Ard Biesheuvel , Ilias Apalodimas , Josh Poimboeuf , Peter Zijlstra , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?UTF-8?Q?Onur_=C3=96zkan?= , Jonathan Corbet , Randy Dunlap , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, Jens Axboe References: <20260908-build-speedup-v1-0-5dc1ac01672d@kernel.org> <20260908-build-speedup-v1-13-5dc1ac01672d@kernel.org> <434a7a10-d83e-4402-be91-816bbbc15bb7@suse.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/11/26 12:41 PM, Lorenzo Stoakes (ARM) wrote: > On Thu, Sep 10, 2026 at 02:52:50PM +0200, Petr Pavlu wrote: >> On 9/8/26 10:55 PM, Lorenzo Stoakes (ARM) wrote: >>> modpost spends a long time md4 hashing module source at a per-byte >>> granularity. >>> >>> Fix this by doing this hashing per-file instead by accumulating a per-file >>> buffer in parse_file(). >>> >>> All 11,189 .mod.c files and Module.symvers were confirmed to be identical >>> with this change applied. >>> >>> This is especially impactful for allmodconfig incremental builds (where >>> CONFIG_MODULE_SRCVERSION_ALL is set). >>> >>> Whole build, 128-thread Threadripper 9980X, best of N runs: >>> >>> before after delta >>> ------------------------------- >>> x86 allmodconfig, touch mm/vma.c, gcc 40.6s 38.2s -2.4s (-6%) >>> x86 allmodconfig, touch mm/vma.c, clang 36.2s 35.0s -1.2s (-3%) >>> >>> Assisted-by: LLM >>> Signed-off-by: Lorenzo Stoakes (ARM) >>> --- >>> scripts/mod/sumversion.c | 56 +++++++++++++++++++++++++++++++++++++----------- >>> 1 file changed, 44 insertions(+), 12 deletions(-) >> >> Support for the module srcversion is being removed in "module: remove >> MODULE_VERSION() and srcversion" [1] and scripts/mod/sumversion.c should >> be gone completely. > > Hmm, that series doesn't remove the script though, is that planned as a follow up? My reply to that series [1] notes that it should also remove scripts/mod/sumversion.c. It should be done in the next version. > > I guess I can drop this patch from the series then :) Also patch 17 I think? I agree. The module srcversion is no longer needed since build IDs are nowadays the standard mechanism for providing effectively the same functionality. While I'm not sure when the mentioned removal will land, reviewing and polishing this patch and patch 17 would IMO be wasteful at this point. [1] https://lore.kernel.org/linux-modules/4e321525-708c-4964-9937-d94ea27e8d85@suse.com/ -- Thanks, Petr