From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D16633B05AA for ; Sun, 2 Aug 2026 13:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785677423; cv=none; b=lSyN6f3djyzcb3tIoqxLsja65Yereu9K9Tgi+1kgNct2MckgOzio97zNLUXYXe2nyq1zMQXMjy5tuyX1HkxEyeKYh8RWi6VZ1+Ym9ZYS8ShQsWxeZakJDX53D7W3aUjeGg2FKbHQ1v/dCEM5ddbZPC1WMdXcrFrFy0v59WwEdME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785677423; c=relaxed/simple; bh=6+MsTxqLn3+j1CNnnq7//8dYOGO2DnYXhvIoC/Ul9lI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b38zuvgv41KAj01gX5YXFkR3BAZDNWnbXhd/StdxtIZE5tJsOz9ndaignNJx8yB27VDpm1BSJakcdduCJQ3WA/m7BIp1qwX2kNE2vjBI10p7B3a2nq9spq90QEk5Z6RzjMTBsHEWpGrJo+kT0u+FY/30EXNI6Yi7T+qA+5wVwAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AJek9/6i; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LkN9pVOU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AJek9/6i"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LkN9pVOU" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 672B6cjx2009737 for ; Sun, 2 Aug 2026 13:30:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BH01Edhq/ypeap0BG3p414W44OzHwtPMsqAEhHXxmkw=; b=AJek9/6iqVZvx/Bm cPQhMoV78fr4rY2+r0+SjBgKb7ErfWC/EgzBVYUNEnwd+W2aP7pMBBbinn19o5pR AF3LjtMxXawtKeqyK/BGOMj2CyUmmfW07zSgOEF0c7a83Tlci244B5EPZiqbieFs Fr2/MhDRVHcmFiKi7H0otfsJHV/dGzTr89OY7Hnv4+BNGRNJI7YuN2V4VUOJjb86 8SNeenjNEwwt/Rfrmh1scLMrtrem3HdjfwqAN9oXACEhqq/O/mDnnkbRKVXNbTWM uFlRiVwdSVvQWL2yOJeJun7NaBHbLHF0x6I9QzJ8SPafumPXbu9MEjhTPIYDxjSJ PN9zdA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fs8qptvm0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 02 Aug 2026 13:30:21 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1eb52e1fso44838941cf.0 for ; Sun, 02 Aug 2026 06:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785677420; x=1786282220; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BH01Edhq/ypeap0BG3p414W44OzHwtPMsqAEhHXxmkw=; b=LkN9pVOUvstzQuP2MEQ06GcLP3WBx3kKXeEIlbg+kXyQyoYAtiaORBhyRp02H5cCJN 8EE8rYH8l4s2uTYMdccwB9IM+CCm1Cya1JNnoV/e0G/94Cplyv9K0IgZ5F+uA4e+8vHq f66c7tVgZQFAR6SpEVSg1AW7j8rX4qL+iwIsaotuUvpUPLBk+QTBaQ6vLkeTHYs8GO8D 4QsDGTrP/vvbwrqPZ6ia6ovpkqjoJcngVXw86p7kG3r/HKghV/Mc5tXIMIf/lP5QqWt+ WUQF7rnlejKM9XHmFLaOccrD/K1xDkos6PbXpOXREOmmW0EULJ3rBaL5SyZKAoLmOdaz /QcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785677420; x=1786282220; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BH01Edhq/ypeap0BG3p414W44OzHwtPMsqAEhHXxmkw=; b=R6mr4k9UXS6C6vK+vZ6pHIFPk+vzmmQxfI1xO/5xZ0EY+u5jyZeSYNg4+F6rZnHgYH tMSoyMAwRiRxGGtqdvt7Wm8l/vBc1VAvUcsHMBPeLTAGOQ7YDgXxsmjOeyRt4UyW9GtC L7UpS9o4ZzWA4TJbKqkNvcCzP+UoVRvlpf7doFVqqNjviObHKkPkzKzX5y0VBW+qb3ri R2L/y4g1AQzGkXJWOb8icg5vNK1tYWflgpzyV6/ZuIKve53SC/gY7+Fdvosq1tehVMM8 iMn5jQP14bJfevrmx4StNWNBlPK2DpEZEornBoXYY5MoCflzePoiixhaJXpBHzMJvyfE 3PSA== X-Forwarded-Encrypted: i=1; AHgh+RpYwBGW28cfItWmIvNdL4pY4iyKkteyPhU+f/+nIN+DnzaE3iinif2o2+telrmx9BNxaOdkmxDxnwkCPdk=@vger.kernel.org X-Gm-Message-State: AOJu0YwzyAG4zRKQWkliNEjncb3iW9Oqn8zbbG3q7Rie7hWRLANlffX6 eUs23HsZNZ+Z4MD3rKzd+txoea/buGZPw95gMhN4QTiZshMo3FEOy3fqHul3xzCRBOTD8IdwnTB DmlPZ3R64EXzISLIEFGDFNP2OVmRfOjziTFW+4yWweHEF3E45/KQvmrHVVUPQs8zywYM= X-Gm-Gg: AR+sD1083xk2NVThCjasw3R/L6nLhduvGsW4fta+N+j3yQlz14bt1T3KH7QdvH5B5/v gNRZUPd35KxTaBiSaKmFrdGA6vRN4uYhb/GFNlWnQQox5/uJytqMVoj3i7LeZP4Ya4l4mizDAeT LEJl1t2p8jjzExMC0scQ5OgWymBAgtrg+wTBV8C6TehZ+Sn0IBNf5HTFG8qbk2PD5PZfvtCepB7 +ScIZE8jUSso1kCqUA5z98N5V7EKQt6KIPliQ1y+VdSbzP/DiP9asW56vS5sMXKPrgK8fIpipO6 KNTcasIcVJrA7iTLJ0+qeQHJJHNDM8XQ3qkp+JO7gpmVv0h/bZvj0blykrDT3BBxF1nQXA6ebDb 0HDW6IylNreUWH96bjwA2csS6+uE= X-Received: by 2002:a05:622a:230a:b0:51c:8571:1ccc with SMTP id d75a77b69052e-52b567f2645mr142671841cf.41.1785677420040; Sun, 02 Aug 2026 06:30:20 -0700 (PDT) X-Received: by 2002:a05:622a:230a:b0:51c:8571:1ccc with SMTP id d75a77b69052e-52b567f2645mr142670611cf.41.1785677419490; Sun, 02 Aug 2026 06:30:19 -0700 (PDT) Received: from [192.168.68.104] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49808690ffbsm157118855e9.10.2026.08.02.06.30.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Aug 2026 06:30:18 -0700 (PDT) Message-ID: Date: Sun, 2 Aug 2026 14:30:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/7] dt-bindings: sound: qcom,q6dsp-lpass-ports: add Audio IF clocks To: Prasad Kumpatla , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260801054610.4047089-1-prasad.kumpatla@oss.qualcomm.com> <20260801054610.4047089-4-prasad.kumpatla@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20260801054610.4047089-4-prasad.kumpatla@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAyMDExOCBTYWx0ZWRfXwXXvF5w8dukq OTXzklyr3PP8QDaohf3VXOadRg4pX3SPKytf/AhvYT8BJ/h7LoKn05IQwyHdzyiNn2lARf4Y2VQ lfSIchMDpToyza6kE/9wydGqa35J0idBVXLrw7OmrJS6qgnz6fXJBTsERuqoBxnSkEtN66HoX3A modhj/U5E7lD4RV2n2Bm0mNPruoMHrreP8mhHmd9MXLYwjtnHn6S+6+4AgcNKBe8YQdWkVx/vO/ ivt9hLUN41jxxUHCpJLAulRyjh0px6NEYDexPe74CQ27GmLl8rmogwpYqeRdEoylKx7/7CcNt/u oF1/DtjZT16n1ntvvOPhn206SpDWWlhTgfcrTH5dJC733wtc5SNYNJ9214kfhi7sziAoy6GAwqt BzyKna+YSeKgTOOey5hUo3nO1Y7MwOSZWfm50SNNycvlfXnImQPjaP4JWyT5259QL0rgvtezuwP P4x13fn1kLqmug/nFYw== X-Proofpoint-GUID: fnsAHLTtkFhCt_a9-l_tHzJHsoTsEwaZ X-Authority-Analysis: v=2.4 cv=MpViLWae c=1 sm=1 tr=0 ts=6a6f466d cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=S0i2IUftuXgoZizot94A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: fnsAHLTtkFhCt_a9-l_tHzJHsoTsEwaZ X-Proofpoint-Spam-Info: AW1haW4tMjYwODAyMDExOCBTYWx0ZWRfX2PdfXU3orHJ8 ygH6CXe5+jg5HP6Uq3NFwxkUEUPkGbAWRk5wF/PyWk6MxmzzfW3pUP0HRDc8tE2mVV6i8sAwsl0 CRjfFixOoJpZbm3H+np+JVQIFEgFxlo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_04,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 phishscore=0 malwarescore=0 spamscore=0 adultscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608020118 On 8/1/26 6:46 AM, Prasad Kumpatla wrote: > Add the LPASS Audio IF clock IDs used by newer backend interfaces. > > Platforms using Audio IF module backends request the interface bit > clocks through q6prm. Add the Audio IF IBIT and EBIT IDs to the binding > header so these clocks can be referenced from device trees. > > Signed-off-by: Prasad Kumpatla > --- > .../sound/qcom,q6dsp-lpass-ports.h | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h > index 7b553a73bc92..fbcf1ef9ce22 100644 > --- a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h > +++ b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h > @@ -233,6 +233,35 @@ > /* Clock ID for RX CORE MCLK2 2X MCLK */ > #define LPASS_CLK_ID_RX_CORE_MCLK2_2X_MCLK 70 > > +#define LPASS_CLK_ID_INTF0_IBIT 71 Patch itself looks fine for me, But the naming seems to be bit odd and misleading, what does INTF mean is it QAIF or some other Interface. Please prefix the interface name something like LPASS_CLK_ID_QAIF_IF0_EBIT or LPASS_CLK_ID_TDM_IF0_EBIT.. etc. --srini > +#define LPASS_CLK_ID_INTF0_EBIT 72 > +#define LPASS_CLK_ID_INTF1_IBIT 73 > +#define LPASS_CLK_ID_INTF1_EBIT 74 > +#define LPASS_CLK_ID_INTF2_IBIT 75 > +#define LPASS_CLK_ID_INTF2_EBIT 76 > +#define LPASS_CLK_ID_INTF3_IBIT 77 > +#define LPASS_CLK_ID_INTF3_EBIT 78 > +#define LPASS_CLK_ID_INTF4_IBIT 79 > +#define LPASS_CLK_ID_INTF4_EBIT 80 > +#define LPASS_CLK_ID_INTF5_IBIT 81 > +#define LPASS_CLK_ID_INTF5_EBIT 82 > +#define LPASS_CLK_ID_INTF6_IBIT 83 > +#define LPASS_CLK_ID_INTF6_EBIT 84 > +#define LPASS_CLK_ID_INTF7_IBIT 85 > +#define LPASS_CLK_ID_INTF7_EBIT 86 > +#define LPASS_CLK_ID_INTF8_IBIT 87 > +#define LPASS_CLK_ID_INTF8_EBIT 88 > +#define LPASS_CLK_ID_INTF9_IBIT 89 > +#define LPASS_CLK_ID_INTF9_EBIT 90 > +#define LPASS_CLK_ID_INTF10_IBIT 91 > +#define LPASS_CLK_ID_INTF10_EBIT 92 > +#define LPASS_CLK_ID_INTF11_IBIT 93 > +#define LPASS_CLK_ID_INTF11_EBIT 94 > +#define LPASS_CLK_ID_INTF12_IBIT 95 > +#define LPASS_CLK_ID_INTF12_EBIT 96 > +#define LPASS_CLK_ID_VA_INTF0_IBIT 97 > +#define LPASS_CLK_ID_VA_INTF0_EBIT 98 > + > #define LPASS_HW_AVTIMER_VOTE 101 > #define LPASS_HW_MACRO_VOTE 102 > #define LPASS_HW_DCODEC_VOTE 103