From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B08D61DDA0C for ; Sat, 14 Jun 2025 18:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749925938; cv=none; b=b4sOr/uGDyh38oeL8rwtL03jCo82ilNi4oByJjvFYsqHDv0uCFpz1u+2o/go1VezFjLseLOAegZC+aiFwe8h74xRgWBfEqN9qgLsC3QPCVs2hdYSwJ38TEN7y+EegM26HwFyJkVkVwfS0SaX7NTpHlCPMslTqXEzpYosq1PcmJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749925938; c=relaxed/simple; bh=0kLZe5y0ZyrzqmqIFyXSqU7kHqgyABQHfGDybgVEDg0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E09RugoGkvnEBGkfcVlnL1ONZVOpvHaT+TjWHeqDzXiiepOTKp1s00uMFC7ZVEunegWDpWMLymDotj1oqNbM2VV4JkJcuuJNZCExoLEeegS5YY2CAlR+5muSg03y6+weuRK2iSpz/17ry6uaR8PrQ+lFVi6mv+OvrLZ9EJ3Irow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BNhFgEV1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BNhFgEV1" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55EHvI9w014758 for ; Sat, 14 Jun 2025 18:32:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6zjr+jyjGQmEJbKPCSARJJf8FzsrLtcURjCMxa5yFJo=; b=BNhFgEV1DRuBuTHE 6B1SV6A+h+z/H6wjjkg0th0K/jIYdABdyQV2ddJw0B+FE+F01XpffKkk+ExiCn/V xy4vQG1wbLsGWIkeLD4olS+TK+SSR1womDcXHPjceX399Ifc048+3Dhips1yrGfA +w29qrRfomzYljHYu3mAed7X8N2JSH0Ptsb8Rl4JCE7U6ow4Peu5VSf+n4HMycDH LXih52dXaTVu8OcGtHMDUYcp2R9fDeLQPHHJ4jpZnaBEnHqe26SJNCycpJAl6Ncx 08MvyOjJaZPOxFQfERiw7bxvikHOvLfE5p39ZWcRjo8ZHg5slcmfFvZhzAwte/oG yvIStw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4791ug8usj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 14 Jun 2025 18:32:15 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4a5832bdd8dso6714891cf.1 for ; Sat, 14 Jun 2025 11:32:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749925934; x=1750530734; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6zjr+jyjGQmEJbKPCSARJJf8FzsrLtcURjCMxa5yFJo=; b=oPYr1+6MoOY6Hj7qwLxw/A1XYvK0G7Zfv8AGVWsonLcJyrVMQoQTpKfMHRLesIodoq uYFUANGQ4Ix5qaBO74aMzsCAe10Xx6nf5JtCPAooJdvJSuj3C9Da1hMktI5+VvTPjm+8 EIatcnNUtCx9zsooJH9ArvY56GslxnETbp9Jk1yqgugA7C9QTUjvUuLSFaZsOfWk9MBp XW/l6X8+qIXIORJNOe8E6D34nZl0bG4BwFCpDr+NTXSCq0vnUuVQ0OHWzkKH2reMjWAz duGGJP3C8SGPiXsh1Gq4FrR1kXcyvn2NAPfL/r+4ANfbkn1Di07pVIq3SdGNGhqDb7cO UDcQ== X-Forwarded-Encrypted: i=1; AJvYcCXjs2G40kn3PiWAaCUCf9wPJj7PVJ90ATlet56XsItn830WvPfEkj8nN8qsEnYwl9wdTmOM3naBFDyqPY0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywk7/nPUk//V9z5Iw8dhA3GIrpDOwqMuy8Vr3mnl/9gtV749Ebi r1ACIJTZ5BFhver9t4jFsMHyb8N087lIjzTbopCbvtAL4M6Je5Z5wH9Jyms7IV9tL5rSlFOwj4w MTnFILNAodX6bXTsXR3YpH+rl4/oZAsECpeAG6b2xcQdtRRPP6QKs39AxGWXX7gnfecw= X-Gm-Gg: ASbGncsEK4pyk8PkXqxTSdxr8x5g/tOlLDDiIi8dDe7wkRlLbm1SPXx2z06bBvRwABA 7jd3xqRV6gQt/k49W9UVN7xETAxqTJheol64YK9KvgVayI647i9ylCvxzgBR7SEAOUBnccLNuXt 0kogJDzHvar7b0HEQ2VJs5cqccHVp8xp36fE7xb24qSgB78Xvr0wnlkLE6yvDN0z0cRLLCb+/M0 nqY2R1ThKBYWAqV+J+Am6FBBZ7lD13RL36naPOa6QL7qFxau4fO/Z5AiZSZ3oBR35M5FKmocnUc i7VkVYwpctROpn+24ANkuJSN37vw6MT2zodeVvvz2KePY6jArZdS4BygaWXBlT4efaO/AqNZp4v TcAo= X-Received: by 2002:ac8:5e53:0:b0:4a4:3087:6cee with SMTP id d75a77b69052e-4a73c6535fdmr22676141cf.15.1749925934437; Sat, 14 Jun 2025 11:32:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHjnXi4LOAlGNITRHE+D0Vz0y+jMvb4gMS3dWcaYwtLxZUeHDyVtPykLidKSxscG3bnnLZpAQ== X-Received: by 2002:ac8:5e53:0:b0:4a4:3087:6cee with SMTP id d75a77b69052e-4a73c6535fdmr22675891cf.15.1749925933787; Sat, 14 Jun 2025 11:32:13 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adec81bff9fsm350710166b.52.2025.06.14.11.32.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Jun 2025 11:32:13 -0700 (PDT) Message-ID: Date: Sat, 14 Jun 2025 20:32:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] ARM: dts: qcom: msm8960: add gsbi8 and its serial configuration To: Antony Kurniawan Soemardi , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Max Shevchenko , Rudraksha Gupta References: <20250614-msm8960-sdcard-v1-0-ccce629428b6@smankusors.com> <20250614-msm8960-sdcard-v1-2-ccce629428b6@smankusors.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250614-msm8960-sdcard-v1-2-ccce629428b6@smankusors.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE0MDE1NSBTYWx0ZWRfX487epbTQZESN oYT+UJR3AFrpWgTYrgqsaM+DD+N/QVDSTHULhZysWkj73LzY0q6OEoXDxjWQ+4aOC4rqIcfQgVu iXgSAC2QEq+YnDjBYTb1WxU/QKSse1nPxq36XLzj+X/INWsAZ1bfMmdLYDO8xmAgrwbraB0R1dV srFa40x4sGiiMyJvD5NQcxJV9fgmAU2Bz4mphh4ueLhEN91Wgg1ZbnyT7Bo/bVF0xj01t3bSXxk eCMbFtVNP+AEJ51ELDjVGwqDBIiJcJmHv39H0ymy4JH6ESSa6ldqg1bJ8zMtgmaNoLkFNA6BhdO RPgHZWhR6Sq6dH0PsFp74SlW7Ufo/jzJjP7miNVM8Zcn4bZDgs6zkT69t3LObg0Iriq1UIPYYN5 v5iR7GQ57McNAhixnqTSLw1GQG4Va6UfvQTmii5DgGwSfir51NKddjtupG8wT7WHLDqgZWIl X-Proofpoint-GUID: XoLBGrKRP2Fbxl4vIihcaDIg23NPXfhj X-Authority-Analysis: v=2.4 cv=NtnRc9dJ c=1 sm=1 tr=0 ts=684dc02f cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=wxLWbCv9AAAA:8 a=EfQDsuKygrJdTQcVXAAA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=QJY96suAAestDpCc5Gi9:22 X-Proofpoint-ORIG-GUID: XoLBGrKRP2Fbxl4vIihcaDIg23NPXfhj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-14_07,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 adultscore=0 clxscore=1015 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=999 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506140155 On 6/13/25 7:50 PM, Antony Kurniawan Soemardi wrote: > The LTE variant of the MSM8960 SoC has a gsbi8 node used for the > serial console. > > That's if the downstream kernel is to be believed, as Xperia SP has > a serial console on gsbi8 even on the non-LTE variant. > > Signed-off-by: Antony Kurniawan Soemardi > --- > arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi > index 4babd0bbe5d638b228e05cdfe6b068b4ea16335f..66071ad498e49c4f54ba105fa94640575fe08da6 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi > +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi > @@ -333,6 +333,30 @@ gsbi5_serial: serial@16440000 { > }; > }; > > + gsbi8: gsbi@1a000000 { > + compatible = "qcom,gsbi-v1.0.0"; > + cell-index = <8>; > + reg = <0x1a000000 0x100>; > + clocks = <&gcc GSBI8_H_CLK>; > + clock-names = "iface"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + syscon-tcsr = <&tcsr>; > + status = "disabled"; > + > + gsbi8_serial: serial@1a040000 { > + compatible = "qcom,msm-uartdm-v1.3", "qcom,msm-uartdm"; > + reg = <0x1a040000 0x1000>, > + <0x1a000000 0x1000>; This is way off - please make sure you editor's tab width is set to 8 and align the '<'s > + interrupts = ; > + clocks = <&gcc GSBI8_UART_CLK>, <&gcc GSBI8_H_CLK>; > + clock-names = "core", "iface"; Please also keep one entry per line, '<'s and '"' aligned. I know it's not how other nodes do it, but this is an old file Konrad