From: Juergen Gross <jgross@suse.com>
To: Jason Andryuk <jason.andryuk@amd.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
Jeremy Fitzhardinge <jeremy@xensource.com>,
Chris Wright <chrisw@sous-sol.org>
Cc: stable@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] xen/events: Update virq_to_irq on migration
Date: Tue, 2 Sep 2025 15:37:01 +0200 [thread overview]
Message-ID: <f251c17f-7500-4c84-a796-4ea7fc400bf7@suse.com> (raw)
In-Reply-To: <20250828003604.8949-4-jason.andryuk@amd.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1006 bytes --]
On 28.08.25 02:36, Jason Andryuk wrote:
> VIRQs come in 3 flavors, per-VPU, per-domain, and global, and the VIRQs
> are tracked in per-cpu virq_to_irq arrays.
>
> Per-domain and global VIRQs must be bound on CPU 0, and
> bind_virq_to_irq() sets the per_cpu virq_to_irq at registration time
> Later, the interrupt can migrate, and info->cpu is updated. When
> calling __unbind_from_irq(), the per-cpu virq_to_irq is cleared for a
> different cpu. If bind_virq_to_irq() is called again with CPU 0, the
> stale irq is returned. There won't be any irq_info for the irq, so
> things break.
>
> Make xen_rebind_evtchn_to_cpu() update the per_cpu virq_to_irq mappings
> to keep them update to date with the current cpu. This ensures the
> correct virq_to_irq is cleared in __unbind_from_irq().
>
> Fixes: e46cdb66c8fc ("xen: event channels")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
prev parent reply other threads:[~2025-09-02 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 0:36 [PATCH v3 0/3] xen/events: Fix Global and Domain VIRQ tracking Jason Andryuk
2025-08-28 0:36 ` [PATCH v3 1/3] xen/events: Cleanup find_virq() return codes Jason Andryuk
2025-08-28 0:36 ` [PATCH v3 2/3] xen/events: Return -EEXIST for bound VIRQs Jason Andryuk
2025-09-02 13:35 ` Juergen Gross
2025-08-28 0:36 ` [PATCH v3 3/3] xen/events: Update virq_to_irq on migration Jason Andryuk
2025-09-02 13:37 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f251c17f-7500-4c84-a796-4ea7fc400bf7@suse.com \
--to=jgross@suse.com \
--cc=chrisw@sous-sol.org \
--cc=jason.andryuk@amd.com \
--cc=jeremy@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®