From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC67C46CA1 for ; Wed, 18 Oct 2023 12:26:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231502AbjJRM0I (ORCPT ); Wed, 18 Oct 2023 08:26:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbjJRM0F (ORCPT ); Wed, 18 Oct 2023 08:26:05 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B83C998; Wed, 18 Oct 2023 05:26:02 -0700 (PDT) Received: from kwepemm000007.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4S9VPJ6ZLSz15NZL; Wed, 18 Oct 2023 20:23:16 +0800 (CST) Received: from [192.168.98.231] (10.67.165.2) by kwepemm000007.china.huawei.com (7.193.23.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 18 Oct 2023 20:25:59 +0800 Message-ID: Date: Wed, 18 Oct 2023 20:25:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , , , , , , , , , , , , Subject: Re: [PATCH net 5/6] net: hns3: fix wrong print link down up To: Andrew Lunn References: <20230728075840.4022760-1-shaojijie@huawei.com> <20230728075840.4022760-6-shaojijie@huawei.com> <7ce32389-550b-4beb-82b1-1b6183fdeabb@lunn.ch> <2c6514a7-db97-f345-9bc4-affd4eba2dda@huawei.com> <73b41fe2-12dd-4fc0-a44d-f6f94e6541fc@lunn.ch> <150d8d95-a6cd-dc28-618b-6cc5295b4bf9@huawei.com> <06cd6f53-e0af-4bdf-a684-68fc55b9b436@lunn.ch> From: Jijie Shao In-Reply-To: <06cd6f53-e0af-4bdf-a684-68fc55b9b436@lunn.ch> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm000007.china.huawei.com (7.193.23.189) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org on 2023/10/17 21:59, Andrew Lunn wrote > I still think this is totally valid and correct. > > When you turn auto-neg off the link partner is going to react to that, > it might drop the link. After a while, the link partner will give up > trying to perform auto-neg and might fall back to 10/Half. At which > point, the link might allow traffic flow. However, in this example, > you have a duplex mis-match, so it might not work correctly. > > Turning off auto-neg is something you need to do at both ends, and you > need to then force both ends to the same settings. Link down is > expected. I would actually be suppressed if no link down events were > reported. > > Andrew Hi Andrew, Thank you for your comments, we are re-evaluating this issue and may drop this patch. Regards Jijie