From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751537AbeAZD4W (ORCPT ); Thu, 25 Jan 2018 22:56:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53214 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbeAZD4V (ORCPT ); Thu, 25 Jan 2018 22:56:21 -0500 Subject: Re: [PATCH net-next 12/12] tools/virtio: fix smp_mb on x86 To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: netdev@vger.kernel.org, John Fastabend , David Miller , virtualization@lists.linux-foundation.org References: <1516923320-16959-1-git-send-email-mst@redhat.com> <1516923320-16959-16-git-send-email-mst@redhat.com> From: Jason Wang Message-ID: Date: Fri, 26 Jan 2018 11:56:14 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1516923320-16959-16-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018年01月26日 07:36, Michael S. Tsirkin wrote: > Offset 128 overlaps the last word of the redzone. > Use 132 which is always beyond that. > > Signed-off-by: Michael S. Tsirkin > --- > tools/virtio/ringtest/main.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/virtio/ringtest/main.h b/tools/virtio/ringtest/main.h > index 593a328..301d59b 100644 > --- a/tools/virtio/ringtest/main.h > +++ b/tools/virtio/ringtest/main.h > @@ -111,7 +111,7 @@ static inline void busy_wait(void) > } > > #if defined(__x86_64__) || defined(__i386__) > -#define smp_mb() asm volatile("lock; addl $0,-128(%%rsp)" ::: "memory", "cc") Just wonder did "rsp" work for __i386__ ? Thanks > +#define smp_mb() asm volatile("lock; addl $0,-132(%%rsp)" ::: "memory", "cc") > #else > /* > * Not using __ATOMIC_SEQ_CST since gcc docs say they are only synchronized