From: Philipp Zabel <p.zabel@pengutronix.de>
To: Thomas Fourier <fourier.thomas@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Javier Martin <javier.martin@vista-silicon.com>,
Hans Verkuil <hverkuil@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
"open list:CODA V4L2 MEM2MEM DRIVER"
<linux-media@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: coda: clear m2m_dev after releasing it in coda_fw_callback()
Date: Fri, 06 Nov 2026 13:47:25 +0100 [thread overview]
Message-ID: <f259e2034a742d7c5d766e7737e901f22bca68ad.camel@pengutronix.de> (raw)
In-Reply-To: <20261029104812.26411-2-fourier.thomas@gmail.com>
On Do, 2026-10-29 at 11:48 +0100, Thomas Fourier wrote:
> In coda_fw_callback(), if v4l2_m2m_init() or coda_register_device() fail,
> v4l2_m2m_release() is called but dev->m2m_dev remains set.
> v4l2_m2m_release() is also called in coda_remove(). This would lead to
> a double free of dev->m2m_dev.
>
> Clear dev->m2m_dev on error paths.
>
> Fixes: 186b250a0725 ("[media] media: coda: Add driver for Coda video codec")
> Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
prev parent reply other threads:[~2026-11-06 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 10:48 Thomas Fourier
2026-11-06 12:47 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f259e2034a742d7c5d766e7737e901f22bca68ad.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=fourier.thomas@gmail.com \
--cc=hverkuil@kernel.org \
--cc=javier.martin@vista-silicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®