From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2E71C55178 for ; Fri, 30 Oct 2020 17:12:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4448F20756 for ; Fri, 30 Oct 2020 17:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604077974; bh=sjfgvgsW7YiDlHy5H1c/FVOZ3eqmNley+6W/VlhyUDY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=jLiKhsPjaVdpg1LYvp3EOu3HlUnPH53QXTfm/s1zVV+7nvxD5wyoLzUb6rmgItTMD QUTYX97sWF7JMpx/mZVQOQo2JNY9N0cKRuNjLdiTL/rJYYfzmKyz/kW6uDEtPhadp7 vd4VCT2DbWCeJFQejDmAXq19w3v2z8rYVS74uO5Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727115AbgJ3RMx (ORCPT ); Fri, 30 Oct 2020 13:12:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgJ3RMx (ORCPT ); Fri, 30 Oct 2020 13:12:53 -0400 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39736C0613CF for ; Fri, 30 Oct 2020 10:12:52 -0700 (PDT) Received: by mail-io1-xd41.google.com with SMTP id k6so8291054ior.2 for ; Fri, 30 Oct 2020 10:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FUbzL5XdQ1f8YYBKU5C0sP8LGZcBt1qJvGhftOqGF4E=; b=aNbLbx6aajXxMw9iAkrV9bGley0HzSnyUh4Qz92ibH9zFMbBOmbUxysZ+za3eA6/D4 M37pzUQRVEb+i3WPAFry4wJ5J44lAb1M6S2Loajb2npO2n6ugKsni97Fc8wFh8eRn9n9 Ihw8IkvMQtK3fKBv3FMn700tiChrhL+MF94uU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FUbzL5XdQ1f8YYBKU5C0sP8LGZcBt1qJvGhftOqGF4E=; b=WV4+aZIHTmNq8uBO1x64Wksl+SoxTfY2KyvlHKtrxGd+ED67SIBZrr1C2DLJ33XJlb J97MsLTeNgAY9pJz9iU/A9kvRZeiBeK7++SqK3uRPMYozb1e4rygwNKjbogE8CcMGpKd o3cngU82Rdk9ofZnpSgS9iYULNKxyGADwe3pzAk+JEql6fdbQYl7clU9LYugDRU/nxMQ uMDA0m6Mk2A5J8+rl79EkornzLfcYqBoabdcpuQluHSCwRBOtlnL//CqGMouhwaIXbNO eIZClIZSUUFnbjSNQGajtYbfvZwD/fHxBnOoAVUq7ec7wbNXHJAc9QJTYb+mvg87BM0x kWNw== X-Gm-Message-State: AOAM530PBgx2rIl87mqDBR0Fy4qvJpIT9j/NFUpLDf8m2Qa/VR2nmw5A YTybtQS0DVxqnZN7XV+mSRQd1Q== X-Google-Smtp-Source: ABdhPJzYWtoBbDYvzZ3xNeVMyVANpnHjx84A3cXKcNETpEhPGLmyVqezsvv/c80LwFhG2z8oErxZcw== X-Received: by 2002:a02:c80a:: with SMTP id p10mr2701625jao.114.1604077971626; Fri, 30 Oct 2020 10:12:51 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id e12sm5004102ilq.65.2020.10.30.10.12.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Oct 2020 10:12:51 -0700 (PDT) Subject: Re: [PATCH v1 4/4] x86/msr: Do not allow writes to MSR_IA32_ENERGY_PERF_BIAS To: Borislav Petkov , X86 ML Cc: Thomas Renninger , Shuah Khan , Len Brown , linux-pm@vger.kernel.org, LKML , Shuah Khan References: <20201029190259.3476-1-bp@alien8.de> <20201029190259.3476-5-bp@alien8.de> From: Shuah Khan Message-ID: Date: Fri, 30 Oct 2020 11:12:50 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201029190259.3476-5-bp@alien8.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/29/20 1:02 PM, Borislav Petkov wrote: > From: Borislav Petkov > > Now that all in-kernel-tree users are converted to using the sysfs file, > remove the MSR from the "allowlist". > > Signed-off-by: Borislav Petkov > --- > arch/x86/kernel/msr.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c > index c0d409810658..b1147862730c 100644 > --- a/arch/x86/kernel/msr.c > +++ b/arch/x86/kernel/msr.c > @@ -99,9 +99,6 @@ static int filter_write(u32 reg) > if (!__ratelimit(&fw_rs)) > return 0; > > - if (reg == MSR_IA32_ENERGY_PERF_BIAS) > - return 0; > - > pr_err("Write to unrecognized MSR 0x%x by %s (pid: %d). Please report to x86@kernel.org.\n", > reg, current->comm, current->pid); > > Thanks. Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah