From: Guenter Roeck <linux@roeck-us.net>
To: Felix Gu <ustc.gu@gmail.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: sprd_wdt: Remove redundant sprd_wdt_disable() on register failure
Date: Mon, 23 Feb 2026 07:09:48 -0800 [thread overview]
Message-ID: <f25c295f-e352-4ae6-bebd-65a1ab8bc78e@roeck-us.net> (raw)
In-Reply-To: <20260223-sprd_wdt-v1-1-2e71f9a76ecb@gmail.com>
On 2/23/26 03:59, Felix Gu wrote:
> The driver uses devm_add_action_or_reset() to register sprd_wdt_disable()
> as a managed cleanup action.
>
> When devm_watchdog_register_device() fails, the devm core will invoke
> the cleanup action automatically.
>
> The explicit sprd_wdt_disable() call in the error path is therefore
> redundant and results in adouble cleanup.
>
> Fixes: 78d9bfad2e89 ("watchdog: sprd_wdt: Convert to use device managed functions and other improvements")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2026-02-23 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 11:59 Felix Gu
2026-02-23 15:09 ` Guenter Roeck [this message]
2026-02-24 1:30 ` Baolin Wang
2026-05-24 6:04 ` Felix Gu
2026-05-24 14:00 ` Guenter Roeck
2026-05-24 17:05 ` Felix Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f25c295f-e352-4ae6-bebd-65a1ab8bc78e@roeck-us.net \
--to=linux@roeck-us.net \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=ustc.gu@gmail.com \
--cc=wim@linux-watchdog.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®