From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02349C61DA4 for ; Thu, 16 Feb 2023 10:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229965AbjBPK2I (ORCPT ); Thu, 16 Feb 2023 05:28:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229725AbjBPK2E (ORCPT ); Thu, 16 Feb 2023 05:28:04 -0500 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B9EBA366B0; Thu, 16 Feb 2023 02:28:03 -0800 (PST) Received: from [192.168.2.24] (77-166-152-30.fixed.kpn.net [77.166.152.30]) by linux.microsoft.com (Postfix) with ESMTPSA id DE5FB20B9C3D; Thu, 16 Feb 2023 02:28:01 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DE5FB20B9C3D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1676543283; bh=TiBxPy2bvn90kEvfNZ1gm0HLB1XTqCcNsA01CVVqYb8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JyXq/lCzwM9AJxO1fMQCJmJtleLVhCXG/by6cwTcunoSQAI0tabjzAmYKVuZSwmo9 1vfOOjaiahoaeWP40hPJtw3BWp1oIxSHjvLVh6HCQuY3S6Nw3EK8U7FVDsm/0rod8H 5nkVviFRLPMchx6Qe9yYktGkwoC36HIfBKgx9YsA= Message-ID: Date: Thu, 16 Feb 2023 11:28:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 1/8] include/acpi: add definition of ASPT table To: "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, Brijesh Singh , Tom Lendacky , "Kalra, Ashish" , Len Brown , linux-acpi@vger.kernel.org References: <20230213092429.1167812-1-jpiotrowski@linux.microsoft.com> <20230213092429.1167812-2-jpiotrowski@linux.microsoft.com> Content-Language: en-US From: Jeremi Piotrowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/02/2023 19:43, Rafael J. Wysocki wrote: > On Mon, Feb 13, 2023 at 10:25 AM Jeremi Piotrowski > wrote: >> >> The AMD Secure Processor ACPI Table provides the memory location of the >> register window and register offsets necessary to communicate with AMD's >> PSP (Platform Security Processor). This table is exposed on Hyper-V VMs >> configured with support for AMD's SNP isolation technology. >> >> Signed-off-by: Jeremi Piotrowski > > Please add a Link tag pointing to the corresponding upstream ACPICA > pull request (or upstream ACPICA commit if already pulled) to this > patch and analogously for patch [2/8]. > > Thanks! > Will do when I post v3. I'll poke the ACPICA maintainer again after the specification gets published this friday. Jeremi >> --- >> include/acpi/actbl1.h | 46 +++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> >> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h >> index 15c78678c5d3..00d40373df37 100644 >> --- a/include/acpi/actbl1.h >> +++ b/include/acpi/actbl1.h >> @@ -26,6 +26,7 @@ >> */ >> #define ACPI_SIG_AEST "AEST" /* Arm Error Source Table */ >> #define ACPI_SIG_ASF "ASF!" /* Alert Standard Format table */ >> +#define ACPI_SIG_ASPT "ASPT" /* AMD Secure Processor Table */ >> #define ACPI_SIG_BERT "BERT" /* Boot Error Record Table */ >> #define ACPI_SIG_BGRT "BGRT" /* Boot Graphics Resource Table */ >> #define ACPI_SIG_BOOT "BOOT" /* Simple Boot Flag Table */ >> @@ -106,6 +107,51 @@ struct acpi_whea_header { >> u64 mask; /* Bitmask required for this register instruction */ >> }; >> >> +/* https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/acpitabl/ns-acpitabl-aspt_table */ >> +#define ASPT_REVISION_ID 0x01 >> +struct acpi_table_aspt { >> + struct acpi_table_header header; >> + u32 num_entries; >> +}; >> + >> +struct acpi_aspt_header { >> + u16 type; >> + u16 length; >> +}; >> + >> +enum acpi_aspt_type { >> + ACPI_ASPT_TYPE_GLOBAL_REGS = 0, >> + ACPI_ASPT_TYPE_SEV_MBOX_REGS = 1, >> + ACPI_ASPT_TYPE_ACPI_MBOX_REGS = 2, >> +}; >> + >> +/* 0: ASPT Global Registers */ >> +struct acpi_aspt_global_regs { >> + struct acpi_aspt_header header; >> + u32 reserved; >> + u64 feature_reg_addr; >> + u64 irq_en_reg_addr; >> + u64 irq_st_reg_addr; >> +}; >> + >> +/* 1: ASPT SEV Mailbox Registers */ >> +struct acpi_aspt_sev_mbox_regs { >> + struct acpi_aspt_header header; >> + u8 mbox_irq_id; >> + u8 reserved[3]; >> + u64 cmd_resp_reg_addr; >> + u64 cmd_buf_lo_reg_addr; >> + u64 cmd_buf_hi_reg_addr; >> +}; >> + >> +/* 2: ASPT ACPI Mailbox Registers */ >> +struct acpi_aspt_acpi_mbox_regs { >> + struct acpi_aspt_header header; >> + u32 reserved1; >> + u64 cmd_resp_reg_addr; >> + u64 reserved2[2]; >> +}; >> + >> /******************************************************************************* >> * >> * ASF - Alert Standard Format table (Signature "ASF!") >> -- >> 2.25.1 >>