From: Markus Elfring <Markus.Elfring@web.de>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Svyatoslav Ryhel" <clamor95@gmail.com>,
linux-pm@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
mfd@lists.linux.dev, "Conor Dooley" <conor+dt@kernel.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Florian Krischer" <florian.krischer@fkr.dev>,
"Ion Agorria" <ion@agorria.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Lee Jones" <lee@kernel.org>, "Pavel Machek" <pavel@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 6/7] power: supply: Add driver for ASUS Transformer battery
Date: Thu, 15 Oct 2026 20:06:25 +0200 [thread overview]
Message-ID: <f26b6bba-2c2e-46b3-9350-0ba0785cf3ba@web.de> (raw)
In-Reply-To: <20261013173504.451391-7-clamor95@gmail.com>
…
> +++ b/drivers/power/supply/asus-transformer-ec-battery.c
> @@ -0,0 +1,289 @@
…
> +static const unsigned int asus_ec_battery_prop_offs[] = {
> + [POWER_SUPPLY_PROP_STATUS] = 1,
…
> +};
> +
> +static int asus_ec_battery_get_value(struct asus_ec_battery_data *priv,
> + enum power_supply_property psp)
> +{
> + int ret, offs;
…
The referenced array provides unsigned integers.
Would you like to specify a more appropriate data type for the corresponding variable?
Regards,
Markus
next prev parent reply other threads:[~2026-10-15 18:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 17:34 [PATCH v11 0/7] mfd: Add support for Asus Transformer embedded controller Svyatoslav Ryhel
2026-10-13 17:34 ` [PATCH v11 1/7] dt-bindings: embedded-controller: document ASUS Transformer EC Svyatoslav Ryhel
2026-10-13 17:34 ` [PATCH v11 2/7] mfd: Add driver for ASUS Transformer embedded controller Svyatoslav Ryhel
2026-10-14 22:34 ` kernel test robot
2026-10-15 1:36 ` Dmitry Torokhov
2026-10-15 7:54 ` Svyatoslav Ryhel
2026-10-13 17:34 ` [PATCH v11 3/7] input: serio: Add driver for ASUS Transformer dock keyboard and touchpad Svyatoslav Ryhel
2026-10-13 17:35 ` [PATCH v11 4/7] input: keyboard: Add driver for ASUS Transformer dock multimedia keys Svyatoslav Ryhel
2026-10-15 1:33 ` Dmitry Torokhov
2026-10-15 7:57 ` Svyatoslav Ryhel
2026-10-13 17:35 ` [PATCH v11 5/7] leds: Add driver for ASUS Transformer LEDs Svyatoslav Ryhel
2026-10-13 17:35 ` [PATCH v11 6/7] power: supply: Add driver for ASUS Transformer battery Svyatoslav Ryhel
2026-10-15 1:38 ` Dmitry Torokhov
2026-10-15 7:49 ` Svyatoslav Ryhel
2026-10-15 18:06 ` Markus Elfring [this message]
2026-10-15 18:41 ` Svyatoslav Ryhel
2026-10-13 17:35 ` [PATCH v11 7/7] power: supply: Add charger driver for Asus Transformers Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f26b6bba-2c2e-46b3-9350-0ba0785cf3ba@web.de \
--to=markus.elfring@web.de \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=florian.krischer@fkr.dev \
--cc=ion@agorria.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®