From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4226EC61DB3 for ; Thu, 12 Jan 2023 15:56:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240545AbjALP4C (ORCPT ); Thu, 12 Jan 2023 10:56:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232975AbjALPzV (ORCPT ); Thu, 12 Jan 2023 10:55:21 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E02B65AC74 for ; Thu, 12 Jan 2023 07:45:00 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id y25so29001843lfa.9 for ; Thu, 12 Jan 2023 07:45:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dO98yJCjhJKHHJFzoPP10XSL6ZvByFzhpcdLh14ZehU=; b=qbMwOpc9CFkIEWKaAfBZ4iBqBlDkEkiCaLEa0TIiVT0KUVr2ybb/EbBiLTdz5YVLUE Xz541blif/x+QxSbtV3PUTbem3MK44eUHNSoCc5Ee9oSRFS+ZxdZnM8YSl0vCLjpdKNM 4Q46tXImWOGQBo9e9BBXDUy9CLYZw7xxF5pDW2dqrSUnqr5GZPRYGgphWbGX3Y2zkIFG 03zrpJnnS2ajrptfc9VsiKNgoIrN3VFOe0jYnPerRhVoZ2qMwwMPvKSNsoP0ennBlQPG VQtNm0KQ7RcfQ24Dzt7TYGb7C0XVAASglqq3DY4PQqJnZUG0jP5DX8vrh/RTbroA0hZ5 659Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dO98yJCjhJKHHJFzoPP10XSL6ZvByFzhpcdLh14ZehU=; b=WcoqgYH50b9LcQvdnm0QBbptudD+PJNYJ9/i+9akKFzMXZpB4/m0ceeF8vEEPWhEtS 2/FT/7sU5X7WpSUA7vjhAFUdKpkoXm2YDHX7Z/woKGCqdGXMa0cJsQOtNwcUShpy1/o7 iuspqAivwxO1C4bIzVmRV7Q9OfI5pZRTSo2YSDGBXh5ByNWjwfkCgrzpE9Arv33FqpHP mNb89xsj0tbR1lWbmOQAkv1Jz3BM61C+IHbZ9+rquw+pQkacfOBSFCuckWjWRF4acoan SvNrbVJqpLbPPZ0a8ndRd2orn3xw2UZBK+bN7Zs6dvBsZGXL5LVtW/USE/CDuLAD89ds QjDw== X-Gm-Message-State: AFqh2kqCN0Knv+MNg000s8FibU9hCzlkDmIJPXq28larITsd7WFi+yI6 81Fvkt3wHmG+Sx0VIMtQgPE33g== X-Google-Smtp-Source: AMrXdXsgekTVzlXxmGMDXgy2BKSdn+T0k5Wesxz7i7Sb8Q7bfHmXCG0E3MvTzCKFlwNDSvBiF87whw== X-Received: by 2002:a05:6512:1395:b0:4b5:b10b:6830 with SMTP id p21-20020a056512139500b004b5b10b6830mr22604048lfa.54.1673538299168; Thu, 12 Jan 2023 07:44:59 -0800 (PST) Received: from [192.168.1.101] (abym53.neoplus.adsl.tpnet.pl. [83.9.32.53]) by smtp.gmail.com with ESMTPSA id s6-20020ac25fe6000000b004b6efcb7bb5sm3336312lfg.169.2023.01.12.07.44.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 07:44:57 -0800 (PST) Message-ID: Date: Thu, 12 Jan 2023 16:44:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Use MMCX for all DP controllers Content-Language: en-US To: Bjorn Andersson , Bjorn Andersson Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold References: <20230112135055.3836555-1-quic_bjorande@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230112135055.3836555-1-quic_bjorande@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.01.2023 14:50, Bjorn Andersson wrote: > While MDSS_GDSC is a subdomain of MMCX, Linux does not respect this > relationship and sometimes invokes sync_state on the rpmhpd (MMCX) > before the DisplayPort controller has had a chance to probe. > > The result when this happens is that the power is lost to the multimedia > subsystem between the probe of msm_drv and the DisplayPort controller - > which results in an irrecoverable state. > > While this is an implementation problem, this aligns the power domain > setting of the one DP instance with that of all the others. > > Fixes: 57d6ef683a15 ("arm64: dts: qcom: sc8280xp: Define some of the display blocks") > Signed-off-by: Bjorn Andersson > --- One day we'll hopefully finally overcome this parent-child mess.. Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 4f4353f84cba..4511fd939c91 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -2533,7 +2533,7 @@ mdss0_dp3: displayport-controller@aea0000 { > interrupts = <15>; > phys = <&mdss0_dp3_phy>; > phy-names = "dp"; > - power-domains = <&dispcc0 MDSS_GDSC>; > + power-domains = <&rpmhpd SC8280XP_MMCX>; > > assigned-clocks = <&dispcc0 DISP_CC_MDSS_DPTX3_LINK_CLK_SRC>, > <&dispcc0 DISP_CC_MDSS_DPTX3_PIXEL0_CLK_SRC>;