From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 924A8C433F5 for ; Thu, 17 Mar 2022 01:15:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352132AbiCQBQv (ORCPT ); Wed, 16 Mar 2022 21:16:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239211AbiCQBQu (ORCPT ); Wed, 16 Mar 2022 21:16:50 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D0201D31A for ; Wed, 16 Mar 2022 18:15:35 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id o68-20020a17090a0a4a00b001c686a48263so27144pjo.1 for ; Wed, 16 Mar 2022 18:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=n4UekLFhKuoj6t1J4RjnJqfB3Vjx/zOk+L3n0fvA5S8=; b=NYllIOUTO0smOmOzO5Wo68IPf4JO5lDnCbO8FCGio+UqyURyfxzFMwu1g0Tw0P10tT pEVyxWAN2dDoxhPnhjfzS9WDI9CslV/AnkysdyglA5d1O9XwFOzEacTWM9r1jgGXWetM roBNV4lo0y9sCRrsR8FTy1RWZedd51E5YedgHr8JlrVaYsI59ZZ5o9bcZFgGnd+T0zw9 NNmNlfT92dshwo9/5CBlvR95RbcmR8zCPMdkk+2SauoWugzSopxU+1KPYhHyjiApvZRS kMHg4wulqYwf9goCSMBFHZd7YIqCnPQVP2dDdpVo0GK299TNPoCMbEEqyxyo3V8vdvHt fbBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=n4UekLFhKuoj6t1J4RjnJqfB3Vjx/zOk+L3n0fvA5S8=; b=TaVDfs76axuNwt8fGFNdxkm6+3H1VFnRHUYyyJgtKITHUo2XyNfeJwQwCP8xI17YRN KP1tW7C6t57k+CwcK2xCrQPITo3uwdi1+waFhvUt5ZocnIyGjwhCBCw3t1NMh25m4+b3 3BsGxTzi0F/TVV1IO981xlYtZaYCH8trm3T9dJ54SilFGfjQxwQ06JWl7rpuvZBV+syh 5EqdNSKYM1HxAe6r3I49SX3LHLlkbm7g1Cir28dkVT60xodorg/vXojIATSVEOtwbw1W NJkEcoGH295KFWceFpHiZk2Cb0jJGhRrEBapfKLEccoiotvQk9Y4Zyt1nBJY7/LlZvgZ oW3g== X-Gm-Message-State: AOAM530ZNME7GvKjHuJCH1Ddltc5wYf+2kTTN6u5Z8qLy1Z/Cigl1L85 W3qwlzXmYUfJdqqxJWi8P85HYg== X-Google-Smtp-Source: ABdhPJwAZrP/Jb/nuiOdj4wyKSq/7tixRkzsZDvwjYBHg2pQubfx2QGocD6YCGDjunmElxW3jURwNA== X-Received: by 2002:a17:90b:3b92:b0:1c6:3c6b:a2b9 with SMTP id pc18-20020a17090b3b9200b001c63c6ba2b9mr11314342pjb.156.1647479734605; Wed, 16 Mar 2022 18:15:34 -0700 (PDT) Received: from ?IPV6:2409:8a28:e6e:c590:e574:d032:858c:2ca1? ([2409:8a28:e6e:c590:e574:d032:858c:2ca1]) by smtp.gmail.com with ESMTPSA id v6-20020a056a00148600b004f9f9b9092fsm4708428pfu.113.2022.03.16.18.15.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 18:15:34 -0700 (PDT) Message-ID: Date: Thu, 17 Mar 2022 09:15:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [External] Re: [PATCH v3] livepatch: Don't block removal of patches that are safe to unload Content-Language: en-US To: Petr Mladek , Miroslav Benes Cc: jpoimboe@redhat.com, jikos@kernel.org, joe.lawrence@redhat.com, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, songmuchun@bytedance.com, qirui.001@bytedance.com References: <20220312152220.88127-1-zhouchengming@bytedance.com> From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/3/16 11:01 下午, Petr Mladek wrote: > On Wed 2022-03-16 15:48:25, Miroslav Benes wrote: >> On Sat, 12 Mar 2022, Chengming Zhou wrote: >> >>> module_put() is not called for a patch with "forced" flag. It should >>> block the removal of the livepatch module when the code might still >>> be in use after forced transition. >>> >>> klp_force_transition() currently sets "forced" flag for all patches on >>> the list. >>> >>> In fact, any patch can be safely unloaded when it passed through >>> the consistency model in KLP_UNPATCHED transition. >>> >>> By other words, the "forced" flag must be set only for livepatches >> >> s/By/In/ >> >>> that are being removed. In particular, set the "forced" flag: >>> >>> + only for klp_transition_patch when the transition to KLP_UNPATCHED >>> state was forced. >>> >>> + all replaced patches when the transition to KLP_PATCHED state was >>> forced and the patch was replacing the existing patches. >>> >>> index 5683ac0d2566..7f25a5ae89f6 100644 >>> --- a/kernel/livepatch/transition.c >>> +++ b/kernel/livepatch/transition.c >>> @@ -641,6 +641,18 @@ void klp_force_transition(void) >>> for_each_possible_cpu(cpu) >>> klp_update_patch_state(idle_task(cpu)); >>> >>> - klp_for_each_patch(patch) >>> - patch->forced = true; >>> + /* >>> + * Only need to set forced flag for the transition patch >>> + * when force transition to KLP_UNPATCHED state, but >>> + * have to set forced flag for all replaced patches >>> + * when force atomic replace transition. >>> + */ >> >> How about something like >> >> /* >> * Set forced flag for patches being removed, which is the transition >> * patch in KLP_UNPATCHED state or all replaced patches when forcing >> * the atomic replace transition. >> */ > > Or just the first sentence: > > /* Set forced flag for patches being removed */ > > The rest is visible from the code. > > Either version works for me. If we agree on it then I update > the text when pushing the patch. Ok, this works for me too ;-) Thanks. > > Best Regards, > Petr