From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54328C43441 for ; Mon, 12 Nov 2018 13:20:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE7A1223D0 for ; Mon, 12 Nov 2018 13:20:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE7A1223D0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729636AbeKLXNw (ORCPT ); Mon, 12 Nov 2018 18:13:52 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:55977 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727103AbeKLXNv (ORCPT ); Mon, 12 Nov 2018 18:13:51 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id D634FD06E6F6; Mon, 12 Nov 2018 21:20:32 +0800 (CST) Received: from [127.0.0.1] (10.177.31.96) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.408.0; Mon, 12 Nov 2018 21:20:31 +0800 Subject: Re: [PATCH net-next] NFC: nci: remove redundant variable 'status' To: , References: <20180801072020.14696-1-yuehaibing@huawei.com> CC: , From: YueHaibing Message-ID: Date: Mon, 12 Nov 2018 21:20:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. On 2018/9/13 20:06, YueHaibing wrote: > Ping. > > On 2018/8/1 15:20, YueHaibing wrote: >> After commit d8cd37ed2fc8 ("NFC: nci: Fix improper management of HCI return code") >> variable 'status' is being assigned but never used, >> so can be removed. Also make a trival cleanup. >> >> Signed-off-by: YueHaibing >> --- >> net/nfc/nci/hci.c | 10 ++-------- >> 1 file changed, 2 insertions(+), 8 deletions(-) >> >> diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c >> index ddfc52a..4debba8 100644 >> --- a/net/nfc/nci/hci.c >> +++ b/net/nfc/nci/hci.c >> @@ -370,17 +370,11 @@ static void nci_hci_resp_received(struct nci_dev *ndev, u8 pipe, >> u8 result, struct sk_buff *skb) >> { >> struct nci_conn_info *conn_info; >> - u8 status = result; >> >> conn_info = ndev->hci_dev->conn_info; >> - if (!conn_info) { >> - status = NCI_STATUS_REJECTED; >> - goto exit; >> - } >> - >> - conn_info->rx_skb = skb; >> + if (conn_info) >> + conn_info->rx_skb = skb; >> >> -exit: >> nci_req_complete(ndev, NCI_STATUS_OK); >> } >> >> > > > . >