From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C51E0175A81 for ; Mon, 3 Aug 2026 11:17:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785755871; cv=none; b=lbgmn5oktYlrCqgWYyJwlarWsIU5l9v481YpQVSA7rNprSblb9VE34G6HGCxjOZZlPnAWutGbUOfwl92phPyQFZEyEZd0SuNsRKjrmZzqf2XRTVxijOQUHqoenvkDHwOf9Y9IbEKiuDCNe/VMaOnd2HVrl2HElphHWQqLqIFJns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785755871; c=relaxed/simple; bh=+t6yr5eG84icpqXcJ/ZyGowvJ/5FPWD8P9aAOXlfKIQ=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=jTny59KySyuLejUeAgWFsPgMYUptt6AkzZjZMJMxgAEPcVWWd+v0A9JWRNOiFtAYoK3cKkaBjJAZuSmOvdsKpVIJA9tWYmI1bJljuL/YY3J1xoZnvz1A5sO8+rhdJxWKyCZuHldedq5nixAhqoS/0s6PGeLv/NBw61huN1Tojww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bkILrIzg; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bkILrIzg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46C4F1F000E9; Mon, 3 Aug 2026 11:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785755870; bh=dxMHEVZ5lvURQccCytgBzz60+hKdTr7VQ/fMX7z8Nl0=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=bkILrIzgpJ8B4/gwmJ1vUJmKO8vaeVFvaNA7233yvcmyZmalQnHW34+0vwwhM8cmO 8UzmxRCKcL6avYHS2XfV1YYFEQuenOlT+P+zHt/9nSkQuLpDLM6qsd2OKhL4vJDuSI b8B5M+IyF/xYRxkrxJ4XOxadWZ6Y4gbWsrp3jR+POQC7dcFasn0kVcSbpxuHu4+wyu HoZjfC16g9h/oBL7wujbvKuqkzIz7ktKYqMYDJFDHP9SmfKqRu6jYhJfdhJFU2ph6Q AOrmwZ65JWx4HtizrSpfjHQF7YbewTqVfrdtHavd6PcKKpbXhAWoQvarLikCgMWfNC g7cqLP1juO/GQ== Message-ID: Date: Mon, 3 Aug 2026 19:17:42 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH RFC 06/14] fs/f2fs: stop using PG_private To: Zi Yan , David Hildenbrand , "Matthew Wilcox (Oracle)" , Andrew Morton , Muchun Song , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Gregory Price , Ying Huang , Alistair Popple , Johannes Weiner , Qi Zheng , Shakeel Butt , Kairui Song References: <20260731-remove-pg_private-v1-0-142c97ba3562@nvidia.com> <20260731-remove-pg_private-v1-6-142c97ba3562@nvidia.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260731-remove-pg_private-v1-6-142c97ba3562@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/1/26 10:13, Zi Yan wrote: > f2fs sets its PAGE_PRIVATE_* flags in page->private and checking > page->private != NULL is equivalent to checking PG_private. Change > PagePrivate() to page_private(). Meanwhile, in set_page_private_##name(), > page->private is first set to 0/NULL before an PAGE_PRIVATE_* flag is set, > but it can cause confusion when PG_private is removed and > page->private != NULL is used instead. Change it to initialize > page->private to PAGE_PRIVATE_NOT_POINTER instead and retain the original > semantics. > > It prepares for a future commit that removes PG_private. > > No funtional change intended. > > Assisted-by: Claude:claude-opus-4-8 > Assisted-by: Codex:gpt-5 > Signed-off-by: Zi Yan > To: Jaegeuk Kim > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net > Cc: linux-kernel@vger.kernel.org Acked-by: Chao Yu Thanks,