From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, lgirdwood@gmail.com,
broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: Add PMX75 compatible
Date: Tue, 11 Jul 2023 08:23:24 +0200 [thread overview]
Message-ID: <f27a692e-460c-9a9b-0afc-ad9a71ab4262@linaro.org> (raw)
In-Reply-To: <fc054877-52c6-9e61-8572-3068c53a86de@quicinc.com>
On 11/07/2023 08:22, Rohit Agarwal wrote:
>
> On 7/11/2023 11:35 AM, Krzysztof Kozlowski wrote:
>> On 11/07/2023 07:46, Rohit Agarwal wrote:
>>> Add PMX75 compatibles for PMIC found in SDX75 platform.
>>> While at it, update the entry for SDX65 as well.
>> Everything is an update...
>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>> ---
>>> .../bindings/regulator/qcom,rpmh-regulator.yaml | 22 +++++++++++++++++++++-
>>> 1 file changed, 21 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
>>> index b949850..72b533c 100644
>>> --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
>>> +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
>>> @@ -53,6 +53,7 @@ description: |
>>> For PMR735A, smps1 - smps3, ldo1 - ldo7
>>> For PMX55, smps1 - smps7, ldo1 - ldo16
>>> For PMX65, smps1 - smps8, ldo1 - ldo21
>>> + For PMX75, smps1 - smps10, ldo1 - ldo21
>>>
>>> properties:
>>> compatible:
>>> @@ -84,6 +85,7 @@ properties:
>>> - qcom,pmr735a-rpmh-regulators
>>> - qcom,pmx55-rpmh-regulators
>>> - qcom,pmx65-rpmh-regulators
>>> + - qcom,pmx75-rpmh-regulators
>>>
>>> qcom,pmic-id:
>>> description: |
>>> @@ -424,10 +426,28 @@ allOf:
>>> vdd-l11-l13-supply: true
>>> patternProperties:
>>> "^vdd-l[1347]-supply$": true
>>> - "^vdd-l1[0245789]-supply$": true
>>> + "^vdd-l1[024579]-supply$": true
>> Why? Does not look related at all.
> This update is because sdx65 does not have vdd-l18-supply separately and
> its
> already part of vdd-l2-l18-supply property mentioned in the properties
> field.
Which was not explained in commit msg and is anyway not related. It's a
separate commit.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-11 6:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 5:46 [PATCH v2 0/2] Add regulators support for PMX75 Rohit Agarwal
2023-07-11 5:46 ` [PATCH v2 1/2] dt-bindings: regulator: Add PMX75 compatible Rohit Agarwal
2023-07-11 6:05 ` Krzysztof Kozlowski
2023-07-11 6:22 ` Rohit Agarwal
2023-07-11 6:23 ` Krzysztof Kozlowski [this message]
2023-07-11 6:25 ` Rohit Agarwal
2023-07-11 5:46 ` [PATCH v2 2/2] regulator: qcom-rpmh: Add regulators for PMX75 Rohit Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f27a692e-460c-9a9b-0afc-ad9a71ab4262@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rohiagar@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®