From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 933ED1EB5F8 for ; Tue, 21 Apr 2026 02:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776738777; cv=none; b=lDJecf6vhiD+R1BVt4JiYizWXtFyL3gGdC7C2PEyJ4osTpE88VL1g9PWKbC1m+9p3eJq58KxZ5rsNWUoLGFsQKNo0gaSWUqMvX+EqcMOX4+uzF0wRQXQSbuAYFg+JmXkJ8Ukng81R7+5qvF1GrVmb2u4BdcCQsXHRsHlWyBXFNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776738777; c=relaxed/simple; bh=uom/B1n1D/RcDiebfxqB3zYM8U1Pb4fLm/1EWxRnRAI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uXyKs1EaWRAhp6D/Qhz1AKrQR2e5D8gWJxCGOVCT/Mgw9vS08x9xRlqc+XEEUF/YLKeUAkQ/K9ec5IFuSrc6L/1ex0Jqgxt68oEqlWTLjt6wPZbyTW5K3ZTRPnICSnsd9UAvFPCbMMlan0715g8B34HCmm7kj856XXMfnxlAebs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Hp4o7VP3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Akw9m9pG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Hp4o7VP3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Akw9m9pG" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63KIHGm51598266 for ; Tue, 21 Apr 2026 02:32:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nKh8R1Dg3Npq11SavjJUrVg6TTb0obZ2ojFct6wX6QY=; b=Hp4o7VP32GlrV1Uy wwXYsV4dwoiQepF2QGXbb7CUVNLwwY15E19qeh1muUzcwkGzfUpnHLkNGKBb57FL /cCBO5E6gYLK+kN3ASl5+HfsWZcBNRvjbkF8WsQWGa5yxEM6dnsDsbWO5SCakG+1 iADWnSNxlU2piJLhCt4QaCcn4BnINtVyIJRYyj8c0okSkKAuNwQLBTOSXDaa6ln4 CR9PKKE6Buw2CGUl0UK7S9gzwxqgWIBnd6ko3bbW7GKJO0klS4A5PhXquPqQUwZ5 Clftxm5Vojfhn3xDBsSgaT11kiGNWvjaSJ/lCPgho2kfZ6zfI/pqUPfwi5ZLcSbe Npl89A== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dnfgnm25g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Apr 2026 02:32:55 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b2e8bba2e6so51888155ad.1 for ; Mon, 20 Apr 2026 19:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776738774; x=1777343574; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nKh8R1Dg3Npq11SavjJUrVg6TTb0obZ2ojFct6wX6QY=; b=Akw9m9pGBz6hFbR3O2n50uXtF2ali/5Cg4kEbHxuQwuZdFLOESjHGePgFMaDZy8sH9 IwL0pDAiWOmlGOO08H9AC3iTF+nE5cgPBzoJaH5IYVLu+B/i30jbcfyuDcC/yKZHrE9Q /glw96a6GzBnIXODAOb9BPuqLsdDNa0bB6aE8aLSBnWRaRE0AmUz/v/FfQi05n3Wi9Li X9m9SZAKgfzcDQ5TKFNXT3/aMX2ejL2nbfPBEUuup2LOeNR2qxdPtYLXHMMEzndyn+0t QfHonaCHqMoS5ZpZNo+ZwMslCtXW5uEgY94obKFKhmMvHoo2lvMRa0ihTlFhDCSsZww0 Qo7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776738774; x=1777343574; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nKh8R1Dg3Npq11SavjJUrVg6TTb0obZ2ojFct6wX6QY=; b=Cy2RH0/o7Bd5E5tA5cKa5Rb4rYmOB4JBlkOuR/yJc6zChxD9OU99MXZ1HhTL5/dUW4 PGDtLTcdBTwhU0MSjZDiNtHJqVXvWz4xkJvlzVBqGzogTTga85EuGZUIZvhVHE9Aj1vk l0F4P2DqXV4Pe3R7MKIyD8AKzMyqIrV4Dmi4SsbE3mNfKSn9QvZIoxtA9E6Q081KPYOq X95M/zpNO+wPiwt1+Cc8woo2DRHvVcjlaiIukNfMlKOYRB391ZMclL6dDfrhR6JMCTfc E3Oal2p0MBkx9ydbwdAVaDSdhI756sm8nWq9QMwuKetaTmPXiadOk6hA86I2HRj9jyvw zGMA== X-Forwarded-Encrypted: i=1; AFNElJ+LwlQpZQXwgGoFdSBaoE3t1+8h5MHuD1bMQdAIWpLzUPJDSGiWQTMqkb2wlwbxWI2SlFcJE1JoVAknlIc=@vger.kernel.org X-Gm-Message-State: AOJu0YxbrwZkwFYZyG7dMqQrUBi2wyMUPnR+zKfDH9bqF+N32LIvnDhi 0sQQGnMr15drvY1MvacKTCnIMCF9M4ey+LIwZjxmjYuno2WPdxn1YczjXa5cx7KeGwkfhyTSPlv KZba0OCEnUaLjh2vBtx69Bh0U8M/44+S5WtTcksGY4u9RJ/K9ckJ/hbbO1n3IcPjfSe0= X-Gm-Gg: AeBDiesLpR/pyv5c8jnBWJTbaaijq9MSjJlLgxZtNdkOH5p5SlQVihNSgyqUxRYla2t FsXTKCUA1ZlcuROuBoduySXKzCmQyKbmZ6Zp6MxoMleE+vtXR55J50Li5vyzxhV0f7y3DeNAkk8 6bwZ/btWWnFnUeQjU+iAufK1Je8+SQZAgC4tfMg2j1oIHpdw95FkA18UoIp2JtE9wyQH8tLxhuc Ti3KD19TFdFoMbJ42YDEDBBWHTT6WiCYRzibrr0o9A+bSsRNslUF1wKQwGV49kEdobc8Pi502J6 YWmr8WhvTgDy1xGis/EquJtxD3Qa63AJunxBaWCp0yP6ySkw+V50CnqQF7pokFIlza40A9JABR4 r50p1MNXXs7YpZj8ch9FyR3tLXtdex1gpS7PrZxKarfoRGGt0Axy2aeLSshDyab+sQxrIMNddgP 9sLR2UE+1gd2hxU+8hkYVT4OLTovUa X-Received: by 2002:a17:903:1d2:b0:2b2:41a9:8e10 with SMTP id d9443c01a7336-2b5f9f4e110mr172976655ad.23.1776738774355; Mon, 20 Apr 2026 19:32:54 -0700 (PDT) X-Received: by 2002:a17:903:1d2:b0:2b2:41a9:8e10 with SMTP id d9443c01a7336-2b5f9f4e110mr172976255ad.23.1776738773895; Mon, 20 Apr 2026 19:32:53 -0700 (PDT) Received: from [10.133.33.141] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab2114bsm112678515ad.60.2026.04.20.19.32.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 19:32:53 -0700 (PDT) Message-ID: Date: Tue, 21 Apr 2026 10:32:49 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] phy: qcom: edp: Add eDP/DP mode switch support To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , Stephen Boyd , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260302-edp_phy-v3-0-ca8888d793b0@oss.qualcomm.com> <20260302-edp_phy-v3-1-ca8888d793b0@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: T2oVZdGMAg57_RaoryB7NNMon1Hg5e2H X-Proofpoint-GUID: T2oVZdGMAg57_RaoryB7NNMon1Hg5e2H X-Authority-Analysis: v=2.4 cv=TK11jVla c=1 sm=1 tr=0 ts=69e6e1d7 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=PxGw4gJgEL4GvZwk1AwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIxMDAyMiBTYWx0ZWRfXyKX4Ptra5mMy UfnCY5UU8aKb6nzyElnhvToCuGS8LUAKMBs2foWz01z05dFRuxRAqFlkkJx6VIHkxvfKUL4BAPl ZeO8awsqMhlK4cXCr00LqnOlPYr5wPu8rWZxPsiZ20oaFsaG8h6ODoSgxh7V03gedRA4Bqfzrrn bEXwmBK4A3qa/l5uSUlTGQv8OlJ4IA42COrSW3nat7sr4lnfWhT01K3D7nFj/ERQnhALZiAJo7j SMkgi3ELePp7oIsvU+pGH0n5S40MBQmd86D7t8aRRjjUDAWOLDRXWErEi3YqKcYwYYVuXuEVDaG l/0MEjxM3jaF5zD8ZqPuILl1IddtXE8vmsFV5K2oe6ggKomlDXN/E5FKd+QkbQTnpo+FQt8ejyG 4a+Zy8C7ucQmilSxy2Rb3ZG1CYYaEDtaf6J1FHgsttnniPae0N+oH5drIsOzstpJv76/wnVX5PS z42Bpj6t7z2d8po0DLQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-20_05,2026-04-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604210022 On 4/21/2026 2:32 AM, Dmitry Baryshkov wrote: > On Mon, Apr 20, 2026 at 08:47:09PM +0800, Yongxing Mou wrote: >> >> >> On 3/20/2026 2:36 PM, Dmitry Baryshkov wrote: >>> On Mon, Mar 02, 2026 at 04:28:29PM +0800, Yongxing Mou wrote: >>>> The eDP PHY supports both eDP&DP modes, each requires a different table. >>>> The current driver doesn't fully support every combo PHY mode and use >>>> either the eDP or DP table when enable the platform. In addition, some >>>> platforms mismatch between the mode and the table where DP mode uses >>>> the eDP table or eDP mode use the DP table. >>>> >>>> Clean up and correct the tables for currently supported platforms based on >>>> the HPG specification. >>>> >>>> Here lists the tables can be reused across current platforms. >>>> DP mode： >>>> -sa8775p/sc7280/sc8280xp/x1e80100 >>>> -glymur >>>> eDP mode(low vdiff): >>> >>> Separate question: should we extend phy_configure_dp_opts with the >>> low/high vdiff? Is there a point in providing the ability to toggle >>> between low vdiff and high vdiff? >>> >> Emm ,i haven't found any platform using high vdiff so far, and I'm not clear >> in which cases switching between low and high vdiff would be needed. > > From my (maybe incorrect) understanding of eDP B.3, the high vs low > vdiff selection should be based on the cable length. > Thanks for the explanation. Maybe we can add this when we really need it. >> >>>> -glymur/sa8775p/sc8280xp/x1e80100 >>>> -sc7280 >>> >>> I understand your wish to perform all the changes in a single patch, but >>> there is one problem with that. Consider this patch regresses one of the >>> platforms (I'm looking at Kodiak and SC8180X as they get the biggest set >>> of changes). It would be almost impossible to separate, which particular >>> change caused the regression. I'd suggest splitting this patch into a >>> set of more atomic changes. E.g. the AUX_CFG8 is definitely a separate >>> change. Writing swing / pre_emph tables on Kodiak and SC8180X is a >>> separate change (or two). Switching each of the platforms to the >>> corrected set of tables ideally also should come as a separate change, >>> so that in case of a regression the issue would be easier to identify. >>> >> Thank for point this, will separate the change. >> I mostly overlooked SC8180X here, since I assumed it shares the same PHY as >> SC7280. However, they are using different PHY sub‑versions. Will add proper >> support for it in the next version. > > Thanks! > Emm, one more question.. Based on Konard's comments, should I split this patch, and send a new revision, or post a new SC8180X patch on top of these two existing patches? >>>> >>>> Cc: stable@vger.kernel.org >>>> Fixes: f199223cb490 ("phy: qcom: Introduce new eDP PHY driver") >>>> Signed-off-by: Yongxing Mou >>>> --- >>>> drivers/phy/qualcomm/phy-qcom-edp.c | 90 ++++++++++++++++++++++--------------- >>>> 1 file changed, 53 insertions(+), 37 deletions(-) >>>> >