From: Shuah Khan <skhan@linuxfoundation.org>
To: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>, corbet@lwn.net
Cc: akpm@linux-foundation.org, sfr@canb.auug.org.au,
hanshenghong2019@email.szu.edu.cn, vbabka@suse.cz,
georgi.djakov@linaro.org, weizhenliang@huawei.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 2/2] Documentation/vm/page_owner.rst: fix a phrase
Date: Tue, 22 Feb 2022 11:59:01 -0700 [thread overview]
Message-ID: <f27d2965-bd4d-bad3-4137-09c7f4214bd9@linuxfoundation.org> (raw)
In-Reply-To: <20220220082932.2808-1-caoyixuan2019@email.szu.edu.cn>
On 2/20/22 1:29 AM, Yixuan Cao wrote:
> I think that using "by default" will be better.
>
> Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
While you are at it could you fix others as well:
> ---
> Documentation/vm/page_owner.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
> index 2b54e82b9fe1..5ac1c12fcfc2 100644
> --- a/Documentation/vm/page_owner.rst
> +++ b/Documentation/vm/page_owner.rst
> @@ -26,7 +26,7 @@ fragmentation statistics can be obtained through gfp flag information of
> each page. It is already implemented and activated if page owner is
> enabled. Other usages are more than welcome.
>
> -page owner is disabled in default. So, if you'd like to use it, you need
> +page owner is disabled by default. So, if you'd like to use it, you need
> to add "page_owner=on" into your boot cmdline. If the kernel is built
page owner is disabled by default. So, if you'd like to use it, you need
to add "page_owner=on" to your boot cmdline.
> with page owner and page owner is disabled in runtime due to no enabling
with page owner and page owner is disabled in runtime due to not enabling
> boot option, runtime overhead is marginal. If disabled in runtime, it
>
With these fixed:
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
prev parent reply other threads:[~2022-02-22 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 8:29 Yixuan Cao
2022-02-22 18:59 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f27d2965-bd4d-bad3-4137-09c7f4214bd9@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=caoyixuan2019@email.szu.edu.cn \
--cc=corbet@lwn.net \
--cc=georgi.djakov@linaro.org \
--cc=hanshenghong2019@email.szu.edu.cn \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
--cc=weizhenliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®