mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Sayooj K Karun <sayooj@aerlync.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mac80211: mesh: tolerate missing mesh RMC cache
Date: Mon, 10 Nov 2025 08:36:15 +0100	[thread overview]
Message-ID: <f27e024e442078b51d70ce5cfdbe2beab9b822c4.camel@sipsolutions.net> (raw)
In-Reply-To: <20251109114321.10120-1-sayooj@aerlync.com>

You need to fix the subject.


>  void ieee80211s_init(void)
>  {
> -	mesh_allocated = 1;
>  	rm_cache = kmem_cache_create("mesh_rmc", sizeof(struct rmc_entry),
>  				     0, 0, NULL);
> +	if (!rm_cache) {
> +		pr_warn("mac80211: failed to allocate mesh RMC cache; duplicate filtering disabled\n");

A message after an allocation failure is almost always pointless since
it's already a really big scary warning... Maybe there's a way to
supress the original warning in this case (not sure) and then have this
message.

johannes

  reply	other threads:[~2025-11-10  7:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-09 11:43 Sayooj K Karun
2025-11-10  7:36 ` Johannes Berg [this message]
2025-11-10 16:22 ` [PATCH v2] mac80211: mesh: handle RMC cache allocation failure Sayooj K Karun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f27e024e442078b51d70ce5cfdbe2beab9b822c4.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sayooj@aerlync.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®