From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA1653806D7 for ; Tue, 24 Feb 2026 12:20:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771935646; cv=none; b=iWuVcAe3rXHV57+6qtK0oG0wS5PGMi+/D/rDVNeyBgwv6wyBv4F2EnjsPer6dWi3rT736131wOx4WVS0cvBsJVJGIDzY3Se5upbesZxp8MvlI2gMiA7Ize9v1Ph6ZvIXZTREDgcX9MUGmFWDK7AX5kiuWgCWX11Oj6fM/l+HfjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771935646; c=relaxed/simple; bh=SOQJDg8sFUhM8+VsFIcMB2KmfAEWI59OoNlz44cqRWU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jAjt6a+DS7GGIGsEhFdhMwfmZL7JNYIuOoKE1OJU279P9uJUn9Jl4t0tidGvyOHPLCEMqE9/fOlD/iemVeA9CfS3gwGUUzeFb9Hx2/lxTTglkmF1sUoIRCox1bPzSTyT2nick44RRDaB3wmdbXTf/2x+xIcW8AqbMO8QXxD7YsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N80Ongis; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DNIv06LR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N80Ongis"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DNIv06LR" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61OAFVxS1446546 for ; Tue, 24 Feb 2026 12:20:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FU/aNNjxt/IN4iVWVTZoosiC/J4FxqYyMmMiYQMpZPE=; b=N80OngisMezb6JZx W42IMbsfiuCWN3CzOY290DV18i1qojO2FN4YZvnecfodupsYpkRbX8dbBgGuSBAy FmYCDokMLvjQtvCy/XWMzXkRa7wYkkdP26qAhXf9o4CTmwaxmrQdS7IYqh3eWbnU TrzZje1alg+1WeJbN+Sh6JHTd5YK/21Wbo+l3txZH0aFn8NO+QwgPVQP2RqRbqvd SzA0zUOg98gQFwBewbSmPaFKYjQz5+sn8o2lhmnFchGYwA47EkqmFVMdVeesPS3b KgdXKvJSDKT3gN86iXAIIB+nL86kurZ/vdH7LmAO+59AceFzdo2P9lKleLWpELbO qaa0mQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cgtv9u2bb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Feb 2026 12:20:43 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-899b0035eccso571916d6.0 for ; Tue, 24 Feb 2026 04:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771935642; x=1772540442; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FU/aNNjxt/IN4iVWVTZoosiC/J4FxqYyMmMiYQMpZPE=; b=DNIv06LREGUpiLhFWqZuuxGiptADPRZ3o1UIAU5DnSOCDDXjKHdWe3QVynpCrXooyM vySzLjn9KiSy/11QVS8PUh9jQNDPeXToWT3nO8y6MvNO3inZg6DYHIeWQxNy20Q4mqEs +gbRHekw7pObUfJtISPeniAa3DHlM1PfGziMofEn5KCe0GeKn9i/RSxjpt/QjktbxNpm nZ8KpZO0YfnkWLkruErh1YOGF8Vao9q7cf16U201Lm/Vq/GEdL59BTcg/XmQk28WSSpx G8tLLwtuL+R72iwPfostPVB+7tkyGPeIREy+ZHu/odRboCNEDQgCuDmE9G/KB37RwN9I 92tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771935642; x=1772540442; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FU/aNNjxt/IN4iVWVTZoosiC/J4FxqYyMmMiYQMpZPE=; b=DPnEf00cUM4n2bqC2JWg/taj79uW2io9MMejqkiBUTHcr10ctpG3vT/T/ayOa6fGJY CwvdO22CArWi9JAKQd1j35SZlQOrr2CSpSMHwfKhRnbsP7heGz9sKtD+vVnOhgLsq0KF MhTw6iGtrGMxuxcVT3jurV2WMMp61LfO48IZZxnOcS1AXkNLd/yfYk4PdkdTFTt7lJJz 3S5Hx7BYIWkpWI40DU2ysLMiGHZiaeWbQKOh6/U2INoUHJFq+31dG1iwpZ8VReWv3Tpo 4fwut7BHVBeSNzspkQbFGB8JdiH7wXEvl5y1x91Qu5Ycx9tLC0Ho/W7GC1JehUz/6Trt 3rGw== X-Forwarded-Encrypted: i=1; AJvYcCXJErjQBK/pm2UG839tCHVRWGd4/0wW7m3ozWKyAYcGDqQDe7IGMTM9vBxVplLYqHVNBClezkoJY9Glm4s=@vger.kernel.org X-Gm-Message-State: AOJu0YzDr0dEXbD4UX3Im+UGzqMZxss+u6Qap8VShql+imHdK3XRO9hx FHwDGXGz3jDiUY4+VHEu3khhVY/x85MUYBO9Hl9zl3i/JCrEJ6ifZ8azommCileqEDx0rFkCa5D Vth5E0U1FRxyXM4xnAkv6P93kSMw4DbDjDCotbTDbhPYZ4bhmueBhb0r2GGVxpCdFfas= X-Gm-Gg: ATEYQzwSn/HSeMAbYaGlYKAigPHOZOoEHiE7SyxCtYeSVjWHgDq3Sq6zPEDaKTyI5Qg DkpHg17wxekDp6GpMTc+TKIul493J+tZC+EjTdQsM+qmrPNNueO1Lew8mQWW0Y1w+GnQpFbD9GB R+YU0o4PQ+lW5QdeszH31xs7hpZDDNYk/ojM53R1XBy5RkuSSS36oVjLZADKDnIc+nUyfYJISMH suEiFra30WHMVGA/q31avzNrjfLXEEDRfSL9qkoFbqrNpmLaDaH+wF129T+XZ57qX9v8OQw72eU 66neHZt3VtZipKn7Dv2rIyTDnpM+gwuMZyErZrUJmYTpjF1kiyl2xU5CZ2y0KyIboce1JUP7Sh0 GZ1FR9bI2aoeOYnw/mz29SgVmNts1Lz91SiUsZedOzbmtwLawmzp9MW0Fd0f4TRDWGsqEIHOOp0 RtSr8= X-Received: by 2002:a05:6214:8013:b0:897:430:df71 with SMTP id 6a1803df08f44-89979dbb183mr112360636d6.4.1771935641981; Tue, 24 Feb 2026 04:20:41 -0800 (PST) X-Received: by 2002:a05:6214:8013:b0:897:430:df71 with SMTP id 6a1803df08f44-89979dbb183mr112360426d6.4.1771935641582; Tue, 24 Feb 2026 04:20:41 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b91dacfcf77sm65761166b.13.2026.02.24.04.20.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Feb 2026 04:20:41 -0800 (PST) Message-ID: Date: Tue, 24 Feb 2026 13:20:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] clk: qcom: fix SM6115 lpasscc register offset To: Srinivas Kandagatla , lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, sboyd@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alexey.klimov@linaro.org, r.mereu@arduino.cc, srini@kenrel.org References: <20260223133950.221234-1-srinivas.kandagatla@oss.qualcomm.com> <20260223133950.221234-2-srinivas.kandagatla@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260223133950.221234-2-srinivas.kandagatla@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Vaf6/Vp9 c=1 sm=1 tr=0 ts=699d979b cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=Z76uCUixtZHKFt9jzIIA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI0MDEwMCBTYWx0ZWRfX2OJUTaQh2o4R fmksXaSTSvm93QldcfXCAlnkDAl7AsVnmHWbCEmQMzdvyu8XCuoTxXbPGNTeb+sb3u6rUg0D3gk k8EVq3UBw4MHGlkqydPYW5zhRi6TXsSdIAR0w5JAOGg1rsndWhz+4xhl117LOAu2Vtgj4wYPfzu 5ReriAaTxM3mV2xLNv1hL859OGkATjypec8Dw2uaQameOxQ/rG9m39lSSFaguCSsSJ5k9sRK6sk X2X2BSGknU+ER6Gaj68yEIExDXX1LQ2LqclAVvKCC5KwfEkvjvlsizWXXlHxMalAPGWWAcAJ9hc Lh0Lwp3CaX5TAhX2EAcO289SNVriQ/16iW4vVhGm+VOhHLgTe0/Z7W3YZr7NZ0QNaJDwPwEDEdY DhqBEhK4d1hgv5FqzttLfpnUOhIHLMH/lgjw7Haat6vksEm4G3SP7+MPG2XAZFMasdxVgJmUivv neKjyxfY789q8xFtQ+w== X-Proofpoint-ORIG-GUID: 8gxLQ0XGipyHuhl1PVu8oVMNfnt7H6JF X-Proofpoint-GUID: 8gxLQ0XGipyHuhl1PVu8oVMNfnt7H6JF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_01,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 malwarescore=0 suspectscore=0 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602240100 On 2/23/26 2:39 PM, Srinivas Kandagatla wrote: > For some reason we ended with incorrect register offset for soundwire tx > controller reset and the regmap register max was also incorrect it was > 0x1000 instead of 0x12000 which is full register range for this IP. > > This was somehow compenseated in DT reg property which got it working so > far. > > Fix this by correcting the actual offset and max registers as per SoC > documentation. > > Fixes: b076b995e225 ("clk: qcom: Add SM6115 LPASSCC") > Cc: Konrad Dybcio > Signed-off-by: Srinivas Kandagatla > --- > drivers/clk/qcom/lpasscc-sm6115.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/lpasscc-sm6115.c b/drivers/clk/qcom/lpasscc-sm6115.c > index ac6d219233b4..47adf4de2cca 100644 > --- a/drivers/clk/qcom/lpasscc-sm6115.c > +++ b/drivers/clk/qcom/lpasscc-sm6115.c > @@ -35,7 +35,7 @@ static const struct qcom_cc_desc lpass_audiocc_sm6115_reset_desc = { > }; > > static const struct qcom_reset_map lpasscc_sm6115_resets[] = { > - [LPASS_SWR_TX_CONFIG_CGCR] = { .reg = 0x100, .bit = 1, .udelay = 500 }, > + [LPASS_SWR_TX_CONFIG_CGCR] = { .reg = 0xc100, .bit = 1, .udelay = 500 }, So after taking a deeper dive, we currently define CGCR "resets" with bit(1) The CGCRs ("Clock Gating Control Registers") have: BIT(1) HW_CTL BIT(0) CLK_ENABLE so by ""asserting"" the resets, we really put the *clocks* in HW CTL mode (that's why drivers/soundwire/qcom.c only ever calls reset_control_reset() and during "configure"-type sequences) I think for not making a mess out of backwards compatiblity, we could stay with this model, but we should def write it down somewhere.. I don't know if we ever need to manually assert CLK_ENABLE from Linux. Now, interestingly, msm-4.19 techpack/audio has this hunk: /* SW workaround to gate hw_ctl for SWR version >=1.6 */ if (swrm->version >= SWRM_VERSION_1_6) { if (swrm->swrm_hctl_reg) { temp = ioread32(swrm->swrm_hctl_reg); temp &= 0xFFFFFFFD; iowrite32(temp, swrm->swrm_hctl_reg); usleep_range(500, 505); temp = ioread32(swrm->swrm_hctl_reg); dev_dbg(swrm->dev, "%s: hctl_reg val: 0x%x\n", __func__, temp); } } which clears that hw_ctl bit Konrad