mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "debug@rivosinc.com" <debug@rivosinc.com>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
	"bill.roberts@foss.arm.com" <bill.roberts@foss.arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-hardening@vger.kernel.org"
	<linux-hardening@vger.kernel.org>
Subject: Re: Shadow Stack Locking Semantics between arch's
Date: Thu, 27 Aug 2026 22:37:45 +0000	[thread overview]
Message-ID: <f2819c4f1a86845b5b2f2b6f0e03f4c334e84eaa.camel@intel.com> (raw)
In-Reply-To: <apCvGct9U1yprAUE@sirena.org.uk>

On Thu, 2026-08-27 at 22:41 +0100, Mark Brown wrote:
> On Thu, Aug 27, 2026 at 09:27:06PM +0000, Edgecombe, Rick P wrote:
> > On Thu, 2026-08-27 at 19:14 +0100, Mark Brown wrote:
> > > On Thu, Aug 27, 2026 at 12:52:28PM -0500, Bill Roberts wrote:
> 
> > > > I am proposing and have questions over the following:
> > > > 1. What should the behavior be if you had write locked and disable the
> > > > shadow stack?
> > > >   - I can argue both ways here, -EPERM or success. I think I and most arches
> > > > lead to failure.
> 
> > > Given that RISC-V doesn't support control of writes it's moot there
> > > at the minute, and x86 currently uses arch_prctl() so will need an
> > > additional API, it seems the path of least resistance is to allow it.
> > > This also avoids locking writes (or pushes, for arm64) on effectively
> > > also locking enable which seems neater.
> 
> > Hmm. I can't think of a reason to lock writes and not lock shadow stack too.
> > Given likely no one is doing this, I wonder if we could change x86's behavior to
> > match the others?
> 
> > The API would makes more sense to prevent disabling shadow stack if writes were
> > enabled. It could return an EINVAL regardless if it is locked or not? Is that
> > the arm behavior (forgetting about locked)?
> 
> arm64 currently treats each bit independently for simplicity.  The main
> use case I see for actually doing that is for preventing enabling writes
> or pushes, though in practice I'd expect something doing locks to just
> fully lock everything after having enabled the shadow stack.
> 

Locking writes as off makes sense to me. But locking writes on, while leaving
shadow stack unlocked. I'm not sure why you would do that. I thought that was
Bill's scenario.


>   We can compose
> the features easily enough so it seemed most straightforward to just let
> userspace decide what it wants, it keeps the implementation simpler.
> 
> > > It has been on my list to look at this
> > > repitition at some point, it had been held up by the clone3() stuff but
> > > that seems to have died a death for now.
> 
> > Oh? What was the blocker?
> 
> Basically the glibc people weren't convinced they'd ever want to reuse a
> shadow stack at which point having the kernel free and reallocate each time
> is just as easy.  It saves having to handle corner cases with threads that
> didn't exit cleanly.

I thought it was also because they wanted finer grained control of stack sizes
too? But yea, if no libc wants it, it's a hard sell.


  reply	other threads:[~2026-08-27 22:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 17:15 Bill Roberts
2026-08-27 17:52 ` Bill Roberts
2026-08-27 18:14   ` Mark Brown
2026-08-27 21:27     ` Edgecombe, Rick P
2026-08-27 21:41       ` Mark Brown
2026-08-27 22:37         ` Edgecombe, Rick P [this message]
2026-08-28 13:27           ` Mark Brown
2026-08-28 16:48             ` Edgecombe, Rick P
2026-08-28 17:11               ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2819c4f1a86845b5b2f2b6f0e03f4c334e84eaa.camel@intel.com \
    --to=rick.p.edgecombe@intel.com \
    --cc=bill.roberts@foss.arm.com \
    --cc=broonie@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=debug@rivosinc.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®