From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F78B23ABA0 for ; Mon, 15 Sep 2025 18:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757961867; cv=none; b=ieV60DklYLgkFRgskC/bwAf3ejsGeasVowJnecQUHGl1gR7cl4Y6IigrDS0Tma6uooSQjgoILUXkLOZJhnEHKHnBDr20V4T/XZPVKxyOcT56nARnxi0Iuu91n02XEqTrQYuhu8o6hVQvrJshkSf32uLoGpgA662uX0qGK8YjWg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757961867; c=relaxed/simple; bh=SE2vihbDwKAlgNROMqcmKFijlaF4+rdzsSF9AaPdOnA=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=II37c6QGNAXVnnCg/Km41/S9e89gylyHXnxxNcetgkJIHkk89Z7is3OSExJLqUWDlUwx2swhwYyUurzJztiEVaE75zWeLdSmHrKMjLGt3mtS9tSu8aWzVl166MNV0KXoNKkO7P8b2l2Zp9HKdUyq5YUnhKt8ghNRqRugLEbK/gE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ISisTkKq; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ISisTkKq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757961864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RVEXgGrBTb/ZutFPc/VlA9nQarWwoiDlzJd2Xlmg0EI=; b=ISisTkKqNGERTQQOCKUtW2Wgqj1trqrDHz3t29ACWFE36tncF4PNPn23a/YKUAgy7SMfzW whJGogdZWA4p9GmTMH4gO0Vk+kJhGiO80lwzyqiPdYxPpDLyZv24M1ft17z0SsW7GykmQo y0TIKxM5RASAHbcJlaCqrEGLURiRxWY= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-502-DAS5YKa4POKOXFrR45KRtw-1; Mon, 15 Sep 2025 14:44:23 -0400 X-MC-Unique: DAS5YKa4POKOXFrR45KRtw-1 X-Mimecast-MFC-AGG-ID: DAS5YKa4POKOXFrR45KRtw_1757961862 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4b7a5595a05so27838121cf.3 for ; Mon, 15 Sep 2025 11:44:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757961862; x=1758566662; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RVEXgGrBTb/ZutFPc/VlA9nQarWwoiDlzJd2Xlmg0EI=; b=TeOwGeVKaG3FF7kUACiJisNpvJVioYDiS2l6Bo+mxKIAIK+ycgh7Xuz31ss2Q1FMcu mnSIebvyg32thFF70AuXPL0PB0J8cqBesVAmZkuJkfbrdK+CZhc9n71PojYDIKYGYWC0 l/2O9T25aA4+vNhNZoQe9hdGL4lAHPmgFEs9nU+8i4lVhrc2AmrGNOdVJF+vyamixRhY tGUAC/vlHHcZ/cfsxZNhzYNhsVvu2mSl9PQ0ItVbRalHcpCKu1thq7+GCyR+SHgo7EbB xblqtUibjkh+9YSiRRbFpcrwm8PsCRZDD+IGt4beIS//4VBENboGMSMWV5EKFm7exKoM 6W/g== X-Forwarded-Encrypted: i=1; AJvYcCXmVwxVqc0RYHES6yLqZZl3TuSb7mTeRbuP3et1yWqvaRHcGcRe/RP+Jd8MAaIgeNVDQxHYPQcUu3HKaHk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzk52TW/WPzvJwDjQwRXPCGxoF6N7LHLBArWBpslRiRGNRqmEen P9uoh0tCTVOF8RAV5UbaVwV1g9op+Ku0ntmMWncw+EuzIh1InFYsa4RqOP3jD0SpwjAD+n7Yoe6 zZOT8pn/hkCI650RzPaP0EkAcmSMJlFlARG5V3OXbwNCgvNx3tZsiR3x/GnTjZGHBpw== X-Gm-Gg: ASbGncvNrEx4+K5KQiZmE6j214NqR9iV/zswvzL6v5lXXSE9+MFCtdjgxVkVTetTdwu vB6UUfUJKh4WlOp12NGJrhE+QBYo1kMlSUqHnyhqkewoPFzzMc+cOL8+Z6VnqCXHunjbmh33pwl LZMtiVomELU7IZ1dx+CCkRSFWYfI6S65/DbJqqG0V1QiAz1HKGm4V/rzkB/aNbCUI4GEWSZWp7K HMfGjahyC1BSEBhshG1UohoSnP8kNlHXC7hI+zOMu11xHz9bq1RitWQ6Rhco3yHl6ZSVMRcf84d UiCdYSh5KMgMiyPbV+vifG8gLn3npa5MJah5g5X+Zqwp2D+ZtN1rVyvuKCO/TufyVwG4yk999nC bPMvZpB+QuQ== X-Received: by 2002:a05:622a:258b:b0:4b5:d5b9:d334 with SMTP id d75a77b69052e-4b77d082f39mr156025601cf.19.1757961862504; Mon, 15 Sep 2025 11:44:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGgt0OFQVYuhp0ladKUKzrNPy4Uimg9/tb4T27rKtTw64rJmHOdbOsrKnEy9flEDySde0B+Kg== X-Received: by 2002:a05:622a:258b:b0:4b5:d5b9:d334 with SMTP id d75a77b69052e-4b77d082f39mr156025301cf.19.1757961862048; Mon, 15 Sep 2025 11:44:22 -0700 (PDT) Received: from ?IPV6:2601:188:c180:4250:ecbe:130d:668d:951d? ([2601:188:c180:4250:ecbe:130d:668d:951d]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4b639cb1b33sm71752721cf.14.2025.09.15.11.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Sep 2025 11:44:21 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: Date: Mon, 15 Sep 2025 14:44:20 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next RFC -v2 02/11] cpuset: remove unused assignment to trialcs->partition_root_state To: Chen Ridong , tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, lujialin4@huawei.com, chenridong@huawei.com References: <20250909033233.2731579-1-chenridong@huaweicloud.com> <20250909033233.2731579-3-chenridong@huaweicloud.com> Content-Language: en-US In-Reply-To: <20250909033233.2731579-3-chenridong@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/8/25 11:32 PM, Chen Ridong wrote: > From: Chen Ridong > > The trialcs->partition_root_state field is not used during the > configuration of 'cpuset.cpus' or 'cpuset.cpus.exclusive'. Therefore, > the assignment of values to this field can be safely removed. > > Signed-off-by: Chen Ridong > --- > kernel/cgroup/cpuset.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 7e1bc1e1bde1..d21c448a35e1 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -2362,7 +2362,6 @@ static int update_cpumask(struct cpuset *cs, struct cpuset *trialcs, > * trialcs->effective_xcpus is used as a temporary cpumask > * for checking validity of the partition root. > */ > - trialcs->partition_root_state = PRS_MEMBER; > if (!cpumask_empty(trialcs->exclusive_cpus) || is_partition_valid(cs)) > compute_effective_exclusive_cpumask(trialcs, NULL, cs); > } > @@ -2496,7 +2495,6 @@ static int update_exclusive_cpumask(struct cpuset *cs, struct cpuset *trialcs, > return 0; > > if (*buf) { > - trialcs->partition_root_state = PRS_MEMBER; > /* > * Reject the change if there is exclusive CPUs conflict with > * the siblings. Reviewed-by: Waiman Long